From: Timur Tabi <timur@tabi.org>
To: Martin Fuzzey <mfuzzey@parkeon.com>,
alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] Sound: sgtl5000 Allow codec clock frequency to be set.
Date: Wed, 20 Mar 2013 20:35:42 -0500 [thread overview]
Message-ID: <514A63EE.7000707@tabi.org> (raw)
In-Reply-To: <20130319170322.27828.7691.stgit@localhost>
Martin Fuzzey wrote:
> +If a clock is provided, clock-frequency is optional
> +
> +If no clock is provided clock-frequency is required (this represents the codec
> +being clocked by an external signal not present in the clock tree)
> +
> +If both a clock and clock-frequency are provided the clock's rate will be set.
> +
> +
> Example:
>
> codec: sgtl5000@0a {
> compatible = "fsl,sgtl5000";
> reg = <0x0a>;
> + clock-frequency = <20000000>;
> + clocks = <&clks 162>; /* cko1 */
The code looks okay, but I'm not sure this example is right. The binding
says that clock-frequency is optional if 'clocks' is provided, but here
you list both. You should probably have two examples.
--
Timur Tabi
WARNING: multiple messages have this Message-ID (diff)
From: timur@tabi.org (Timur Tabi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Sound: sgtl5000 Allow codec clock frequency to be set.
Date: Wed, 20 Mar 2013 20:35:42 -0500 [thread overview]
Message-ID: <514A63EE.7000707@tabi.org> (raw)
In-Reply-To: <20130319170322.27828.7691.stgit@localhost>
Martin Fuzzey wrote:
> +If a clock is provided, clock-frequency is optional
> +
> +If no clock is provided clock-frequency is required (this represents the codec
> +being clocked by an external signal not present in the clock tree)
> +
> +If both a clock and clock-frequency are provided the clock's rate will be set.
> +
> +
> Example:
>
> codec: sgtl5000 at 0a {
> compatible = "fsl,sgtl5000";
> reg = <0x0a>;
> + clock-frequency = <20000000>;
> + clocks = <&clks 162>; /* cko1 */
The code looks okay, but I'm not sure this example is right. The binding
says that clock-frequency is optional if 'clocks' is provided, but here
you list both. You should probably have two examples.
--
Timur Tabi
next prev parent reply other threads:[~2013-03-21 1:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 17:03 [PATCH] Sound: sgtl5000 Allow codec clock frequency to be set Martin Fuzzey
2013-03-19 17:03 ` Martin Fuzzey
2013-03-21 1:35 ` Timur Tabi [this message]
2013-03-21 1:35 ` Timur Tabi
2013-03-21 8:39 ` Martin Fuzzey
2013-03-21 8:39 ` Martin Fuzzey
2013-03-21 16:11 ` Timur Tabi
2013-03-21 16:11 ` Timur Tabi
2013-03-21 17:46 ` Martin Fuzzey
2013-03-21 17:46 ` Martin Fuzzey
2013-03-21 17:52 ` Timur Tabi
2013-03-21 17:52 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=514A63EE.7000707@tabi.org \
--to=timur@tabi.org \
--cc=alsa-devel@alsa-project.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mfuzzey@parkeon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.