From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] rtc: rtc-at91rm9200: use a variable for storing IMR
Date: Thu, 21 Mar 2013 10:46:26 +0100 [thread overview]
Message-ID: <514AD6F2.20701@atmel.com> (raw)
In-Reply-To: <20130320145006.f1431c1528325ff93a298790@linux-foundation.org>
On 03/20/2013 10:50 PM, Andrew Morton :
> On Fri, 15 Mar 2013 18:37:12 +0100 Nicolas Ferre <nicolas.ferre@atmel.com> wrote:
>
>> On some revisions of AT91 SoCs, the RTC IMR register is not working.
>> Instead of elaborating a workaround for that specific SoC or IP version,
>> we simply use a software variable to store the Interrupt Mask Register and
>> modify it for each enabling/disabling of an interrupt. The overhead of this
>> is negligible anyway.
>
> This description doesn't really allow me or others to work out whether
> the fix should be included in 3.9 or backported into earlier kernels.
>
> So please, when fixing a bug do include a full description of the
> user-visible effects of that bug. And your opinion regarding the
> -mainline and -stable decision is always useful.
Yes, sure.
Concerning this patch, we can imagine to push it upstream as a bugfix
for 3.9-rc. It is not a regression because... well... it has never
worked properly on the affected SoC family.
For -stable, we can add this tag:
Cc: stable <stable@vger.kernel.org> [v3.8+]
As this patch applies up to this revision. For other kernel releases, I
will need to rework the patch a little bit due to files name modifications.
Thanks, best regards,
--
Nicolas Ferre
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
"Ludovic Desroches" <ludovic.desroches@atmel.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <dgilbert@interlog.com>
Subject: Re: [PATCH] rtc: rtc-at91rm9200: use a variable for storing IMR
Date: Thu, 21 Mar 2013 10:46:26 +0100 [thread overview]
Message-ID: <514AD6F2.20701@atmel.com> (raw)
In-Reply-To: <20130320145006.f1431c1528325ff93a298790@linux-foundation.org>
On 03/20/2013 10:50 PM, Andrew Morton :
> On Fri, 15 Mar 2013 18:37:12 +0100 Nicolas Ferre <nicolas.ferre@atmel.com> wrote:
>
>> On some revisions of AT91 SoCs, the RTC IMR register is not working.
>> Instead of elaborating a workaround for that specific SoC or IP version,
>> we simply use a software variable to store the Interrupt Mask Register and
>> modify it for each enabling/disabling of an interrupt. The overhead of this
>> is negligible anyway.
>
> This description doesn't really allow me or others to work out whether
> the fix should be included in 3.9 or backported into earlier kernels.
>
> So please, when fixing a bug do include a full description of the
> user-visible effects of that bug. And your opinion regarding the
> -mainline and -stable decision is always useful.
Yes, sure.
Concerning this patch, we can imagine to push it upstream as a bugfix
for 3.9-rc. It is not a regression because... well... it has never
worked properly on the affected SoC family.
For -stable, we can add this tag:
Cc: stable <stable@vger.kernel.org> [v3.8+]
As this patch applies up to this revision. For other kernel releases, I
will need to rework the patch a little bit due to files name modifications.
Thanks, best regards,
--
Nicolas Ferre
next prev parent reply other threads:[~2013-03-21 9:46 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-15 17:37 [PATCH] rtc: rtc-at91rm9200: use a variable for storing IMR Nicolas Ferre
2013-03-15 17:37 ` Nicolas Ferre
2013-03-20 21:50 ` Andrew Morton
2013-03-20 21:50 ` Andrew Morton
2013-03-21 1:15 ` Douglas Gilbert
2013-03-21 1:15 ` Douglas Gilbert
2013-03-21 21:33 ` Andrew Morton
2013-03-21 21:33 ` Andrew Morton
2013-03-21 9:46 ` Nicolas Ferre [this message]
2013-03-21 9:46 ` Nicolas Ferre
2013-03-26 19:27 ` Johan Hovold
2013-03-26 19:27 ` Johan Hovold
2013-03-26 21:09 ` Douglas Gilbert
2013-03-26 21:09 ` Douglas Gilbert
2013-03-28 9:57 ` Johan Hovold
2013-03-28 9:57 ` Johan Hovold
2013-03-28 16:16 ` Nicolas Ferre
2013-03-28 16:16 ` Nicolas Ferre
2013-03-29 15:57 ` Johan Hovold
2013-03-29 15:57 ` Johan Hovold
2013-03-28 18:20 ` Douglas Gilbert
2013-03-28 18:20 ` Douglas Gilbert
2013-03-29 15:45 ` Nicolas Ferre
2013-03-29 15:45 ` Nicolas Ferre
2013-03-29 16:01 ` Johan Hovold
2013-03-29 16:01 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=514AD6F2.20701@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.