From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Fix bootdelay timeout calculation when SYS_HZ!=1000
Date: Thu, 21 Mar 2013 09:50:46 -0400 [thread overview]
Message-ID: <514B1036.3090400@ti.com> (raw)
In-Reply-To: <20130321065553.BC624200547@gemini.denx.de>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 03/21/2013 02:55 AM, Wolfgang Denk wrote:
> Dear Stephen Warren,
>
> In message <1363842874-8286-1-git-send-email-swarren@wwwdotorg.org>
> you wrote:
>> Commit b2f3e0e "console: USB: KBD: Fix incorrect autoboot
>> timeout" re-wrote the bootdelay timeout loop. However, it
>> hard-coded the value that get_delay() was expected to increment
>> in one second, rather than calculating it based on CONFIG_SYS_HZ.
>> On systems where SYS_HZ != 1000, this caused bootdelay timeout to
>> be incorrect. Fix this.
>
> Are there any such systems left? I agree with your patch, but if
> you know of systems that use incorrect values of CONFIG_SYS_HZ then
> please point these out so they can be fixed!
>
> A system with CONFIG_SYS_HZ != 1000 is _broken_.
So, RPi is going higher, and Jon hit this on I suspect omap2420h4
which is also higher (after mathing that all out). If we no longer
support CONFIG_SYS_HZ != 1000 we need to make that clear (and explain
why).
- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJRSxA2AAoJENk4IS6UOR1WPzwP/3f+BiTw3s9cWGZKOb4gDza3
n0ke0rZdqLkwixK3Ugl5IqcquTLEh5QZcZb37cGgWQ0N0YvUoIxcBR73mWSHhQgy
VMlVU0vtlrGQsFmN0kbouO+qpzyoAkaDidt6T/WxDazgd+CoCuHguXki1peEB/HQ
ryQ6yNOog5dFUux85cL+AmWZYRkGXRWJfrIqKHZ9MPvz3TxXjhFBZ4lR+8JwMWgS
wPIFhNMTWnIHvXCfbcumFXV0Lgyn0DYnCbKIMLM/NucRKcHX8ZYnX1L8UOGvRzZn
jjqKFm95dNvPhZLLAaZI2TmVu5YMR9VZmmZpst0VC3eACkcQ+70G8CA+3ApmTC2C
3FcLnQQnWlG83/3qj23Qc6trLsk17spEIN0GaSy5ow261sbsXotLEsw0K7luaZPM
Y6KF5cZSyqQZ9TdnIbVxtcsI0Vwk5lLvtB91qleAJDrqn9o4ugEl0IWcRlwN9t9a
DQM0t/P+DotOlLdVQ6elVcimVxBvKLJEMIcdJVyKqsnOQIs9ct9fPm9j03ZRpS9S
YlvegCU/n0J25RVtZL6+hpOQa2ZkZOyFg3sZwSLx42jDilvIYemYcGaH21C64prJ
HJ7+rnxPvK1lC4DPVP0QoIrQEpgABnTZfDaLsts/z3sq2m4+S9uZHqiwyBJ4luoa
ua2LQXAovkSF1FA2kV1I
=VTCE
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2013-03-21 13:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-21 5:14 [U-Boot] [PATCH] Fix bootdelay timeout calculation when SYS_HZ!=1000 Stephen Warren
2013-03-21 6:55 ` Wolfgang Denk
2013-03-21 13:50 ` Tom Rini [this message]
2013-03-21 14:35 ` Wolfgang Denk
2013-03-21 14:41 ` Tom Rini
2013-03-21 15:25 ` Jon Hunter
2013-03-21 15:28 ` Tom Rini
2013-03-21 18:07 ` Jon Hunter
2013-03-21 18:26 ` Tom Rini
2013-03-21 16:04 ` Stephen Warren
2013-03-21 19:17 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=514B1036.3090400@ti.com \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.