From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Fix bootdelay timeout calculation when SYS_HZ!=1000
Date: Thu, 21 Mar 2013 10:04:30 -0600 [thread overview]
Message-ID: <514B2F8E.2090409@wwwdotorg.org> (raw)
In-Reply-To: <20130321065553.BC624200547@gemini.denx.de>
On 03/21/2013 12:55 AM, Wolfgang Denk wrote:
> Dear Stephen Warren,
>
> In message <1363842874-8286-1-git-send-email-swarren@wwwdotorg.org> you wrote:
>> Commit b2f3e0e "console: USB: KBD: Fix incorrect autoboot timeout"
>> re-wrote the bootdelay timeout loop. However, it hard-coded the value
>> that get_delay() was expected to increment in one second, rather than
>> calculating it based on CONFIG_SYS_HZ. On systems where SYS_HZ != 1000,
>> this caused bootdelay timeout to be incorrect. Fix this.
>
> Are there any such systems left? I agree with your patch, but if you
> know of systems that use incorrect values of CONFIG_SYS_HZ then please
> point these out so they can be fixed!
>
> A system with CONFIG_SYS_HZ != 1000 is _broken_.
Then why does the config option still exist; surely it should be
removed, or defined somewhere other than the per-board config file?
next prev parent reply other threads:[~2013-03-21 16:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-21 5:14 [U-Boot] [PATCH] Fix bootdelay timeout calculation when SYS_HZ!=1000 Stephen Warren
2013-03-21 6:55 ` Wolfgang Denk
2013-03-21 13:50 ` Tom Rini
2013-03-21 14:35 ` Wolfgang Denk
2013-03-21 14:41 ` Tom Rini
2013-03-21 15:25 ` Jon Hunter
2013-03-21 15:28 ` Tom Rini
2013-03-21 18:07 ` Jon Hunter
2013-03-21 18:26 ` Tom Rini
2013-03-21 16:04 ` Stephen Warren [this message]
2013-03-21 19:17 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=514B2F8E.2090409@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.