All of lore.kernel.org
 help / color / mirror / Atom feed
From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/5] arm: dts: Convert mvebu device tree files to 64 bits
Date: Thu, 21 Mar 2013 12:59:21 -0500	[thread overview]
Message-ID: <514B4A79.1070501@gmail.com> (raw)
In-Reply-To: <1363883179-1361-6-git-send-email-gregory.clement@free-electrons.com>

On 03/21/2013 11:26 AM, Gregory CLEMENT wrote:
> In order to be able to use more than 4GB of RAM when the LPAE is
> activated, the dts must be converted in 64 bits.
> 
> Armada XP and Armada 370 share a dtsi file which have also be
> converted to 64 bits. This lead to convert all the device tree files
> to 64 bits even the one used for Armada 370 (which don't support
> LPAE)
> 
> This was heavily based on the work of Lior Amsalem.
> 
> Signed-off-by: Lior Amsalem <alior@marvell.com>
> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>

[snip]

> diff --git a/arch/arm/boot/dts/armada-370-xp.dtsi b/arch/arm/boot/dts/armada-370-xp.dtsi
> index 5b70820..562f24c 100644
> --- a/arch/arm/boot/dts/armada-370-xp.dtsi
> +++ b/arch/arm/boot/dts/armada-370-xp.dtsi
> @@ -15,8 +15,7 @@
>   * This file contains the definitions that are common to the Armada
>   * 370 and Armada XP SoC.
>   */
> -
> -/include/ "skeleton.dtsi"
> +/include/ "skeleton64.dtsi"
>  
>  / {
>  	model = "Marvell Armada 370 and XP SoC";
> @@ -37,20 +36,20 @@
>  
>  	coherency-fabric at d0020200 {
>  		compatible = "marvell,coherency-fabric";
> -		reg = <0xd0020200 0xb0>,
> -		      <0xd0021810 0x1c>;
> +		reg = <0 0xd0020200 0 0xb0>,
> +		      <0 0xd0021810 0 0x1c>;
>  	};
>  
>  	soc {
> -		#address-cells = <1>;
> -		#size-cells = <1>;
> +		#address-cells = <2>;
> +		#size-cells = <2>;

If all the addresses for the soc bus are below 4GB or even within a 4GB
range if using the ranges property, then changing all this and
everything below it is kind of pointless.

Rob

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robherring2@gmail.com>
To: Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
	Grant Likely <grant.likely@secretlab.ca>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
	linux-arm-kernel@lists.infradead.org,
	devicetree-discuss@lists.ozlabs.org,
	linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	Olof Johansson <olof@lixom.net>, Nicolas Pitre <nico@fluxnic.net>,
	Lior Amsalem <alior@marvell.com>,
	Maen Suleiman <maen@marvell.com>,
	Tawfik Bayouk <tawfik@marvell.com>,
	Shadi Ammouri <shadi@marvell.com>,
	Eran Ben-Avi <benavi@marvell.com>,
	Yehuda Yitschak <yehuday@marvell.com>,
	Nadav Haklai <nadavh@marvell.com>,
	Ike Pan <ike.pan@canonical.com>,
	Chris Van Hoof <vanhoof@canonical.com>,
	Dan Frazier <dann.frazier@canonical.com>,
	Leif Lindholm <leif.lindholm@arm.com>,
	Jon Masters <jcm@redhat.com>, David Marlin <dmarlin@>
Subject: Re: [PATCH 5/5] arm: dts: Convert mvebu device tree files to 64 bits
Date: Thu, 21 Mar 2013 12:59:21 -0500	[thread overview]
Message-ID: <514B4A79.1070501@gmail.com> (raw)
In-Reply-To: <1363883179-1361-6-git-send-email-gregory.clement@free-electrons.com>

On 03/21/2013 11:26 AM, Gregory CLEMENT wrote:
> In order to be able to use more than 4GB of RAM when the LPAE is
> activated, the dts must be converted in 64 bits.
> 
> Armada XP and Armada 370 share a dtsi file which have also be
> converted to 64 bits. This lead to convert all the device tree files
> to 64 bits even the one used for Armada 370 (which don't support
> LPAE)
> 
> This was heavily based on the work of Lior Amsalem.
> 
> Signed-off-by: Lior Amsalem <alior@marvell.com>
> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>

[snip]

> diff --git a/arch/arm/boot/dts/armada-370-xp.dtsi b/arch/arm/boot/dts/armada-370-xp.dtsi
> index 5b70820..562f24c 100644
> --- a/arch/arm/boot/dts/armada-370-xp.dtsi
> +++ b/arch/arm/boot/dts/armada-370-xp.dtsi
> @@ -15,8 +15,7 @@
>   * This file contains the definitions that are common to the Armada
>   * 370 and Armada XP SoC.
>   */
> -
> -/include/ "skeleton.dtsi"
> +/include/ "skeleton64.dtsi"
>  
>  / {
>  	model = "Marvell Armada 370 and XP SoC";
> @@ -37,20 +36,20 @@
>  
>  	coherency-fabric@d0020200 {
>  		compatible = "marvell,coherency-fabric";
> -		reg = <0xd0020200 0xb0>,
> -		      <0xd0021810 0x1c>;
> +		reg = <0 0xd0020200 0 0xb0>,
> +		      <0 0xd0021810 0 0x1c>;
>  	};
>  
>  	soc {
> -		#address-cells = <1>;
> -		#size-cells = <1>;
> +		#address-cells = <2>;
> +		#size-cells = <2>;

If all the addresses for the soc bus are below 4GB or even within a 4GB
range if using the ranges property, then changing all this and
everything below it is kind of pointless.

Rob

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robherring2@gmail.com>
To: Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
	Grant Likely <grant.likely@secretlab.ca>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
	linux-arm-kernel@lists.infradead.org,
	devicetree-discuss@lists.ozlabs.org,
	linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	Olof Johansson <olof@lixom.net>, Nicolas Pitre <nico@fluxnic.net>,
	Lior Amsalem <alior@marvell.com>,
	Maen Suleiman <maen@marvell.com>,
	Tawfik Bayouk <tawfik@marvell.com>,
	Shadi Ammouri <shadi@marvell.com>,
	Eran Ben-Avi <benavi@marvell.com>,
	Yehuda Yitschak <yehuday@marvell.com>,
	Nadav Haklai <nadavh@marvell.com>,
	Ike Pan <ike.pan@canonical.com>,
	Chris Van Hoof <vanhoof@canonical.com>,
	Dan Frazier <dann.frazier@canonical.com>,
	Leif Lindholm <leif.lindholm@arm.com>,
	Jon Masters <jcm@redhat.com>, David Marlin <dmarlin@redhat.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH 5/5] arm: dts: Convert mvebu device tree files to 64 bits
Date: Thu, 21 Mar 2013 12:59:21 -0500	[thread overview]
Message-ID: <514B4A79.1070501@gmail.com> (raw)
In-Reply-To: <1363883179-1361-6-git-send-email-gregory.clement@free-electrons.com>

On 03/21/2013 11:26 AM, Gregory CLEMENT wrote:
> In order to be able to use more than 4GB of RAM when the LPAE is
> activated, the dts must be converted in 64 bits.
> 
> Armada XP and Armada 370 share a dtsi file which have also be
> converted to 64 bits. This lead to convert all the device tree files
> to 64 bits even the one used for Armada 370 (which don't support
> LPAE)
> 
> This was heavily based on the work of Lior Amsalem.
> 
> Signed-off-by: Lior Amsalem <alior@marvell.com>
> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>

[snip]

> diff --git a/arch/arm/boot/dts/armada-370-xp.dtsi b/arch/arm/boot/dts/armada-370-xp.dtsi
> index 5b70820..562f24c 100644
> --- a/arch/arm/boot/dts/armada-370-xp.dtsi
> +++ b/arch/arm/boot/dts/armada-370-xp.dtsi
> @@ -15,8 +15,7 @@
>   * This file contains the definitions that are common to the Armada
>   * 370 and Armada XP SoC.
>   */
> -
> -/include/ "skeleton.dtsi"
> +/include/ "skeleton64.dtsi"
>  
>  / {
>  	model = "Marvell Armada 370 and XP SoC";
> @@ -37,20 +36,20 @@
>  
>  	coherency-fabric@d0020200 {
>  		compatible = "marvell,coherency-fabric";
> -		reg = <0xd0020200 0xb0>,
> -		      <0xd0021810 0x1c>;
> +		reg = <0 0xd0020200 0 0xb0>,
> +		      <0 0xd0021810 0 0x1c>;
>  	};
>  
>  	soc {
> -		#address-cells = <1>;
> -		#size-cells = <1>;
> +		#address-cells = <2>;
> +		#size-cells = <2>;

If all the addresses for the soc bus are below 4GB or even within a 4GB
range if using the ranges property, then changing all this and
everything below it is kind of pointless.

Rob


  reply	other threads:[~2013-03-21 17:59 UTC|newest]

Thread overview: 90+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-21 16:26 [PATCH 0/5] arm: mvebu: Enable LPAE support for Armada XP SoCs Gregory CLEMENT
2013-03-21 16:26 ` Gregory CLEMENT
2013-03-21 16:26 ` Gregory CLEMENT
2013-03-21 16:26 ` [PATCH 1/5] arm: mvebu: Aligne the internal registers virtual base to support LPAE Gregory CLEMENT
2013-03-21 16:26   ` Gregory CLEMENT
2013-03-21 16:26   ` Gregory CLEMENT
2013-03-21 16:26 ` [PATCH 2/5] arm: mvebu: Select DMA_BOUNCE when LPAE is selected in Kconfig Gregory CLEMENT
2013-03-21 16:26   ` Gregory CLEMENT
2013-03-21 16:26   ` Gregory CLEMENT
2013-03-21 18:19   ` Rob Herring
2013-03-21 18:19     ` Rob Herring
2013-03-21 19:18   ` Andrew Lunn
2013-03-21 19:18     ` Andrew Lunn
2013-03-21 19:18     ` Andrew Lunn
2013-03-22 11:32   ` Russell King - ARM Linux
2013-03-22 11:32     ` Russell King - ARM Linux
2013-03-22 11:32     ` Russell King - ARM Linux
     [not found]     ` <20130322113251.GB4977-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2013-03-23 19:48       ` Krzysztof Halasa
2013-03-21 16:26 ` [PATCH 3/5] arm: mvebu: Enable pj4b on LPAE compilations Gregory CLEMENT
2013-03-21 16:26   ` Gregory CLEMENT
2013-03-21 16:26   ` Gregory CLEMENT
2013-03-21 16:26 ` [PATCH 4/5] arm: dts: Add a 64 bits version of the skeleton device tree Gregory CLEMENT
2013-03-21 16:26   ` Gregory CLEMENT
2013-03-21 16:26   ` Gregory CLEMENT
2013-03-21 16:26 ` [PATCH 5/5] arm: dts: Convert mvebu device tree files to 64 bits Gregory CLEMENT
2013-03-21 16:26   ` Gregory CLEMENT
2013-03-21 16:26   ` Gregory CLEMENT
2013-03-21 17:59   ` Rob Herring [this message]
2013-03-21 17:59     ` Rob Herring
2013-03-21 17:59     ` Rob Herring
2013-03-21 19:03     ` Arnd Bergmann
2013-03-21 19:03       ` Arnd Bergmann
2013-03-21 19:03       ` Arnd Bergmann
2013-03-21 19:18       ` Thomas Petazzoni
2013-03-21 19:18         ` Thomas Petazzoni
2013-03-21 19:18         ` Thomas Petazzoni
2013-03-21 21:31         ` Arnd Bergmann
2013-03-21 21:31           ` Arnd Bergmann
2013-03-21 21:31           ` Arnd Bergmann
2013-03-21 22:30           ` Sebastian Hesselbarth
2013-03-21 22:30             ` Sebastian Hesselbarth
2013-03-21 22:30             ` Sebastian Hesselbarth
2013-03-21 20:15   ` Andrew Lunn
2013-03-21 20:15     ` Andrew Lunn
2013-03-21 20:15     ` Andrew Lunn
2013-03-21 20:22     ` Thomas Petazzoni
2013-03-21 20:22       ` Thomas Petazzoni
2013-03-21 20:22       ` Thomas Petazzoni
2013-03-21 20:30       ` Jason Cooper
2013-03-21 20:30         ` Jason Cooper
2013-03-21 20:30         ` Jason Cooper
2013-03-21 20:37       ` Andrew Lunn
2013-03-21 20:37         ` Andrew Lunn
2013-03-21 20:37         ` Andrew Lunn
2013-03-21 21:08         ` Thomas Petazzoni
2013-03-21 21:08           ` Thomas Petazzoni
2013-03-21 21:08           ` Thomas Petazzoni
2013-03-21 21:16         ` Thomas Petazzoni
2013-03-21 21:16           ` Thomas Petazzoni
2013-03-21 21:16           ` Thomas Petazzoni
2013-03-21 20:55       ` Jason Gunthorpe
2013-03-21 20:55         ` Jason Gunthorpe
2013-03-21 20:55         ` Jason Gunthorpe
2013-03-21 21:15         ` Thomas Petazzoni
2013-03-21 21:15           ` Thomas Petazzoni
2013-03-21 21:15           ` Thomas Petazzoni
2013-03-21 21:35           ` Lior Amsalem
2013-03-21 21:35             ` Lior Amsalem
2013-03-21 21:46             ` Jason Gunthorpe
2013-03-21 21:46               ` Jason Gunthorpe
2013-03-21 21:58               ` Lior Amsalem
2013-03-21 21:58                 ` Lior Amsalem
2013-03-22  6:55                 ` Arnd Bergmann
2013-03-22  6:55                   ` Arnd Bergmann
2013-03-21 21:41           ` Jason Gunthorpe
2013-03-21 21:41             ` Jason Gunthorpe
2013-03-21 21:41             ` Jason Gunthorpe
2013-03-21 22:26             ` Sebastian Hesselbarth
2013-03-21 22:26               ` Sebastian Hesselbarth
2013-03-21 22:26               ` Sebastian Hesselbarth
2013-03-22  9:55             ` Arnd Bergmann
2013-03-22  9:55               ` Arnd Bergmann
2013-03-21 21:25         ` Andrew Lunn
2013-03-21 21:25           ` Andrew Lunn
2013-03-22  6:28         ` Andrew Lunn
2013-03-22  6:28           ` Andrew Lunn
2013-03-22 17:43           ` Jason Gunthorpe
2013-03-22 17:43             ` Jason Gunthorpe
2013-03-22 19:33             ` Arnd Bergmann
2013-03-22 19:33               ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=514B4A79.1070501@gmail.com \
    --to=robherring2@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.