Re: [PATCH 03/14] ASoC: omap-pcm: No need to wrap snd_dmaengine_pcm_close()

[Peter Ujfalusi <peter.ujfalusi@ti.com>]

On 03/22/2013 02:12 PM, Lars-Peter Clausen wrote:
> If a PCM driver using the dmaengine PCM helper functions doesn't need to do
> anything special in its pcm_close callback, snd_dmaengine_pcm_close can be used
> directly for as the pcm_close callback and there is no need to wrap it in a
> custom function.
> 
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Cc: Jarkko Nikula <jarkko.nikula@bitmer.com>
> Cc: Sebastien Guiriec <s-guiriec@ti.com>
> ---

Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>

>  sound/soc/omap/omap-pcm.c | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/sound/soc/omap/omap-pcm.c b/sound/soc/omap/omap-pcm.c
> index c722c2e..c6f477c 100644
> --- a/sound/soc/omap/omap-pcm.c
> +++ b/sound/soc/omap/omap-pcm.c
> @@ -185,12 +185,6 @@ static int omap_pcm_open(struct snd_pcm_substream *substream)
>  				      &dma_data->dma_req);
>  }
>  
> -static int omap_pcm_close(struct snd_pcm_substream *substream)
> -{
> -	snd_dmaengine_pcm_close(substream);
> -	return 0;
> -}
> -
>  static int omap_pcm_mmap(struct snd_pcm_substream *substream,
>  	struct vm_area_struct *vma)
>  {
> @@ -204,7 +198,7 @@ static int omap_pcm_mmap(struct snd_pcm_substream *substream,
>  
>  static struct snd_pcm_ops omap_pcm_ops = {
>  	.open		= omap_pcm_open,
> -	.close		= omap_pcm_close,
> +	.close		= snd_dmaengine_pcm_close,
>  	.ioctl		= snd_pcm_lib_ioctl,
>  	.hw_params	= omap_pcm_hw_params,
>  	.hw_free	= omap_pcm_hw_free,
> 


-- 
Péter