From: Ola Lilja <ola.o.lilja@stericsson.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH 07/14] ASoC: ux500_pcm: No need to use snd_dmaengine_pcm_set_data()
Date: Fri, 22 Mar 2013 16:01:04 +0100 [thread overview]
Message-ID: <514C7230.5070408@stericsson.com> (raw)
In-Reply-To: <1363957934-20059-8-git-send-email-lars@metafoo.de>
Acked.
Regards,
Ola
On 03/22/2013 02:12 PM, Lars-Peter Clausen wrote:
> The driver never uses snd_dmaengine_pcm_get_data(), so there is no need to use
> snd_dmaengine_pcm_set_data().
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Ola Lilja <ola.o.lilja@stericsson.com>
> ---
> sound/soc/ux500/ux500_pcm.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/sound/soc/ux500/ux500_pcm.c b/sound/soc/ux500/ux500_pcm.c
> index d000ba2..1ab36fa 100644
> --- a/sound/soc/ux500/ux500_pcm.c
> +++ b/sound/soc/ux500/ux500_pcm.c
> @@ -155,8 +155,6 @@ static int ux500_pcm_open(struct snd_pcm_substream *substream)
> return ret;
> }
>
> - snd_dmaengine_pcm_set_data(substream, dma_cfg);
> -
> return 0;
> }
>
next prev parent reply other threads:[~2013-03-22 15:01 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-22 13:12 [PATCH 00/14] ASoC: Cleanup dmaengine PCM users Lars-Peter Clausen
2013-03-22 13:12 ` [PATCH 01/14] ASoC: ux500_pcm: Remove duplicated SNDRV_PCM_HW_PARAM_PERIODS constraint Lars-Peter Clausen
2013-03-22 14:35 ` Ola Lilja
2013-03-22 13:12 ` [PATCH 02/14] ASoC: spear_pcm: No need to wrap snd_dmaengine_pcm_close() Lars-Peter Clausen
2013-03-25 3:51 ` Rajeev kumar
2013-03-22 13:12 ` [PATCH 03/14] ASoC: omap-pcm: " Lars-Peter Clausen
2013-03-22 13:13 ` Peter Ujfalusi
2013-03-22 14:15 ` Jarkko Nikula
2013-03-22 13:12 ` [PATCH 04/14] ASoC: tegra_pcm: " Lars-Peter Clausen
2013-03-22 15:44 ` Stephen Warren
2013-03-22 13:12 ` [PATCH 05/14] ASoC: ux500_pcm: " Lars-Peter Clausen
2013-03-22 14:36 ` Ola Lilja
2013-03-22 13:12 ` [PATCH 06/14] ASoC: atmel-pcm-dma: " Lars-Peter Clausen
2013-03-25 8:37 ` Bo Shen
2013-03-22 13:12 ` [PATCH 07/14] ASoC: ux500_pcm: No need to use snd_dmaengine_pcm_set_data() Lars-Peter Clausen
2013-03-22 15:01 ` Ola Lilja [this message]
2013-03-26 14:16 ` Mark Brown
2013-03-22 13:12 ` [PATCH 08/14] ASoC: speaer_pcm: " Lars-Peter Clausen
2013-03-25 3:59 ` Rajeev kumar
2013-03-25 8:22 ` Lars-Peter Clausen
2013-03-25 8:36 ` Rajeev kumar
2013-03-22 13:12 ` [PATCH 09/14] ASoC: atmel-pcm-dma: Do not use snd_dmaengine_pcm_{set, get}_data() Lars-Peter Clausen
2013-03-25 8:39 ` Bo Shen
2013-03-22 13:12 ` [PATCH 10/14] ASoC: ep93xx: Use ep93xx_dma_params instead of ep93xx_pcm_dma_params Lars-Peter Clausen
2013-03-22 13:12 ` [PATCH 11/14] ASoC: mmp-pcm: Allocate dma filter parameters on the stack Lars-Peter Clausen
2013-03-22 13:12 ` [PATCH 12/14] ASoC: imx-pcm: Embed the imx_dma_data struct in the dma_params struct Lars-Peter Clausen
2013-03-25 2:33 ` Shawn Guo
2013-03-22 13:12 ` [PATCH 13/14] ASoC: mxs: Embed the mxs_dma_data struct in the mxs_pcm_dma_params struct Lars-Peter Clausen
2013-03-25 2:04 ` Shawn Guo
2013-03-22 13:12 ` [PATCH 14/14] ASoC: dmaengine-pcm: Remove snd_dmaengine_pcm_{set, get}_data Lars-Peter Clausen
2013-03-26 14:18 ` [PATCH 00/14] ASoC: Cleanup dmaengine PCM users Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=514C7230.5070408@stericsson.com \
--to=ola.o.lilja@stericsson.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.