All of lore.kernel.org
 help / color / mirror / Atom feed
From: nsekhar@ti.com (Sekhar Nori)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] media: davinci: vpbe: venc: move the enabling of vpss clocks to driver
Date: Mon, 25 Mar 2013 11:09:19 +0530	[thread overview]
Message-ID: <514FE307.5090201@ti.com> (raw)
In-Reply-To: <1363938793-22246-3-git-send-email-prabhakar.csengg@gmail.com>

On 3/22/2013 1:23 PM, Prabhakar lad wrote:
> From: Lad, Prabhakar <prabhakar.csengg@gmail.com>
> 
> The vpss clocks were enabled by calling a exported function from a driver
> in a machine code. calling driver code from platform code is incorrect way.
> 
> This patch fixes this issue and calls the function from driver code itself.
> 
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
> ---
>  Note: This patch is based on the comment from Sekhar
>       (https://patchwork-mail1.kernel.org/patch/2278441/).
>       Shekar I haven't completely removed the callback, I just added
>       the function calls after the callback. As you mentioned just to
>       pass the VPSS_CLK_CTRL as a resource to venc but the VPSS_CLK_CTRL
>       is already being used by VPSS driver. I'll take this cleanup task later
>       point of time.

Fine by me.

Thanks,
Sekhar

WARNING: multiple messages have this Message-ID (diff)
From: Sekhar Nori <nsekhar@ti.com>
To: Prabhakar lad <prabhakar.csengg@gmail.com>
Cc: LMML <linux-media@vger.kernel.org>,
	DLOS <davinci-linux-open-source@linux.davincidsp.com>,
	LAK <linux-arm-kernel@lists.infradead.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Mauro Carvalho Chehab <mchehab@redhat.com>
Subject: Re: [PATCH 2/2] media: davinci: vpbe: venc: move the enabling of vpss clocks to driver
Date: Mon, 25 Mar 2013 11:09:19 +0530	[thread overview]
Message-ID: <514FE307.5090201@ti.com> (raw)
In-Reply-To: <1363938793-22246-3-git-send-email-prabhakar.csengg@gmail.com>

On 3/22/2013 1:23 PM, Prabhakar lad wrote:
> From: Lad, Prabhakar <prabhakar.csengg@gmail.com>
> 
> The vpss clocks were enabled by calling a exported function from a driver
> in a machine code. calling driver code from platform code is incorrect way.
> 
> This patch fixes this issue and calls the function from driver code itself.
> 
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
> ---
>  Note: This patch is based on the comment from Sekhar
>       (https://patchwork-mail1.kernel.org/patch/2278441/).
>       Shekar I haven't completely removed the callback, I just added
>       the function calls after the callback. As you mentioned just to
>       pass the VPSS_CLK_CTRL as a resource to venc but the VPSS_CLK_CTRL
>       is already being used by VPSS driver. I'll take this cleanup task later
>       point of time.

Fine by me.

Thanks,
Sekhar

  reply	other threads:[~2013-03-25  5:39 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-22  7:53 [PATCH 0/2] davinci: vpss: clock cleanup Prabhakar lad
2013-03-22  7:53 ` Prabhakar lad
2013-03-22  7:53 ` [PATCH 1/2] media: davinci: vpss: enable vpss clocks Prabhakar lad
2013-03-22  7:53   ` Prabhakar lad
2013-03-25  5:32   ` Sekhar Nori
2013-03-25  5:32     ` Sekhar Nori
2013-03-25 10:14     ` Prabhakar Lad
2013-03-25 10:14       ` Prabhakar Lad
2013-03-25 10:24       ` Sekhar Nori
2013-03-25 10:24         ` Sekhar Nori
2013-03-25 10:33         ` Prabhakar Lad
2013-03-25 10:33           ` Prabhakar Lad
2013-03-22  7:53 ` [PATCH 2/2] media: davinci: vpbe: venc: move the enabling of vpss clocks to driver Prabhakar lad
2013-03-22  7:53   ` Prabhakar lad
2013-03-25  5:39   ` Sekhar Nori [this message]
2013-03-25  5:39     ` Sekhar Nori
2013-03-25 10:15     ` Prabhakar Lad
2013-03-25 10:15       ` Prabhakar Lad
2013-03-25 11:18       ` Sekhar Nori
2013-03-25 11:18         ` Sekhar Nori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=514FE307.5090201@ti.com \
    --to=nsekhar@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.