From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 08/10] ARM: sunxi: dt: Update interrupt controller compatible string
Date: Mon, 25 Mar 2013 08:59:01 -0500 [thread overview]
Message-ID: <51505825.2060805@gmail.com> (raw)
In-Reply-To: <1364218233-29636-9-git-send-email-maxime.ripard@free-electrons.com>
On 03/25/2013 08:30 AM, Maxime Ripard wrote:
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---
> arch/arm/boot/dts/sun4i-a10.dtsi | 2 +-
> arch/arm/boot/dts/sun5i-a13.dtsi | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi
> index be71782..805d704 100644
> --- a/arch/arm/boot/dts/sun4i-a10.dtsi
> +++ b/arch/arm/boot/dts/sun4i-a10.dtsi
> @@ -121,7 +121,7 @@
> ranges;
>
> intc: interrupt-controller at 01c20400 {
> - compatible = "allwinner,sunxi-ic";
> + compatible = "allwinner,sun4i-ic";
Generally speaking, this is a bad thing to do. This breaks compatibility
between dtb and kernel versions. If that breakage is not yet a concern
for sunxi, then it is okay.
Also, I don't see any documentation updates for any of these changes.
Rob
> reg = <0x01c20400 0x400>;
> interrupt-controller;
> #interrupt-cells = <1>;
> diff --git a/arch/arm/boot/dts/sun5i-a13.dtsi b/arch/arm/boot/dts/sun5i-a13.dtsi
> index 7a81aaf..760222c 100644
> --- a/arch/arm/boot/dts/sun5i-a13.dtsi
> +++ b/arch/arm/boot/dts/sun5i-a13.dtsi
> @@ -122,7 +122,7 @@
> ranges;
>
> intc: interrupt-controller at 01c20400 {
> - compatible = "allwinner,sunxi-ic";
> + compatible = "allwinner,sun4i-ic";
> reg = <0x01c20400 0x400>;
> interrupt-controller;
> #interrupt-cells = <1>;
>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robherring2@gmail.com>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: linux-arm-kernel@lists.infradead.org, shuge@allwinnertech.com,
linux-kernel@vger.kernel.org,
Russell King <linux@arm.linux.org.uk>,
kevin@allwinnertech.com, sunny@allwinnertech.com
Subject: Re: [PATCH 08/10] ARM: sunxi: dt: Update interrupt controller compatible string
Date: Mon, 25 Mar 2013 08:59:01 -0500 [thread overview]
Message-ID: <51505825.2060805@gmail.com> (raw)
In-Reply-To: <1364218233-29636-9-git-send-email-maxime.ripard@free-electrons.com>
On 03/25/2013 08:30 AM, Maxime Ripard wrote:
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---
> arch/arm/boot/dts/sun4i-a10.dtsi | 2 +-
> arch/arm/boot/dts/sun5i-a13.dtsi | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi
> index be71782..805d704 100644
> --- a/arch/arm/boot/dts/sun4i-a10.dtsi
> +++ b/arch/arm/boot/dts/sun4i-a10.dtsi
> @@ -121,7 +121,7 @@
> ranges;
>
> intc: interrupt-controller@01c20400 {
> - compatible = "allwinner,sunxi-ic";
> + compatible = "allwinner,sun4i-ic";
Generally speaking, this is a bad thing to do. This breaks compatibility
between dtb and kernel versions. If that breakage is not yet a concern
for sunxi, then it is okay.
Also, I don't see any documentation updates for any of these changes.
Rob
> reg = <0x01c20400 0x400>;
> interrupt-controller;
> #interrupt-cells = <1>;
> diff --git a/arch/arm/boot/dts/sun5i-a13.dtsi b/arch/arm/boot/dts/sun5i-a13.dtsi
> index 7a81aaf..760222c 100644
> --- a/arch/arm/boot/dts/sun5i-a13.dtsi
> +++ b/arch/arm/boot/dts/sun5i-a13.dtsi
> @@ -122,7 +122,7 @@
> ranges;
>
> intc: interrupt-controller@01c20400 {
> - compatible = "allwinner,sunxi-ic";
> + compatible = "allwinner,sun4i-ic";
> reg = <0x01c20400 0x400>;
> interrupt-controller;
> #interrupt-cells = <1>;
>
next prev parent reply other threads:[~2013-03-25 13:59 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-25 13:30 [PATCH 00/10] ARM: sunxi: Architecture cleanups and rework Maxime Ripard
2013-03-25 13:30 ` [PATCH 01/10] ARM: sunxi: dt: Reorganize the dtsi Maxime Ripard
2013-03-25 13:30 ` Maxime Ripard
2013-03-25 13:30 ` [PATCH 02/10] clocksource: sunxi: Cleanup the timer code Maxime Ripard
2013-03-25 13:30 ` Maxime Ripard
2013-03-25 13:30 ` [PATCH 03/10] clocksource: sunxi: make use of CLKSRC_OF Maxime Ripard
2013-03-25 13:30 ` Maxime Ripard
2013-03-25 13:50 ` Rob Herring
2013-03-25 13:50 ` Rob Herring
2013-03-25 16:23 ` Maxime Ripard
2013-03-25 16:23 ` Maxime Ripard
2013-03-25 13:30 ` [PATCH 04/10] clocksource: sunxi: Rename sunxi to sun4i Maxime Ripard
2013-03-25 13:30 ` Maxime Ripard
2013-03-25 13:30 ` [PATCH 05/10] ARM: sunxi: dt: Update timer compatible string Maxime Ripard
2013-03-25 13:30 ` Maxime Ripard
2013-03-25 13:30 ` [PATCH 06/10] irqchip: sunxi: Make use of the IRQCHIP_DECLARE macro Maxime Ripard
2013-03-25 13:30 ` Maxime Ripard
2013-03-25 13:30 ` [PATCH 07/10] irqchip: sunxi: Rename sunxi to sun4i Maxime Ripard
2013-03-25 13:30 ` Maxime Ripard
2013-03-25 14:00 ` Rob Herring
2013-03-25 14:00 ` Rob Herring
2013-03-25 13:30 ` [PATCH 08/10] ARM: sunxi: dt: Update interrupt controller compatible string Maxime Ripard
2013-03-25 13:30 ` Maxime Ripard
2013-03-25 13:59 ` Rob Herring [this message]
2013-03-25 13:59 ` Rob Herring
2013-03-25 16:27 ` Maxime Ripard
2013-03-25 16:27 ` Maxime Ripard
2013-03-25 13:30 ` [PATCH 09/10] ARM: sunxi: Rework the restart code Maxime Ripard
2013-03-25 13:30 ` Maxime Ripard
2013-03-25 13:30 ` [PATCH 10/10] ARM: sunxi: dt: Update watchdog compatible string Maxime Ripard
2013-03-25 13:30 ` Maxime Ripard
-- strict thread matches above, loose matches on Subject: below --
2013-03-26 9:13 [PATCHv2 00/10] ARM: sunxi: Architecture cleanups and rework Maxime Ripard
2013-03-26 9:13 ` [PATCH 08/10] ARM: sunxi: dt: Update interrupt controller compatible string Maxime Ripard
2013-03-26 9:13 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51505825.2060805@gmail.com \
--to=robherring2@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.