From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
zhiguo.hong@emc.com, honkiko@gmail.com,
stephen@networkplumber.org, herbert@gondor.hengli.com.au
Subject: Re: [Bridge] [PATCH net-next] bridge: avoid br_ifinfo_notify when nothing changed
Date: Mon, 25 Mar 2013 20:31:40 +0400 [thread overview]
Message-ID: <51507BEC.9000300@cogentembedded.com> (raw)
In-Reply-To: <20130325.120808.1143527366649356424.davem@davemloft.net>
Hello.
On 25-03-2013 20:08, David Miller wrote:
>> Sorry, I don't usuallly ACK patches in an area I'm not closely
>> familiar with. Though I can add:
> If you feel confident enough to ask for corrections, you better be
> ready to ACK the result when your requests have been met.
Come on, I only asked to correct an evident cut and paste typo in the
description. That's too little a correction to ACK the whole patch. To ACK it,
I should know well the code it's patching and be confident that the whole
patch is correct. I have neither knowledge.
> You can't hold other people accountable yet take none of the
> same responsibility yourself.
I don't hold anyone accountable, I just provide my comments which might as
well be ignored by the submitter/maintainer.
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: David Miller <davem@davemloft.net>
Cc: honkiko@gmail.com, netdev@vger.kernel.org,
bridge@lists.linux-foundation.org, stephen@networkplumber.org,
herbert@gondor.hengli.com.au, zhiguo.hong@emc.com
Subject: Re: [PATCH net-next] bridge: avoid br_ifinfo_notify when nothing changed
Date: Mon, 25 Mar 2013 20:31:40 +0400 [thread overview]
Message-ID: <51507BEC.9000300@cogentembedded.com> (raw)
In-Reply-To: <20130325.120808.1143527366649356424.davem@davemloft.net>
Hello.
On 25-03-2013 20:08, David Miller wrote:
>> Sorry, I don't usuallly ACK patches in an area I'm not closely
>> familiar with. Though I can add:
> If you feel confident enough to ask for corrections, you better be
> ready to ACK the result when your requests have been met.
Come on, I only asked to correct an evident cut and paste typo in the
description. That's too little a correction to ACK the whole patch. To ACK it,
I should know well the code it's patching and be confident that the whole
patch is correct. I have neither knowledge.
> You can't hold other people accountable yet take none of the
> same responsibility yourself.
I don't hold anyone accountable, I just provide my comments which might as
well be ignored by the submitter/maintainer.
WBR, Sergei
next prev parent reply other threads:[~2013-03-25 16:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-23 5:14 [Bridge] [PATCH net-next] bridge: avoid br_ifinfo_notify when nothing changed Hong Zhiguo
2013-03-23 5:14 ` Hong Zhiguo
2013-03-23 15:06 ` [Bridge] " Sergei Shtylyov
2013-03-23 15:06 ` Sergei Shtylyov
2013-03-24 13:26 ` [Bridge] " Hong Zhiguo
2013-03-24 13:26 ` Hong Zhiguo
2013-03-24 14:34 ` [Bridge] " Sergei Shtylyov
2013-03-24 14:34 ` Sergei Shtylyov
2013-03-24 21:15 ` [Bridge] " David Miller
2013-03-24 21:15 ` David Miller
2013-03-25 15:32 ` [Bridge] " Sergei Shtylyov
2013-03-25 15:32 ` Sergei Shtylyov
2013-03-25 16:08 ` [Bridge] " David Miller
2013-03-25 16:08 ` David Miller
2013-03-25 16:31 ` Sergei Shtylyov [this message]
2013-03-25 16:31 ` Sergei Shtylyov
2013-03-24 21:18 ` [Bridge] " David Miller
2013-03-24 21:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51507BEC.9000300@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.hengli.com.au \
--cc=honkiko@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=zhiguo.hong@emc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.