All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: Peter De Schrijver <pdeschrijver@nvidia.com>
Cc: linux-arm-kernel@lists.infradead.org,
	Grant Likely <grant.likely@secretlab.ca>,
	Rob Herring <rob.herring@calxeda.com>,
	Rob Landley <rob@landley.net>,
	Russell King <linux@arm.linux.org.uk>,
	Prashant Gaikwad <pgaikwad@nvidia.com>,
	Simon Glass <sjg@chromium.org>, Rhyland Klein <rklein@nvidia.com>,
	Pritesh Raithatha <praithatha@nvidia.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Hiroshi Doyu <hdoyu@nvidia.com>,
	Laxman Dewangan <ldewangan@nvidia.com>,
	Andrew Chew <achew@nvidia.com>,
	Mike Turquette <mturquette@linaro.org>,
	Thierry Reding <thierry.reding@avionic-design.de>,
	devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org,
	linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 00/14] Tegra114 clockframework
Date: Mon, 25 Mar 2013 16:44:15 -0600	[thread overview]
Message-ID: <5150D33F.1000206@wwwdotorg.org> (raw)
In-Reply-To: <514CAB71.7020005@wwwdotorg.org>

On 03/22/2013 01:05 PM, Stephen Warren wrote:
> On 03/22/2013 06:39 AM, Peter De Schrijver wrote:
>> This is the eight version of the Tegra114 clockframework. It is based on the
>> next-20130320-fixed branch of
>> git://nv-tegra.nvidia.com/user/swarren/linux-2.6.git,
> 
> Hmmm. Basing this on v3.9-rcX would be better, since when I apply it to
> the Tegra tree, that's what it will be based on. Luckily, it applies
> there with trivial conflicts.
> 
>> http://patchwork.ozlabs.org/patch/229972/ and
>> http://patchwork.ozlabs.org/patch/229978/
> 
> The series,
> 
> Tested-by: Stephen Warren <swarren@nvidia.com>
> 
> (based on my personal next-20130318-fixed branch, without
> http://patchwork.ozlabs.org/patch/229972/ applied, but instead with the
> audio clocks initialized per the patch I posted yesterday to do this).
> 
> I tested: serial console, eMMC for the root filesystem, audio playback
> using different pll_a rates, reboot, and shutdown.
> 
> This version also solves the hard hang I was seeing with V7 during
> shutdown or reboot. Now I don't have to rely on my filesystem journal:-)

Hmm. I retract that Tested-by now.

If I apply the series on top of Tegra's for-next branch (which is
currently entirely based on v3.9-rc1) then it works fine. (Similarly, it
works fine on top of next-20130318, as I reported above).

If I merge in v3.9-rc3, it's still fine. If I merge in v3.9-rc4, I see a
hard hang during boot. I believe that "hard hang" here means that some
module's registers are being touched with the clock turned off, which
locks up the CPU/bus. Certainly, sysrq doesn't work once it's hung.

I tracked this down to some interaction with commit f7db706 "ARM:
7674/1: smp: Avoid dummy clockevent being preferred over real hardware
clock-event". So says a "git bisect" between v3.9-rc3 and v3.9-rc4,
applying this CCF V8 series at each point.

If I revert that commit, the problem is solved/hidden. I tested this in
my local dev branch that's based on next-20130325 plus this CCF V8
series, plus a bunch of other cruft.

Can you please investigate what the problem is? Thanks.

WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v8 00/14] Tegra114 clockframework
Date: Mon, 25 Mar 2013 16:44:15 -0600	[thread overview]
Message-ID: <5150D33F.1000206@wwwdotorg.org> (raw)
In-Reply-To: <514CAB71.7020005@wwwdotorg.org>

On 03/22/2013 01:05 PM, Stephen Warren wrote:
> On 03/22/2013 06:39 AM, Peter De Schrijver wrote:
>> This is the eight version of the Tegra114 clockframework. It is based on the
>> next-20130320-fixed branch of
>> git://nv-tegra.nvidia.com/user/swarren/linux-2.6.git,
> 
> Hmmm. Basing this on v3.9-rcX would be better, since when I apply it to
> the Tegra tree, that's what it will be based on. Luckily, it applies
> there with trivial conflicts.
> 
>> http://patchwork.ozlabs.org/patch/229972/ and
>> http://patchwork.ozlabs.org/patch/229978/
> 
> The series,
> 
> Tested-by: Stephen Warren <swarren@nvidia.com>
> 
> (based on my personal next-20130318-fixed branch, without
> http://patchwork.ozlabs.org/patch/229972/ applied, but instead with the
> audio clocks initialized per the patch I posted yesterday to do this).
> 
> I tested: serial console, eMMC for the root filesystem, audio playback
> using different pll_a rates, reboot, and shutdown.
> 
> This version also solves the hard hang I was seeing with V7 during
> shutdown or reboot. Now I don't have to rely on my filesystem journal:-)

Hmm. I retract that Tested-by now.

If I apply the series on top of Tegra's for-next branch (which is
currently entirely based on v3.9-rc1) then it works fine. (Similarly, it
works fine on top of next-20130318, as I reported above).

If I merge in v3.9-rc3, it's still fine. If I merge in v3.9-rc4, I see a
hard hang during boot. I believe that "hard hang" here means that some
module's registers are being touched with the clock turned off, which
locks up the CPU/bus. Certainly, sysrq doesn't work once it's hung.

I tracked this down to some interaction with commit f7db706 "ARM:
7674/1: smp: Avoid dummy clockevent being preferred over real hardware
clock-event". So says a "git bisect" between v3.9-rc3 and v3.9-rc4,
applying this CCF V8 series at each point.

If I revert that commit, the problem is solved/hidden. I tested this in
my local dev branch that's based on next-20130325 plus this CCF V8
series, plus a bunch of other cruft.

Can you please investigate what the problem is? Thanks.

  reply	other threads:[~2013-03-25 22:44 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-22 12:39 [PATCH v8 00/14] Tegra114 clockframework Peter De Schrijver
2013-03-22 12:39 ` Peter De Schrijver
2013-03-22 12:39 ` Peter De Schrijver
2013-03-22 12:39 ` [PATCH v8 02/14] clk: tegra: Refactor PLL programming code Peter De Schrijver
2013-03-22 12:39   ` Peter De Schrijver
2013-03-22 12:39   ` Peter De Schrijver
2013-03-22 12:39 ` [PATCH v8 03/14] clk: tegra: Add TEGRA_PLL_BYPASS flag Peter De Schrijver
2013-03-22 12:39   ` Peter De Schrijver
2013-03-22 12:39   ` Peter De Schrijver
2013-03-22 12:39 ` [PATCH v8 05/14] clk: tegra: Add PLL post divider table Peter De Schrijver
2013-03-22 12:39   ` Peter De Schrijver
2013-03-22 12:39   ` Peter De Schrijver
2013-03-22 12:39 ` [PATCH v8 06/14] clk: tegra: move from a lock bit idx to a lock mask Peter De Schrijver
2013-03-22 12:39   ` Peter De Schrijver
2013-03-22 12:39   ` Peter De Schrijver
     [not found] ` <1363956029-31873-1-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-22 12:39   ` [PATCH v8 01/14] clk: tegra: provide dummy cpu car ops Peter De Schrijver
2013-03-22 12:39     ` Peter De Schrijver
2013-03-22 12:39     ` Peter De Schrijver
2013-03-22 12:39   ` [PATCH v8 04/14] clk: tegra: introduce TEGRA_PLL_HAS_LOCK_ENABLE Peter De Schrijver
2013-03-22 12:39     ` Peter De Schrijver
2013-03-22 12:39     ` Peter De Schrijver
2013-03-22 12:39   ` [PATCH v8 07/14] clk: tegra: Add new fields and PLL types for Tegra114 Peter De Schrijver
2013-03-22 12:39     ` Peter De Schrijver
2013-03-22 12:39     ` Peter De Schrijver
2013-03-22 12:39   ` [PATCH v8 08/14] clk: tegra: Add flags to tegra_clk_periph() Peter De Schrijver
2013-03-22 12:39     ` Peter De Schrijver
2013-03-22 12:39     ` Peter De Schrijver
2013-03-22 12:39   ` [PATCH v8 09/14] clk: tegra: Workaround for Tegra114 MSENC problem Peter De Schrijver
2013-03-22 12:39     ` Peter De Schrijver
2013-03-22 12:39     ` Peter De Schrijver
2013-03-22 12:39   ` [PATCH v8 12/14] clk: tegra: devicetree match for nvidia,tegra114-car Peter De Schrijver
2013-03-22 12:39     ` Peter De Schrijver
2013-03-22 12:39     ` [PATCH v8 12/14] clk: tegra: devicetree match for nvidia, tegra114-car Peter De Schrijver
2013-03-22 12:39   ` [PATCH v8 13/14] ARM: dt: Add references to tegra_car clocks Peter De Schrijver
2013-03-22 12:39     ` Peter De Schrijver
2013-03-22 12:39     ` Peter De Schrijver
2013-03-22 12:39   ` [PATCH v8 14/14] clk: tegra: Remove forced clk_enable of uartd Peter De Schrijver
2013-03-22 12:39     ` Peter De Schrijver
2013-03-22 12:39     ` Peter De Schrijver
2013-03-22 19:05   ` [PATCH v8 00/14] Tegra114 clockframework Stephen Warren
2013-03-22 19:05     ` Stephen Warren
2013-03-22 19:05     ` Stephen Warren
2013-03-25 22:44     ` Stephen Warren [this message]
2013-03-25 22:44       ` Stephen Warren
2013-03-22 12:39 ` [PATCH v8 10/14] ARM: tegra: Define Tegra114 CAR binding Peter De Schrijver
2013-03-22 12:39   ` Peter De Schrijver
2013-03-22 12:39   ` Peter De Schrijver
2013-03-25 11:15   ` Prashant Gaikwad
2013-03-25 11:15     ` Prashant Gaikwad
     [not found]     ` <515031E3.40007-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-04-03 14:19       ` Peter De Schrijver
2013-04-03 14:19         ` Peter De Schrijver
2013-04-03 14:19         ` Peter De Schrijver
2013-04-04  7:14         ` Prashant Gaikwad
2013-04-04  7:14           ` Prashant Gaikwad
2013-03-22 12:39 ` [PATCH v8 11/14] clk: tegra: Implement clocks for Tegra114 Peter De Schrijver
2013-03-22 12:39   ` Peter De Schrijver
2013-03-22 12:39   ` Peter De Schrijver
2013-03-22 12:55 ` [PATCH v8 00/14] Tegra114 clockframework Peter De Schrijver
2013-03-22 12:55   ` Peter De Schrijver
2013-03-22 12:55   ` Peter De Schrijver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5150D33F.1000206@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=achew@nvidia.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=hdoyu@nvidia.com \
    --cc=ldewangan@nvidia.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mturquette@linaro.org \
    --cc=pdeschrijver@nvidia.com \
    --cc=pgaikwad@nvidia.com \
    --cc=praithatha@nvidia.com \
    --cc=rklein@nvidia.com \
    --cc=rob.herring@calxeda.com \
    --cc=rob@landley.net \
    --cc=sjg@chromium.org \
    --cc=thierry.reding@avionic-design.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.