* [PATCH] ARM:s3c24xx: beautify code, data->hwirq is unsigned long which is always >= 0
@ 2013-03-26 6:54 ` Chen Gang
0 siblings, 0 replies; 2+ messages in thread
From: Chen Gang @ 2013-03-26 6:54 UTC (permalink / raw)
To: ben-linux, kgene.kim@samsung.com
Cc: Russell King - ARM Linux, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org >> "linux-samsung-soc@vger.kernel.org"
data->hwirq is unsigned long which is always >= 0
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
arch/arm/mach-s3c24xx/irq.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-s3c24xx/irq.c b/arch/arm/mach-s3c24xx/irq.c
index 5c9f8b7..143f57b 100644
--- a/arch/arm/mach-s3c24xx/irq.c
+++ b/arch/arm/mach-s3c24xx/irq.c
@@ -210,7 +210,7 @@ static int s3c_irqext0_type(struct irq_data *data, unsigned int type)
void __iomem *gpcon_reg;
unsigned long gpcon_offset, extint_offset;
- if ((data->hwirq >= 0) && (data->hwirq <= 3)) {
+ if (data->hwirq <= 3) {
gpcon_reg = S3C2410_GPFCON;
extint_reg = S3C24XX_EXTINT0;
gpcon_offset = (data->hwirq) * 2;
--
1.7.7.6
^ permalink raw reply related [flat|nested] 2+ messages in thread* [PATCH] ARM:s3c24xx: beautify code, data->hwirq is unsigned long which is always >= 0
@ 2013-03-26 6:54 ` Chen Gang
0 siblings, 0 replies; 2+ messages in thread
From: Chen Gang @ 2013-03-26 6:54 UTC (permalink / raw)
To: linux-arm-kernel
data->hwirq is unsigned long which is always >= 0
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
arch/arm/mach-s3c24xx/irq.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-s3c24xx/irq.c b/arch/arm/mach-s3c24xx/irq.c
index 5c9f8b7..143f57b 100644
--- a/arch/arm/mach-s3c24xx/irq.c
+++ b/arch/arm/mach-s3c24xx/irq.c
@@ -210,7 +210,7 @@ static int s3c_irqext0_type(struct irq_data *data, unsigned int type)
void __iomem *gpcon_reg;
unsigned long gpcon_offset, extint_offset;
- if ((data->hwirq >= 0) && (data->hwirq <= 3)) {
+ if (data->hwirq <= 3) {
gpcon_reg = S3C2410_GPFCON;
extint_reg = S3C24XX_EXTINT0;
gpcon_offset = (data->hwirq) * 2;
--
1.7.7.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-26 6:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-26 6:54 [PATCH] ARM:s3c24xx: beautify code, data->hwirq is unsigned long which is always >= 0 Chen Gang
2013-03-26 6:54 ` Chen Gang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.