From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: Conditionals in dtsi files
Date: Fri, 13 Nov 2015 10:43:11 +0100 [thread overview]
Message-ID: <5151887.Q3EmlRO4WY@wuerfel> (raw)
In-Reply-To: <5645AE7E.4090003@free.fr>
On Friday 13 November 2015 10:33:50 Mason wrote:
> Hello,
>
> I'm wondering how much C preprocessor syntax one can use in DT files.
>
> Suppose I have 2 board DTS (both including common.dtsi)
>
> board_A.dts (1-core), board_B.dts (2-core)
>
> Can I have in common.dtsi something along these lines:
>
> cpus {
> enable-method = "foo,bar";
> #address-cells = <1>;
> #size-cells = <0>;
>
> cpu0: cpu at 0 {
> compatible = "arm,cortex-a9";
> device_type = "cpu";
> reg = <0>;
> };
>
> #if CORE_COUNT > 1
> cpu1: cpu at 1 {
> compatible = "arm,cortex-a9";
> device_type = "cpu";
> reg = <1>;
> };
> #endif
> };
>
>
> board_A.dts would have
> #define CORE_COUNT 1
> #include "common.dtsi"
>
> board_B.dts would have
> #define CORE_COUNT 2
> #include "common.dtsi"
I would prefer not using any preprocessor statements other than
#include in .dts files. It's easy enough to have a per-soc
.dtsi file that defines the CPU nodes and goes on to include another
.dtsi file with the common parts that are present on all SoCs.
Have a look at how the armada-*.dtsi files handle this.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Mason <slash.tmp@free.fr>
Cc: Grant Likely <grant.likely@linaro.org>,
DT <devicetree@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: Conditionals in dtsi files
Date: Fri, 13 Nov 2015 10:43:11 +0100 [thread overview]
Message-ID: <5151887.Q3EmlRO4WY@wuerfel> (raw)
In-Reply-To: <5645AE7E.4090003@free.fr>
On Friday 13 November 2015 10:33:50 Mason wrote:
> Hello,
>
> I'm wondering how much C preprocessor syntax one can use in DT files.
>
> Suppose I have 2 board DTS (both including common.dtsi)
>
> board_A.dts (1-core), board_B.dts (2-core)
>
> Can I have in common.dtsi something along these lines:
>
> cpus {
> enable-method = "foo,bar";
> #address-cells = <1>;
> #size-cells = <0>;
>
> cpu0: cpu@0 {
> compatible = "arm,cortex-a9";
> device_type = "cpu";
> reg = <0>;
> };
>
> #if CORE_COUNT > 1
> cpu1: cpu@1 {
> compatible = "arm,cortex-a9";
> device_type = "cpu";
> reg = <1>;
> };
> #endif
> };
>
>
> board_A.dts would have
> #define CORE_COUNT 1
> #include "common.dtsi"
>
> board_B.dts would have
> #define CORE_COUNT 2
> #include "common.dtsi"
I would prefer not using any preprocessor statements other than
#include in .dts files. It's easy enough to have a per-soc
.dtsi file that defines the CPU nodes and goes on to include another
.dtsi file with the common parts that are present on all SoCs.
Have a look at how the armada-*.dtsi files handle this.
Arnd
next prev parent reply other threads:[~2015-11-13 9:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-13 9:33 Conditionals in dtsi files Mason
2015-11-13 9:33 ` Mason
2015-11-13 9:43 ` Arnd Bergmann [this message]
2015-11-13 9:43 ` Arnd Bergmann
2015-11-13 11:15 ` Mark Rutland
2015-11-13 11:15 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5151887.Q3EmlRO4WY@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.