From: Eric Blake <eblake@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
david.pravec@nethost.cz, Juan Quintela <quintela@redhat.com>,
mprivozn@redhat.com, Corey Bryant <coreyb@linux.vnet.ibm.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/4] net: ensure "socket" backend uses non-blocking fds
Date: Tue, 26 Mar 2013 10:33:45 -0600 [thread overview]
Message-ID: <5151CDE9.2030101@redhat.com> (raw)
In-Reply-To: <1364314072-2474-2-git-send-email-stefanha@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 816 bytes --]
On 03/26/2013 10:07 AM, Stefan Hajnoczi wrote:
> There are several code paths in net_init_socket() depending on how the
> socket is created: file descriptor passing, UDP multicast, TCP, or UDP.
> Some of these support both listen and connect.
>
> Not all code paths set the socket to non-blocking. This patch addresses
> the file descriptor passing and UDP cases which were missing
> socket_set_nonblock(fd) calls.
>
> I considered moving socket_set_nonblock(fd) to a central location but it
> turns out the code paths are different enough to require non-blocking at
> different places.
Is it worth rearranging patch 3 first, so that you don't have to churn
on these newly-added lines?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-03-26 16:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-26 16:07 [Qemu-devel] [PATCH 0/4] monitor: do not rely on O_NONBLOCK for passed file descriptors Stefan Hajnoczi
2013-03-26 16:07 ` [Qemu-devel] [PATCH 1/4] net: ensure "socket" backend uses non-blocking fds Stefan Hajnoczi
2013-03-26 16:25 ` Juan Quintela
2013-03-27 6:36 ` Stefan Hajnoczi
2013-03-26 16:33 ` Eric Blake [this message]
2013-03-27 6:37 ` Stefan Hajnoczi
2013-03-26 16:07 ` [Qemu-devel] [PATCH 2/4] qemu-socket: set passed fd non-blocking in socket_connect() Stefan Hajnoczi
2013-03-26 16:33 ` Juan Quintela
2013-03-26 16:34 ` Eric Blake
2013-03-26 16:07 ` [Qemu-devel] [PATCH 3/4] oslib-posix: rename socket_set_nonblock() to qemu_set_nonblock() Stefan Hajnoczi
2013-03-26 16:34 ` Juan Quintela
2013-03-26 16:39 ` Eric Blake
2013-03-26 16:07 ` [Qemu-devel] [PATCH 4/4] chardev: clear O_NONBLOCK on SCM_RIGHTS file descriptors Stefan Hajnoczi
2013-03-26 16:38 ` Juan Quintela
2013-03-26 16:40 ` Eric Blake
2013-03-27 8:37 ` [Qemu-devel] [PATCH 0/4] monitor: do not rely on O_NONBLOCK for passed " liu ping fan
2013-03-27 8:51 ` Stefan Hajnoczi
2013-03-27 13:06 ` Juan Quintela
2013-03-27 13:39 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5151CDE9.2030101@redhat.com \
--to=eblake@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=coreyb@linux.vnet.ibm.com \
--cc=david.pravec@nethost.cz \
--cc=mprivozn@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.