From: Juan Quintela <quintela@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
david.pravec@nethost.cz, mprivozn@redhat.com,
Corey Bryant <coreyb@linux.vnet.ibm.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 4/4] chardev: clear O_NONBLOCK on SCM_RIGHTS file descriptors
Date: Tue, 26 Mar 2013 17:38:55 +0100 [thread overview]
Message-ID: <87a9pqkteo.fsf@elfo.elfo> (raw)
In-Reply-To: <1364314072-2474-5-git-send-email-stefanha@redhat.com> (Stefan Hajnoczi's message of "Tue, 26 Mar 2013 17:07:52 +0100")
Stefan Hajnoczi <stefanha@redhat.com> wrote:
> When we receive a file descriptor over a UNIX domain socket the
> O_NONBLOCK flag is preserved. Clear the O_NONBLOCK flag and rely on
> QEMU file descriptor users like migration, SPICE, VNC, block layer, and
> others to set non-blocking only when necessary.
>
> This change ensures we don't accidentally expose O_NONBLOCK in the QMP
> API. QMP clients should not need to get the non-blocking state
> "correct".
>
> A recent real-world example was when libvirt passed a non-blocking TCP
> socket for migration where we expected a blocking socket. The source
> QEMU produced a corrupted migration stream since its code did not cope
> with non-blocking sockets.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Acked-by: Juan Quintela <quintela@redhat.com>
next prev parent reply other threads:[~2013-03-26 16:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-26 16:07 [Qemu-devel] [PATCH 0/4] monitor: do not rely on O_NONBLOCK for passed file descriptors Stefan Hajnoczi
2013-03-26 16:07 ` [Qemu-devel] [PATCH 1/4] net: ensure "socket" backend uses non-blocking fds Stefan Hajnoczi
2013-03-26 16:25 ` Juan Quintela
2013-03-27 6:36 ` Stefan Hajnoczi
2013-03-26 16:33 ` Eric Blake
2013-03-27 6:37 ` Stefan Hajnoczi
2013-03-26 16:07 ` [Qemu-devel] [PATCH 2/4] qemu-socket: set passed fd non-blocking in socket_connect() Stefan Hajnoczi
2013-03-26 16:33 ` Juan Quintela
2013-03-26 16:34 ` Eric Blake
2013-03-26 16:07 ` [Qemu-devel] [PATCH 3/4] oslib-posix: rename socket_set_nonblock() to qemu_set_nonblock() Stefan Hajnoczi
2013-03-26 16:34 ` Juan Quintela
2013-03-26 16:39 ` Eric Blake
2013-03-26 16:07 ` [Qemu-devel] [PATCH 4/4] chardev: clear O_NONBLOCK on SCM_RIGHTS file descriptors Stefan Hajnoczi
2013-03-26 16:38 ` Juan Quintela [this message]
2013-03-26 16:40 ` Eric Blake
2013-03-27 8:37 ` [Qemu-devel] [PATCH 0/4] monitor: do not rely on O_NONBLOCK for passed " liu ping fan
2013-03-27 8:51 ` Stefan Hajnoczi
2013-03-27 13:06 ` Juan Quintela
2013-03-27 13:39 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a9pqkteo.fsf@elfo.elfo \
--to=quintela@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=coreyb@linux.vnet.ibm.com \
--cc=david.pravec@nethost.cz \
--cc=mprivozn@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.