* [PATCH 1/2] ARM: tegra: use setup_mm_for_reboot rather than explicit pgd switch
@ 2013-03-25 18:19 ` Will Deacon
0 siblings, 0 replies; 8+ messages in thread
From: Will Deacon @ 2013-03-25 18:19 UTC (permalink / raw)
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA, Will Deacon, Stephen Warren
This patch changes the Tegra PM code to use the setup_mm_for_reboot
helper rather than call cpu_switch_mm directly. This keeps things like
TLB invalidation in one place.
Cc: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Signed-off-by: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
---
arch/arm/mach-tegra/pm.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/arch/arm/mach-tegra/pm.c b/arch/arm/mach-tegra/pm.c
index 523604d..a77ed48 100644
--- a/arch/arm/mach-tegra/pm.c
+++ b/arch/arm/mach-tegra/pm.c
@@ -183,12 +183,7 @@ bool tegra_set_cpu_in_lp2(int phy_cpu_id)
static int tegra_sleep_cpu(unsigned long v2p)
{
- /* Switch to the identity mapping. */
- cpu_switch_mm(idmap_pgd, &init_mm);
-
- /* Flush the TLB. */
- local_flush_tlb_all();
-
+ setup_mm_for_reboot();
tegra_sleep_cpu_finish(v2p);
/* should never here */
--
1.8.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 1/2] ARM: tegra: use setup_mm_for_reboot rather than explicit pgd switch
@ 2013-03-25 18:19 ` Will Deacon
0 siblings, 0 replies; 8+ messages in thread
From: Will Deacon @ 2013-03-25 18:19 UTC (permalink / raw)
To: linux-arm-kernel
This patch changes the Tegra PM code to use the setup_mm_for_reboot
helper rather than call cpu_switch_mm directly. This keeps things like
TLB invalidation in one place.
Cc: Stephen Warren <swarren@wwwdotorg.org>
Signed-off-by: Will Deacon <will.deacon@arm.com>
---
arch/arm/mach-tegra/pm.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/arch/arm/mach-tegra/pm.c b/arch/arm/mach-tegra/pm.c
index 523604d..a77ed48 100644
--- a/arch/arm/mach-tegra/pm.c
+++ b/arch/arm/mach-tegra/pm.c
@@ -183,12 +183,7 @@ bool tegra_set_cpu_in_lp2(int phy_cpu_id)
static int tegra_sleep_cpu(unsigned long v2p)
{
- /* Switch to the identity mapping. */
- cpu_switch_mm(idmap_pgd, &init_mm);
-
- /* Flush the TLB. */
- local_flush_tlb_all();
-
+ setup_mm_for_reboot();
tegra_sleep_cpu_finish(v2p);
/* should never here */
--
1.8.0
^ permalink raw reply related [flat|nested] 8+ messages in thread[parent not found: <1364235552-17851-1-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org>]
* [PATCH 2/2] ARM: tegra: use CS_LAR_KEY definition instead of 0xC5ACCE55
2013-03-25 18:19 ` Will Deacon
@ 2013-03-25 18:19 ` Will Deacon
-1 siblings, 0 replies; 8+ messages in thread
From: Will Deacon @ 2013-03-25 18:19 UTC (permalink / raw)
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA, Will Deacon, Stephen Warren,
Dietmar Eggemann
When enabling coresight on secondary cores for tegra, make use of our
fancy new definition for the magic lock code.
Cc: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Signed-off-by: Dietmar Eggemann <dietmar.eggemann-5wv7dgnIgG8@public.gmane.org>
Signed-off-by: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
---
arch/arm/mach-tegra/headsmp.S | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-tegra/headsmp.S b/arch/arm/mach-tegra/headsmp.S
index fd473f2..d2747fe 100644
--- a/arch/arm/mach-tegra/headsmp.S
+++ b/arch/arm/mach-tegra/headsmp.S
@@ -1,6 +1,7 @@
#include <linux/linkage.h>
#include <linux/init.h>
+#include <asm/hardware/coresight.h>
#include "sleep.h"
.section ".text.head", "ax"
@@ -8,7 +9,7 @@
ENTRY(tegra_secondary_startup)
bl v7_invalidate_l1
/* Enable coresight */
- mov32 r0, 0xC5ACCE55
+ mov32 r0, CS_LAR_KEY
mcr p14, 0, r0, c7, c12, 6
b secondary_startup
ENDPROC(tegra_secondary_startup)
--
1.8.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 2/2] ARM: tegra: use CS_LAR_KEY definition instead of 0xC5ACCE55
@ 2013-03-25 18:19 ` Will Deacon
0 siblings, 0 replies; 8+ messages in thread
From: Will Deacon @ 2013-03-25 18:19 UTC (permalink / raw)
To: linux-arm-kernel
When enabling coresight on secondary cores for tegra, make use of our
fancy new definition for the magic lock code.
Cc: Stephen Warren <swarren@wwwdotorg.org>
Signed-off-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
---
arch/arm/mach-tegra/headsmp.S | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-tegra/headsmp.S b/arch/arm/mach-tegra/headsmp.S
index fd473f2..d2747fe 100644
--- a/arch/arm/mach-tegra/headsmp.S
+++ b/arch/arm/mach-tegra/headsmp.S
@@ -1,6 +1,7 @@
#include <linux/linkage.h>
#include <linux/init.h>
+#include <asm/hardware/coresight.h>
#include "sleep.h"
.section ".text.head", "ax"
@@ -8,7 +9,7 @@
ENTRY(tegra_secondary_startup)
bl v7_invalidate_l1
/* Enable coresight */
- mov32 r0, 0xC5ACCE55
+ mov32 r0, CS_LAR_KEY
mcr p14, 0, r0, c7, c12, 6
b secondary_startup
ENDPROC(tegra_secondary_startup)
--
1.8.0
^ permalink raw reply related [flat|nested] 8+ messages in thread[parent not found: <1364235552-17851-2-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org>]
* Re: [PATCH 2/2] ARM: tegra: use CS_LAR_KEY definition instead of 0xC5ACCE55
2013-03-25 18:19 ` Will Deacon
@ 2013-03-26 20:34 ` Stephen Warren
-1 siblings, 0 replies; 8+ messages in thread
From: Stephen Warren @ 2013-03-26 20:34 UTC (permalink / raw)
To: Will Deacon
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-tegra-u79uwXL29TY76Z2rM5mHXA, Dietmar Eggemann
On 03/25/2013 12:19 PM, Will Deacon wrote:
> When enabling coresight on secondary cores for tegra, make use of our
> fancy new definition for the magic lock code.
The code you're editing has actually been removed in the 3.10 cycle, so
there's no need for this patch any more.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] ARM: tegra: use setup_mm_for_reboot rather than explicit pgd switch
2013-03-25 18:19 ` Will Deacon
@ 2013-03-26 20:38 ` Stephen Warren
-1 siblings, 0 replies; 8+ messages in thread
From: Stephen Warren @ 2013-03-26 20:38 UTC (permalink / raw)
To: Will Deacon
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-tegra-u79uwXL29TY76Z2rM5mHXA
On 03/25/2013 12:19 PM, Will Deacon wrote:
> This patch changes the Tegra PM code to use the setup_mm_for_reboot
> helper rather than call cpu_switch_mm directly. This keeps things like
> TLB invalidation in one place.
I've applied this to Tegra's for-3.10/cleanup branch.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-03-26 20:38 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-25 18:19 [PATCH 1/2] ARM: tegra: use setup_mm_for_reboot rather than explicit pgd switch Will Deacon
2013-03-25 18:19 ` Will Deacon
[not found] ` <1364235552-17851-1-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org>
2013-03-25 18:19 ` [PATCH 2/2] ARM: tegra: use CS_LAR_KEY definition instead of 0xC5ACCE55 Will Deacon
2013-03-25 18:19 ` Will Deacon
[not found] ` <1364235552-17851-2-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org>
2013-03-26 20:34 ` Stephen Warren
2013-03-26 20:34 ` Stephen Warren
2013-03-26 20:38 ` [PATCH 1/2] ARM: tegra: use setup_mm_for_reboot rather than explicit pgd switch Stephen Warren
2013-03-26 20:38 ` Stephen Warren
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.