From: Eduardo Valentin <eduardo.valentin@ti.com>
To: Zhang Rui <rui.zhang@intel.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
amit.daniel@samsung.com, durgadoss.r@intel.com, andi@lisas.de
Subject: Re: [RFC, 2/5] Thermal: thermal framework registration failure case cleanup
Date: Tue, 26 Mar 2013 18:22:32 -0400 [thread overview]
Message-ID: <51521FA8.6030806@ti.com> (raw)
In-Reply-To: <1364315169-15427-3-git-send-email-rui.zhang@intel.com>
On 26-03-2013 12:26, Zhang Rui wrote:
> Signed-off-by: Zhang Rui <rui.zhang@intel.com>
>
Could you please describe why these resource releases are not required
anymore? Even on thermal_exit.
> ---
> drivers/thermal/thermal_core.c | 12 ++----------
> 1 file changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
> index 5b7863a..845ed6e 100644
> --- a/drivers/thermal/thermal_core.c
> +++ b/drivers/thermal/thermal_core.c
> @@ -1863,13 +1863,9 @@ static int __init thermal_init(void)
> int result = 0;
>
> result = class_register(&thermal_class);
> - if (result) {
> - idr_destroy(&thermal_tz_idr);
> - idr_destroy(&thermal_cdev_idr);
> - mutex_destroy(&thermal_idr_lock);
> - mutex_destroy(&thermal_list_lock);
> + if (result)
> return result;
> - }
> +
> result = genetlink_init();
> return result;
> }
> @@ -1877,10 +1873,6 @@ static int __init thermal_init(void)
> static void __exit thermal_exit(void)
> {
> class_unregister(&thermal_class);
> - idr_destroy(&thermal_tz_idr);
> - idr_destroy(&thermal_cdev_idr);
> - mutex_destroy(&thermal_idr_lock);
> - mutex_destroy(&thermal_list_lock);
> genetlink_exit();
> }
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Eduardo Valentin <eduardo.valentin@ti.com>
To: Zhang Rui <rui.zhang@intel.com>
Cc: <linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<amit.daniel@samsung.com>, <durgadoss.r@intel.com>,
<andi@lisas.de>
Subject: Re: [RFC, 2/5] Thermal: thermal framework registration failure case cleanup
Date: Tue, 26 Mar 2013 18:22:32 -0400 [thread overview]
Message-ID: <51521FA8.6030806@ti.com> (raw)
In-Reply-To: <1364315169-15427-3-git-send-email-rui.zhang@intel.com>
On 26-03-2013 12:26, Zhang Rui wrote:
> Signed-off-by: Zhang Rui <rui.zhang@intel.com>
>
Could you please describe why these resource releases are not required
anymore? Even on thermal_exit.
> ---
> drivers/thermal/thermal_core.c | 12 ++----------
> 1 file changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
> index 5b7863a..845ed6e 100644
> --- a/drivers/thermal/thermal_core.c
> +++ b/drivers/thermal/thermal_core.c
> @@ -1863,13 +1863,9 @@ static int __init thermal_init(void)
> int result = 0;
>
> result = class_register(&thermal_class);
> - if (result) {
> - idr_destroy(&thermal_tz_idr);
> - idr_destroy(&thermal_cdev_idr);
> - mutex_destroy(&thermal_idr_lock);
> - mutex_destroy(&thermal_list_lock);
> + if (result)
> return result;
> - }
> +
> result = genetlink_init();
> return result;
> }
> @@ -1877,10 +1873,6 @@ static int __init thermal_init(void)
> static void __exit thermal_exit(void)
> {
> class_unregister(&thermal_class);
> - idr_destroy(&thermal_tz_idr);
> - idr_destroy(&thermal_cdev_idr);
> - mutex_destroy(&thermal_idr_lock);
> - mutex_destroy(&thermal_list_lock);
> genetlink_exit();
> }
>
>
next prev parent reply other threads:[~2013-03-26 22:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-26 16:26 [RFC PATCH 0/5] Thermal: build all thermal framework code into thermal_sys module Zhang Rui
2013-03-26 16:26 ` [RFC PATCH 1/5] Thermal: rename thermal_sys.c to thermal_core.c Zhang Rui
2013-03-26 16:56 ` R, Durgadoss
2013-03-26 17:08 ` Zhang Rui
2013-03-26 22:04 ` [RFC,1/5] " Eduardo Valentin
2013-03-26 22:04 ` Eduardo Valentin
2013-03-28 2:40 ` Zhang Rui
2013-04-01 12:43 ` Eduardo Valentin
2013-04-01 12:43 ` Eduardo Valentin
2013-04-01 13:09 ` R, Durgadoss
2013-04-01 13:09 ` R, Durgadoss
2013-03-26 16:26 ` [RFC PATCH 2/5] Thermal: thermal framework registration failure case cleanup Zhang Rui
2013-03-26 22:22 ` Eduardo Valentin [this message]
2013-03-26 22:22 ` [RFC, " Eduardo Valentin
2013-03-26 16:26 ` [RFC PATCH 3/5] Thermal: build thermal governors into thermal_sys module Zhang Rui
2013-03-26 16:53 ` R, Durgadoss
2013-03-26 17:12 ` Zhang Rui
2013-03-26 22:31 ` [RFC,3/5] " Eduardo Valentin
2013-03-26 22:31 ` Eduardo Valentin
2013-03-26 16:26 ` [RFC PATCH 4/5] Thermal: governor API cleanup Zhang Rui
2013-03-26 22:35 ` [RFC,4/5] " Eduardo Valentin
2013-03-26 22:35 ` Eduardo Valentin
2013-03-26 16:26 ` [RFC PATCH 5/5] Thermal: build cpu_cooling code into thermal_sys module Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51521FA8.6030806@ti.com \
--to=eduardo.valentin@ti.com \
--cc=amit.daniel@samsung.com \
--cc=andi@lisas.de \
--cc=durgadoss.r@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.