[PATCH 0/4] drm/tilcdc: Some fixes

[PATCH 0/4] drm/tilcdc: Some fixes

[Sachin Kamat]

This patch series is only compile tested and based on linux-next
tree of 20130301.

Sachin Kamat (4):
  drm/tilcdc: Fix an incorrect condition
  drm/tilcdc: Remove unnecessary braces
  drm/tilcdc: Remove space before tab
  drm/tilcdc: Fix checkpatch error in tilcdc_panel.c

 drivers/gpu/drm/tilcdc/tilcdc_drv.c   |    9 ++++-----
 drivers/gpu/drm/tilcdc/tilcdc_panel.c |    2 +-
 2 files changed, 5 insertions(+), 6 deletions(-)

-- 
1.7.4.1

[PATCH 1/4] drm/tilcdc: Fix an incorrect condition

[Sachin Kamat]

Instead of checking if num_encoders is zero, it is being assigned 0.
Convert the assignment to a check.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 drivers/gpu/drm/tilcdc/tilcdc_drv.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
index c5b592d..bfac582 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
@@ -75,7 +75,7 @@ static int modeset_init(struct drm_device *dev)
 		mod->funcs->modeset_init(mod, dev);
 	}
 
-	if ((priv->num_encoders = 0) || (priv->num_connectors == 0)) {
+	if ((priv->num_encoders == 0) || (priv->num_connectors == 0)) {
 		/* oh nos! */
 		dev_err(dev->dev, "no encoders/connectors found\n");
 		return -ENXIO;
-- 
1.7.4.1

Re: [PATCH 1/4] drm/tilcdc: Fix an incorrect condition

[Rob Clark]

On Sat, Mar 2, 2013 at 5:23 AM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> Instead of checking if num_encoders is zero, it is being assigned 0.
> Convert the assignment to a check.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>

Signed-off-by: Rob Clark <robdclark@gmail.com>

> ---
>  drivers/gpu/drm/tilcdc/tilcdc_drv.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> index c5b592d..bfac582 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> @@ -75,7 +75,7 @@ static int modeset_init(struct drm_device *dev)
>                 mod->funcs->modeset_init(mod, dev);
>         }
>
> -       if ((priv->num_encoders = 0) || (priv->num_connectors == 0)) {
> +       if ((priv->num_encoders == 0) || (priv->num_connectors == 0)) {
>                 /* oh nos! */
>                 dev_err(dev->dev, "no encoders/connectors found\n");
>                 return -ENXIO;
> --
> 1.7.4.1
>

Re: [PATCH 1/4] drm/tilcdc: Fix an incorrect condition

[Sachin Kamat]

Hi Rob,

On 2 March 2013 20:40, Rob Clark <robdclark@gmail.com> wrote:
> On Sat, Mar 2, 2013 at 5:23 AM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
>> Instead of checking if num_encoders is zero, it is being assigned 0.
>> Convert the assignment to a check.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>
> Signed-off-by: Rob Clark <robdclark@gmail.com>

Just curious. Which tree would these patches be applied to (I mean
your tree or Dave's)?


-- 
With warm regards,
Sachin

Re: [PATCH 1/4] drm/tilcdc: Fix an incorrect condition

[Sachin Kamat]

On 11 March 2013 15:38, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> Hi Rob,
>
> On 2 March 2013 20:40, Rob Clark <robdclark@gmail.com> wrote:
>> On Sat, Mar 2, 2013 at 5:23 AM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
>>> Instead of checking if num_encoders is zero, it is being assigned 0.
>>> Convert the assignment to a check.
>>>
>>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>>
>> Signed-off-by: Rob Clark <robdclark@gmail.com>
>
> Just curious. Which tree would these patches be applied to (I mean
> your tree or Dave's)?

ping...


-- 
With warm regards,
Sachin

Re: [PATCH 1/4] drm/tilcdc: Fix an incorrect condition

[Rob Clark]

sorry, was offline for a while (moving), and missed the last email..

I would guess that Tomi would send pull-req for tilcdc and omapdrm.
Well I suppose I could do it if Tomi can't, although my
pandas/beagles/beaglebones are not unpacked yet..

BR,
-R

On Mon, Mar 25, 2013 at 2:58 AM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> On 11 March 2013 15:38, Sachin Kamat <sachin.kamat@linaro.org> wrote:
>> Hi Rob,
>>
>> On 2 March 2013 20:40, Rob Clark <robdclark@gmail.com> wrote:
>>> On Sat, Mar 2, 2013 at 5:23 AM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
>>>> Instead of checking if num_encoders is zero, it is being assigned 0.
>>>> Convert the assignment to a check.
>>>>
>>>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>>>
>>> Signed-off-by: Rob Clark <robdclark@gmail.com>
>>
>> Just curious. Which tree would these patches be applied to (I mean
>> your tree or Dave's)?
>
> ping...
>
>
> --
> With warm regards,
> Sachin

Re: [PATCH 1/4] drm/tilcdc: Fix an incorrect condition

[Sachin Kamat]

On 25 March 2013 19:06, Rob Clark <robdclark@gmail.com> wrote:
> sorry, was offline for a while (moving), and missed the last email..

No problem :)
>
> I would guess that Tomi would send pull-req for tilcdc and omapdrm.
> Well I suppose I could do it if Tomi can't, although my
> pandas/beagles/beaglebones are not unpacked yet..

Ok. Thanks.


-- 
With warm regards,
Sachin

Re: [PATCH 1/4] drm/tilcdc: Fix an incorrect condition

[Tomi Valkeinen]

[-- Attachment #1.1: Type: text/plain, Size: 592 bytes --]

Hi,

On 2013-03-25 15:36, Rob Clark wrote:
> sorry, was offline for a while (moving), and missed the last email..
> 
> I would guess that Tomi would send pull-req for tilcdc and omapdrm.
> Well I suppose I could do it if Tomi can't, although my
> pandas/beagles/beaglebones are not unpacked yet..

Well, I know nothing about tilcdc, I don't have a board to test it, it
was merged even if I had objections, and I've got my hands full already...

I think for the moment tilcdc is either maintained by Rob, or is
unmaintained.

I will try to handle omapdrm, though.

 Tomi



[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 899 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/4] drm/tilcdc: Fix an incorrect condition

[Sachin Kamat]

Hi Rob,

With the merge window for 3.10 about to open shortly, I was wondering
if the tilcdc patches are lined up somewhere as I could not find them
in linux-next yet.

Thanks and regards,
Sachin.

On 27 March 2013 11:53, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
> Hi,
>
> On 2013-03-25 15:36, Rob Clark wrote:
>> sorry, was offline for a while (moving), and missed the last email..
>>
>> I would guess that Tomi would send pull-req for tilcdc and omapdrm.
>> Well I suppose I could do it if Tomi can't, although my
>> pandas/beagles/beaglebones are not unpacked yet..
>
> Well, I know nothing about tilcdc, I don't have a board to test it, it
> was merged even if I had objections, and I've got my hands full already...
>
> I think for the moment tilcdc is either maintained by Rob, or is
> unmaintained.
>
> I will try to handle omapdrm, though.
>
>  Tomi
>
>

Re: [PATCH 1/4] drm/tilcdc: Fix an incorrect condition

[Rob Clark]

On Tue, Apr 23, 2013 at 11:52 PM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> Hi Rob,
>
> With the merge window for 3.10 about to open shortly, I was wondering
> if the tilcdc patches are lined up somewhere as I could not find them
> in linux-next yet.

I don't have any other patches for tilcdc, so if this isn't going
through a pull req from tomi then I think it would be fine if Dave
takes it directly through the drm-next tree.  This patch has my s-o-b,
it fixes an obvious typo.

BR,
-R


> Thanks and regards,
> Sachin.
>
> On 27 March 2013 11:53, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
>> Hi,
>>
>> On 2013-03-25 15:36, Rob Clark wrote:
>>> sorry, was offline for a while (moving), and missed the last email..
>>>
>>> I would guess that Tomi would send pull-req for tilcdc and omapdrm.
>>> Well I suppose I could do it if Tomi can't, although my
>>> pandas/beagles/beaglebones are not unpacked yet..
>>
>> Well, I know nothing about tilcdc, I don't have a board to test it, it
>> was merged even if I had objections, and I've got my hands full already...
>>
>> I think for the moment tilcdc is either maintained by Rob, or is
>> unmaintained.
>>
>> I will try to handle omapdrm, though.
>>
>>  Tomi
>>
>>

Re: [PATCH 1/4] drm/tilcdc: Fix an incorrect condition

[Sachin Kamat]

On 24 April 2013 09:47, Rob Clark <robdclark@gmail.com> wrote:
> On Tue, Apr 23, 2013 at 11:52 PM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
>> Hi Rob,
>>
>> With the merge window for 3.10 about to open shortly, I was wondering
>> if the tilcdc patches are lined up somewhere as I could not find them
>> in linux-next yet.
>
> I don't have any other patches for tilcdc, so if this isn't going
> through a pull req from tomi then I think it would be fine if Dave
> takes it directly through the drm-next tree.  This patch has my s-o-b,
> it fixes an obvious typo.

Thanks Rob.

Dave,
Could you please pick these 4 patches? Or do I send them again?



>> On 27 March 2013 11:53, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
>>> Hi,
>>>
>>> On 2013-03-25 15:36, Rob Clark wrote:
>>>> sorry, was offline for a while (moving), and missed the last email..
>>>>
>>>> I would guess that Tomi would send pull-req for tilcdc and omapdrm.
>>>> Well I suppose I could do it if Tomi can't, although my
>>>> pandas/beagles/beaglebones are not unpacked yet..
>>>
>>> Well, I know nothing about tilcdc, I don't have a board to test it, it
>>> was merged even if I had objections, and I've got my hands full already...
>>>
>>> I think for the moment tilcdc is either maintained by Rob, or is
>>> unmaintained.
>>>
>>> I will try to handle omapdrm, though.
>>>
>>>  Tomi
>>>
>>>



-- 
With warm regards,
Sachin

Re: [PATCH 1/4] drm/tilcdc: Fix an incorrect condition

[Dave Airlie]

On Wed, Apr 24, 2013 at 2:21 PM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> On 24 April 2013 09:47, Rob Clark <robdclark@gmail.com> wrote:
>> On Tue, Apr 23, 2013 at 11:52 PM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
>>> Hi Rob,
>>>
>>> With the merge window for 3.10 about to open shortly, I was wondering
>>> if the tilcdc patches are lined up somewhere as I could not find them
>>> in linux-next yet.
>>
>> I don't have any other patches for tilcdc, so if this isn't going
>> through a pull req from tomi then I think it would be fine if Dave
>> takes it directly through the drm-next tree.  This patch has my s-o-b,
>> it fixes an obvious typo.
>
> Thanks Rob.
>
> Dave,
> Could you please pick these 4 patches? Or do I send them again?
>

All 4 are in drm-next now.

Future reference, Acked-by: if you aren't going to handle the patches,
I'm not saying
it will make me notice them any quicker though.

Dave.

Re: [PATCH 1/4] drm/tilcdc: Fix an incorrect condition

[Sachin Kamat]

On 24 April 2013 10:08, Dave Airlie <airlied@gmail.com> wrote:
> On Wed, Apr 24, 2013 at 2:21 PM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
>> On 24 April 2013 09:47, Rob Clark <robdclark@gmail.com> wrote:
>>> On Tue, Apr 23, 2013 at 11:52 PM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
>>>> Hi Rob,
>>>>
>>>> With the merge window for 3.10 about to open shortly, I was wondering
>>>> if the tilcdc patches are lined up somewhere as I could not find them
>>>> in linux-next yet.
>>>
>>> I don't have any other patches for tilcdc, so if this isn't going
>>> through a pull req from tomi then I think it would be fine if Dave
>>> takes it directly through the drm-next tree.  This patch has my s-o-b,
>>> it fixes an obvious typo.
>>
>> Thanks Rob.
>>
>> Dave,
>> Could you please pick these 4 patches? Or do I send them again?
>>
>
> All 4 are in drm-next now.

Thanks Dave.


-- 
With warm regards,
Sachin

[PATCH 2/4] drm/tilcdc: Remove unnecessary braces

[Sachin Kamat]

Silences the following checkpatch warning:
WARNING: braces {} are not necessary for any arm of this statement
	if (priv->rev == 1) {

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 drivers/gpu/drm/tilcdc/tilcdc_drv.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
index bfac582..909f2bd 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
@@ -299,11 +299,10 @@ static int tilcdc_irq_postinstall(struct drm_device *dev)
 	struct tilcdc_drm_private *priv = dev->dev_private;
 
 	/* enable FIFO underflow irq: */
-	if (priv->rev == 1) {
+	if (priv->rev == 1)
 		tilcdc_set(dev, LCDC_RASTER_CTRL_REG, LCDC_V1_UNDERFLOW_INT_ENA);
-	} else {
+	else
 		tilcdc_set(dev, LCDC_INT_ENABLE_SET_REG, LCDC_V2_UNDERFLOW_INT_ENA);
-	}
 
 	return 0;
 }
-- 
1.7.4.1

Re: [PATCH 2/4] drm/tilcdc: Remove unnecessary braces

[Rob Clark]

On Sat, Mar 2, 2013 at 5:23 AM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> Silences the following checkpatch warning:
> WARNING: braces {} are not necessary for any arm of this statement
>         if (priv->rev == 1) {
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>

Signed-off-by: Rob Clark <robdclark@gmail.com>

> ---
>  drivers/gpu/drm/tilcdc/tilcdc_drv.c |    5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> index bfac582..909f2bd 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> @@ -299,11 +299,10 @@ static int tilcdc_irq_postinstall(struct drm_device *dev)
>         struct tilcdc_drm_private *priv = dev->dev_private;
>
>         /* enable FIFO underflow irq: */
> -       if (priv->rev == 1) {
> +       if (priv->rev == 1)
>                 tilcdc_set(dev, LCDC_RASTER_CTRL_REG, LCDC_V1_UNDERFLOW_INT_ENA);
> -       } else {
> +       else
>                 tilcdc_set(dev, LCDC_INT_ENABLE_SET_REG, LCDC_V2_UNDERFLOW_INT_ENA);
> -       }
>
>         return 0;
>  }
> --
> 1.7.4.1
>

[PATCH 3/4] drm/tilcdc: Remove space before tab

[Sachin Kamat]

Silences the following checkpatch warning:
WARNING: please, no space before tabs

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 drivers/gpu/drm/tilcdc/tilcdc_drv.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
index 909f2bd..2b5461b 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
@@ -362,7 +362,7 @@ static const struct {
 	uint8_t  rev;
 	uint8_t  save;
 	uint32_t reg;
-} registers[] = 	{
+} registers[] =		{
 #define REG(rev, save, reg) { #reg, rev, save, reg }
 		/* exists in revision 1: */
 		REG(1, false, LCDC_PID_REG),
-- 
1.7.4.1

Re: [PATCH 3/4] drm/tilcdc: Remove space before tab

[Rob Clark]

On Sat, Mar 2, 2013 at 5:23 AM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> Silences the following checkpatch warning:
> WARNING: please, no space before tabs
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>

Signed-off-by: Rob Clark <robdclark@gmail.com>

> ---
>  drivers/gpu/drm/tilcdc/tilcdc_drv.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> index 909f2bd..2b5461b 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> @@ -362,7 +362,7 @@ static const struct {
>         uint8_t  rev;
>         uint8_t  save;
>         uint32_t reg;
> -} registers[] =        {
> +} registers[] =                {
>  #define REG(rev, save, reg) { #reg, rev, save, reg }
>                 /* exists in revision 1: */
>                 REG(1, false, LCDC_PID_REG),
> --
> 1.7.4.1
>

[PATCH 4/4] drm/tilcdc: Fix checkpatch error in tilcdc_panel.c

[Sachin Kamat]

Fixes the following checkpatch error:
ERROR: "foo * bar" should be "foo *bar"

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 drivers/gpu/drm/tilcdc/tilcdc_panel.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
index 580b74e..719e8ec 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
@@ -305,7 +305,7 @@ static const struct tilcdc_module_ops panel_module_ops = {
  */
 
 /* maybe move this somewhere common if it is needed by other outputs? */
-static struct tilcdc_panel_info * of_get_panel_info(struct device_node *np)
+static struct tilcdc_panel_info *of_get_panel_info(struct device_node *np)
 {
 	struct device_node *info_np;
 	struct tilcdc_panel_info *info;
-- 
1.7.4.1