* unaligned access in part_efi.c
@ 2013-03-26 20:42 ` Marc Dietrich
0 siblings, 0 replies; 6+ messages in thread
From: Marc Dietrich @ 2013-03-26 20:42 UTC (permalink / raw)
To: U-Boot-0aAXYlwwYIKGBzrmiIFOJg
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA, Tom Warren, Stephen Warren,
Chang Hyun Park
Hi,
access to part->start_sect in pmbr_part_valid() (form disk/part_efi.c) and
propably other positions/fields causes an unaligned access on ARM (tegra in my
case) and a uboot crash. This was introduced by commit fae2bf22 [1] which
changed le32_to_int (which is a byte access) to le32_to_cpu (which is a 32bit
access).
I'm not sure how to fix this as I'm not very familar with this kind of
problems. Any help?
Thanks!
Marc
[1] gpt: The leXX_to_int() calls replaced with ones defined at <compiler.h>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] unaligned access in part_efi.c
@ 2013-03-26 20:42 ` Marc Dietrich
0 siblings, 0 replies; 6+ messages in thread
From: Marc Dietrich @ 2013-03-26 20:42 UTC (permalink / raw)
To: u-boot
Hi,
access to part->start_sect in pmbr_part_valid() (form disk/part_efi.c) and
propably other positions/fields causes an unaligned access on ARM (tegra in my
case) and a uboot crash. This was introduced by commit fae2bf22 [1] which
changed le32_to_int (which is a byte access) to le32_to_cpu (which is a 32bit
access).
I'm not sure how to fix this as I'm not very familar with this kind of
problems. Any help?
Thanks!
Marc
[1] gpt: The leXX_to_int() calls replaced with ones defined at <compiler.h>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: unaligned access in part_efi.c
2013-03-26 20:42 ` [U-Boot] " Marc Dietrich
@ 2013-03-27 18:23 ` Stephen Warren
-1 siblings, 0 replies; 6+ messages in thread
From: Stephen Warren @ 2013-03-27 18:23 UTC (permalink / raw)
To: Marc Dietrich
Cc: U-Boot-0aAXYlwwYIKGBzrmiIFOJg, linux-tegra-u79uwXL29TY76Z2rM5mHXA,
Tom Warren, Chang Hyun Park
On 03/26/2013 02:42 PM, Marc Dietrich wrote:
> Hi,
>
> access to part->start_sect in pmbr_part_valid() (form disk/part_efi.c) and
> propably other positions/fields causes an unaligned access on ARM (tegra in my
> case) and a uboot crash. This was introduced by commit fae2bf22 [1] which
> changed le32_to_int (which is a byte access) to le32_to_cpu (which is a 32bit
> access).
I can't reproduce this with latest u-boot-arm/master, which includes
that commit. Both "mmc dev N; mmc rescan ; mmcinfo" and "part list mmc
N" work fine for me with both DOS PT and GPT.
I did test this on a Tegra Seaboard which isn't identical to the AC100,
but the only practical difference is 512M vs 1G RAM, which seems
unlikely to cause this.
It'd help if you pointed out exactly which access causes the issue;
which piece of code is failing. The most likely issue is that some
memory buffer is assumed to be aligned to 4-bytes, but actually isn't.
To track that down, we'd need to know which code and which buffer. Also,
a disassembly of the problematic function would be useful.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] unaligned access in part_efi.c
@ 2013-03-27 18:23 ` Stephen Warren
0 siblings, 0 replies; 6+ messages in thread
From: Stephen Warren @ 2013-03-27 18:23 UTC (permalink / raw)
To: u-boot
On 03/26/2013 02:42 PM, Marc Dietrich wrote:
> Hi,
>
> access to part->start_sect in pmbr_part_valid() (form disk/part_efi.c) and
> propably other positions/fields causes an unaligned access on ARM (tegra in my
> case) and a uboot crash. This was introduced by commit fae2bf22 [1] which
> changed le32_to_int (which is a byte access) to le32_to_cpu (which is a 32bit
> access).
I can't reproduce this with latest u-boot-arm/master, which includes
that commit. Both "mmc dev N; mmc rescan ; mmcinfo" and "part list mmc
N" work fine for me with both DOS PT and GPT.
I did test this on a Tegra Seaboard which isn't identical to the AC100,
but the only practical difference is 512M vs 1G RAM, which seems
unlikely to cause this.
It'd help if you pointed out exactly which access causes the issue;
which piece of code is failing. The most likely issue is that some
memory buffer is assumed to be aligned to 4-bytes, but actually isn't.
To track that down, we'd need to know which code and which buffer. Also,
a disassembly of the problematic function would be useful.
^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <5153391A.1010201-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>]
* Re: unaligned access in part_efi.c
2013-03-27 18:23 ` [U-Boot] " Stephen Warren
@ 2013-03-27 21:46 ` Marc Dietrich
-1 siblings, 0 replies; 6+ messages in thread
From: Marc Dietrich @ 2013-03-27 21:46 UTC (permalink / raw)
To: Stephen Warren
Cc: U-Boot-0aAXYlwwYIKGBzrmiIFOJg, linux-tegra-u79uwXL29TY76Z2rM5mHXA,
Tom Warren, Chang Hyun Park
On Wednesday 27 March 2013 12:23:22 Stephen Warren wrote:
> On 03/26/2013 02:42 PM, Marc Dietrich wrote:
> > Hi,
> >
> > access to part->start_sect in pmbr_part_valid() (form disk/part_efi.c) and
> > propably other positions/fields causes an unaligned access on ARM (tegra
> > in my case) and a uboot crash. This was introduced by commit fae2bf22 [1]
> > which changed le32_to_int (which is a byte access) to le32_to_cpu (which
> > is a 32bit access).
>
> I can't reproduce this with latest u-boot-arm/master, which includes
> that commit. Both "mmc dev N; mmc rescan ; mmcinfo" and "part list mmc
> N" work fine for me with both DOS PT and GPT.
>
> I did test this on a Tegra Seaboard which isn't identical to the AC100,
> but the only practical difference is 512M vs 1G RAM, which seems
> unlikely to cause this.
>
> It'd help if you pointed out exactly which access causes the issue;
> which piece of code is failing. The most likely issue is that some
> memory buffer is assumed to be aligned to 4-bytes, but actually isn't.
> To track that down, we'd need to know which code and which buffer. Also,
> a disassembly of the problematic function would be useful.
As discussed on IRC, this only happens with gcc 4.7 or patched gcc 4.6 (e.g.
from linaro) which has -maligned-access as default enabled. I added -mno-
aligned-access to the disk/Makefile and now it boots, but I doubt that this is
the best solution.
Marc
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] unaligned access in part_efi.c
@ 2013-03-27 21:46 ` Marc Dietrich
0 siblings, 0 replies; 6+ messages in thread
From: Marc Dietrich @ 2013-03-27 21:46 UTC (permalink / raw)
To: u-boot
On Wednesday 27 March 2013 12:23:22 Stephen Warren wrote:
> On 03/26/2013 02:42 PM, Marc Dietrich wrote:
> > Hi,
> >
> > access to part->start_sect in pmbr_part_valid() (form disk/part_efi.c) and
> > propably other positions/fields causes an unaligned access on ARM (tegra
> > in my case) and a uboot crash. This was introduced by commit fae2bf22 [1]
> > which changed le32_to_int (which is a byte access) to le32_to_cpu (which
> > is a 32bit access).
>
> I can't reproduce this with latest u-boot-arm/master, which includes
> that commit. Both "mmc dev N; mmc rescan ; mmcinfo" and "part list mmc
> N" work fine for me with both DOS PT and GPT.
>
> I did test this on a Tegra Seaboard which isn't identical to the AC100,
> but the only practical difference is 512M vs 1G RAM, which seems
> unlikely to cause this.
>
> It'd help if you pointed out exactly which access causes the issue;
> which piece of code is failing. The most likely issue is that some
> memory buffer is assumed to be aligned to 4-bytes, but actually isn't.
> To track that down, we'd need to know which code and which buffer. Also,
> a disassembly of the problematic function would be useful.
As discussed on IRC, this only happens with gcc 4.7 or patched gcc 4.6 (e.g.
from linaro) which has -maligned-access as default enabled. I added -mno-
aligned-access to the disk/Makefile and now it boots, but I doubt that this is
the best solution.
Marc
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-03-27 21:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-26 20:42 unaligned access in part_efi.c Marc Dietrich
2013-03-26 20:42 ` [U-Boot] " Marc Dietrich
2013-03-27 18:23 ` Stephen Warren
2013-03-27 18:23 ` [U-Boot] " Stephen Warren
[not found] ` <5153391A.1010201-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-03-27 21:46 ` Marc Dietrich
2013-03-27 21:46 ` [U-Boot] " Marc Dietrich
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.