From: Donghwa Lee <dh09.lee@samsung.com>
To: Andrei Epure <epure.andrei@gmail.com>
Cc: inki.dae@samsung.com, kyungmin.park@samsung.com,
FlorianSchandinat@gmx.de, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] video: exynos: Convert to devm_ioremap_resource()
Date: Wed, 27 Mar 2013 23:52:50 +0000 [thread overview]
Message-ID: <51538652.7040005@samsung.com> (raw)
In-Reply-To: <1364416081-24113-1-git-send-email-epure.andrei@gmail.com>
Hi,
Please refer to the following link.
http://marc.info/?l=linux-fbdev&m\x135963121130437&w=2
Best regard,
Donghwa Lee
On Thu, Mar 28, 2013 at 05:28, Andrei Epure wrote:
> The new devm_ioremap_resource() provides its own error messages.
> Patch found using coccinelle.
>
> Signed-off-by: Andrei Epure <epure.andrei@gmail.com>
> ---
> drivers/video/exynos/exynos_mipi_dsi.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/video/exynos/exynos_mipi_dsi.c b/drivers/video/exynos/exynos_mipi_dsi.c
> index fac7df6..dd5e5e9 100644
> --- a/drivers/video/exynos/exynos_mipi_dsi.c
> +++ b/drivers/video/exynos/exynos_mipi_dsi.c
> @@ -384,10 +384,9 @@ static int exynos_mipi_dsi_probe(struct platform_device *pdev)
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>
> - dsim->reg_base = devm_request_and_ioremap(&pdev->dev, res);
> - if (!dsim->reg_base) {
> - dev_err(&pdev->dev, "failed to remap io region\n");
> - ret = -ENOMEM;
> + dsim->reg_base = devm_ioremap_resource(&pdev->dev, res);
> + if (IS_ERR(dsim->reg_base)) {
> + ret = PTR_ERR(dsim->reg_base);
> goto error;
> }
>
WARNING: multiple messages have this Message-ID (diff)
From: Donghwa Lee <dh09.lee@samsung.com>
To: Andrei Epure <epure.andrei@gmail.com>
Cc: inki.dae@samsung.com, kyungmin.park@samsung.com,
FlorianSchandinat@gmx.de, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] video: exynos: Convert to devm_ioremap_resource()
Date: Thu, 28 Mar 2013 08:52:50 +0900 [thread overview]
Message-ID: <51538652.7040005@samsung.com> (raw)
In-Reply-To: <1364416081-24113-1-git-send-email-epure.andrei@gmail.com>
Hi,
Please refer to the following link.
http://marc.info/?l=linux-fbdev&m=135963121130437&w=2
Best regard,
Donghwa Lee
On Thu, Mar 28, 2013 at 05:28, Andrei Epure wrote:
> The new devm_ioremap_resource() provides its own error messages.
> Patch found using coccinelle.
>
> Signed-off-by: Andrei Epure <epure.andrei@gmail.com>
> ---
> drivers/video/exynos/exynos_mipi_dsi.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/video/exynos/exynos_mipi_dsi.c b/drivers/video/exynos/exynos_mipi_dsi.c
> index fac7df6..dd5e5e9 100644
> --- a/drivers/video/exynos/exynos_mipi_dsi.c
> +++ b/drivers/video/exynos/exynos_mipi_dsi.c
> @@ -384,10 +384,9 @@ static int exynos_mipi_dsi_probe(struct platform_device *pdev)
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>
> - dsim->reg_base = devm_request_and_ioremap(&pdev->dev, res);
> - if (!dsim->reg_base) {
> - dev_err(&pdev->dev, "failed to remap io region\n");
> - ret = -ENOMEM;
> + dsim->reg_base = devm_ioremap_resource(&pdev->dev, res);
> + if (IS_ERR(dsim->reg_base)) {
> + ret = PTR_ERR(dsim->reg_base);
> goto error;
> }
>
next prev parent reply other threads:[~2013-03-27 23:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-27 20:28 [PATCH] video: exynos: Convert to devm_ioremap_resource() Andrei Epure
2013-03-27 20:28 ` Andrei Epure
2013-03-27 23:52 ` Donghwa Lee [this message]
2013-03-27 23:52 ` Donghwa Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51538652.7040005@samsung.com \
--to=dh09.lee@samsung.com \
--cc=FlorianSchandinat@gmx.de \
--cc=epure.andrei@gmail.com \
--cc=inki.dae@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.