[PATCH 1/2] ARM: tegra: Export tegra_powergate_sequence_power_up()

[PATCH 1/2] ARM: tegra: Export tegra_powergate_sequence_power_up()

[Thierry Reding]

This function can be used by drivers to enable power to the hardware
blocks that they drive. Most of the drivers can be built as a module
and therefore require this function to be exported.

Signed-off-by: Thierry Reding <thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
---
 arch/arm/mach-tegra/powergate.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/mach-tegra/powergate.c b/arch/arm/mach-tegra/powergate.c
index c6bc8f8..c472bed 100644
--- a/arch/arm/mach-tegra/powergate.c
+++ b/arch/arm/mach-tegra/powergate.c
@@ -22,6 +22,7 @@
 #include <linux/debugfs.h>
 #include <linux/delay.h>
 #include <linux/err.h>
+#include <linux/export.h>
 #include <linux/init.h>
 #include <linux/io.h>
 #include <linux/seq_file.h>
@@ -168,6 +169,7 @@ err_clk:
 err_power:
 	return ret;
 }
+EXPORT_SYMBOL(tegra_powergate_sequence_power_up);
 
 int tegra_cpu_powergate_id(int cpuid)
 {
-- 
1.8.1.5

[PATCH 2/2] ARM: tegra: powergate: Don't error out if new state == old state

[Thierry Reding]

Don't treat it as an error if a partition is already in the same power
state when a user wants to power it on or off. This allows code to
proceed if no state change is required.

Signed-off-by: Thierry Reding <thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
---
 arch/arm/mach-tegra/powergate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-tegra/powergate.c b/arch/arm/mach-tegra/powergate.c
index c472bed..af9067e 100644
--- a/arch/arm/mach-tegra/powergate.c
+++ b/arch/arm/mach-tegra/powergate.c
@@ -76,7 +76,7 @@ static int tegra_powergate_set(int id, bool new_state)
 
 	if (status == new_state) {
 		spin_unlock_irqrestore(&tegra_powergate_lock, flags);
-		return -EINVAL;
+		return 0;
 	}
 
 	pmc_write(PWRGATE_TOGGLE_START | id, PWRGATE_TOGGLE);
-- 
1.8.1.5

Re: [PATCH 2/2] ARM: tegra: powergate: Don't error out if new state == old state

[Stephen Warren]

On 03/28/2013 02:35 PM, Thierry Reding wrote:
> Don't treat it as an error if a partition is already in the same power
> state when a user wants to power it on or off. This allows code to
> proceed if no state change is required.

Joseph, I think you had argued specifically against making this change
in the past. Are you OK with this?

Re: [PATCH 2/2] ARM: tegra: powergate: Don't error out if new state == old state

[Joseph Lo]

On Fri, 2013-03-29 at 07:23 +0800, Stephen Warren wrote:
> On 03/28/2013 02:35 PM, Thierry Reding wrote:
> > Don't treat it as an error if a partition is already in the same power
> > state when a user wants to power it on or off. This allows code to
> > proceed if no state change is required.
> 
> Joseph, I think you had argued specifically against making this change
> in the past. Are you OK with this?

Oh, that is because I use the same function for CPU hot plug power
control, and I need to know the power status when doing power control.
But I moved all the CPU power control function into PMC driver. So I am
OK with this change.

Thanks,
Joseph

Re: [PATCH 1/2] ARM: tegra: Export tegra_powergate_sequence_power_up()

[Stephen Warren]

On 03/28/2013 02:35 PM, Thierry Reding wrote:
> This function can be used by drivers to enable power to the hardware
> blocks that they drive. Most of the drivers can be built as a module
> and therefore require this function to be exported.

I applied the series to Tegra's for-3.10/fixes branch.