Re: [Qemu-devel] [Patch] fix /proc/self/maps output

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1098 bytes --]

On 03/29/2013 09:13 AM, Christophe Lyon wrote:
> Hi,
> 
> Sorry I wasn't aware of such restrictions (I'm used to gcc/binutils
> conventions), and my thunderbird does display my patch as if it were
> inline :-)
> So.... trying a cut-and-paste approach in gmail, for this one character patch:

Still not ideal.  The commentary above should not be part of the final
commit message, so you should move it...

> 
> 
> /proc/self/maps: Add a space at end of line when there is no filename
> to print, to conform to linux kernel format.
> 
> Signed-off-by: Christophe Lyon <christophe.lyon@linaro.org>

...here, after a --- line that tells 'git am' where to stop reading
commit message.  'git send-email' is your friend.  Then whether or not
you use 'git send-email', it is always wise to test if your patch is
usable by first sending it to yourself, and seeing if 'git am' will do
the right thing with it.

http://wiki.qemu.org/Contribute/SubmitAPatch has more hints.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]