All of lore.kernel.org
 help / color / mirror / Atom feed
From: dv <dv@pseudoterminal.org>
To: openembedded-devel@lists.openembedded.org
Subject: gst-ffmpeg configure-fix patch and yasm
Date: Sat, 30 Mar 2013 16:00:13 +0100	[thread overview]
Message-ID: <5156FDFD.1030606@pseudoterminal.org> (raw)

Hello,

I noticed this part of the configure-fix.patch file for gst-ffmpeg 0.10.13:

+  if test "x$disable_yasm" != "xyes"; then
+    embffmpeg_configure_args="$embffmpeg_configure_args --disable-yasm"
+  fi

Shouldn't the test be:  if test "x$disable_yasm" = "xyes"  ?
To me, it seems as if this code adds --disable-yasm if disable_yasm is 
not set to "yes", which is the complete opposite of the intended behavior.

Or am I missing some detail about shell script code here?



             reply	other threads:[~2013-03-30 15:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-30 15:00 dv [this message]
2013-03-30 16:40 ` gst-ffmpeg configure-fix patch and yasm Otavio Salvador
2013-03-30 20:30   ` dv
2013-03-30 22:10     ` Otavio Salvador
2013-04-03  5:07     ` Martin Jansa
2013-04-11 14:18       ` Martin Jansa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5156FDFD.1030606@pseudoterminal.org \
    --to=dv@pseudoterminal.org \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.