* gst-ffmpeg configure-fix patch and yasm @ 2013-03-30 15:00 dv 2013-03-30 16:40 ` Otavio Salvador 0 siblings, 1 reply; 6+ messages in thread From: dv @ 2013-03-30 15:00 UTC (permalink / raw) To: openembedded-devel Hello, I noticed this part of the configure-fix.patch file for gst-ffmpeg 0.10.13: + if test "x$disable_yasm" != "xyes"; then + embffmpeg_configure_args="$embffmpeg_configure_args --disable-yasm" + fi Shouldn't the test be: if test "x$disable_yasm" = "xyes" ? To me, it seems as if this code adds --disable-yasm if disable_yasm is not set to "yes", which is the complete opposite of the intended behavior. Or am I missing some detail about shell script code here? ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: gst-ffmpeg configure-fix patch and yasm 2013-03-30 15:00 gst-ffmpeg configure-fix patch and yasm dv @ 2013-03-30 16:40 ` Otavio Salvador 2013-03-30 20:30 ` dv 0 siblings, 1 reply; 6+ messages in thread From: Otavio Salvador @ 2013-03-30 16:40 UTC (permalink / raw) To: OpenEmbedded Devel List On Sat, Mar 30, 2013 at 12:00 PM, dv <dv@pseudoterminal.org> wrote: > Hello, > > I noticed this part of the configure-fix.patch file for gst-ffmpeg 0.10.13: > > + if test "x$disable_yasm" != "xyes"; then > + embffmpeg_configure_args="$embffmpeg_configure_args --disable-yasm" > + fi > > Shouldn't the test be: if test "x$disable_yasm" = "xyes" ? > To me, it seems as if this code adds --disable-yasm if disable_yasm is not > set to "yes", which is the complete opposite of the intended behavior. > > Or am I missing some detail about shell script code here? I think you are right here. Maybe you could provide a fix for it? -- Otavio Salvador O.S. Systems E-mail: otavio@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: gst-ffmpeg configure-fix patch and yasm 2013-03-30 16:40 ` Otavio Salvador @ 2013-03-30 20:30 ` dv 2013-03-30 22:10 ` Otavio Salvador 2013-04-03 5:07 ` Martin Jansa 0 siblings, 2 replies; 6+ messages in thread From: dv @ 2013-03-30 20:30 UTC (permalink / raw) To: openembedded-devel [-- Attachment #1: Type: text/plain, Size: 1165 bytes --] On 03/30/13 17:40, Otavio Salvador wrote: > On Sat, Mar 30, 2013 at 12:00 PM, dv <dv@pseudoterminal.org> wrote: >> Hello, >> >> I noticed this part of the configure-fix.patch file for gst-ffmpeg 0.10.13: >> >> + if test "x$disable_yasm" != "xyes"; then >> + embffmpeg_configure_args="$embffmpeg_configure_args --disable-yasm" >> + fi >> >> Shouldn't the test be: if test "x$disable_yasm" = "xyes" ? >> To me, it seems as if this code adds --disable-yasm if disable_yasm is not >> set to "yes", which is the complete opposite of the intended behavior. >> >> Or am I missing some detail about shell script code here? > I think you are right here. Maybe you could provide a fix for it? > -- > Otavio Salvador O.S. Systems > E-mail: otavio@ossystems.com.br http://www.ossystems.com.br > Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br > > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel No problem. Patch for the patch attached :) [-- Attachment #2: 0001-gst-ffmpeg-configure-fix-patch-used-wrong-test.patch --] [-- Type: text/x-patch, Size: 1061 bytes --] From 4624e30adb13ad361f886eeda4272a7235bedd61 Mon Sep 17 00:00:00 2001 From: Carlos Rafael Giani <dv@pseudoterminal.org> Date: Sat, 30 Mar 2013 21:29:22 +0100 Subject: [PATCH] gst-ffmpeg: configure-fix patch used wrong test Signed-off-by: Carlos Rafael Giani <dv@pseudoterminal.org> --- .../recipes-multimedia/gstreamer/gst-ffmpeg-0.10.13/configure-fix.patch | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/recipes-multimedia/gstreamer/gst-ffmpeg-0.10.13/configure-fix.patch b/meta/recipes-multimedia/gstreamer/gst-ffmpeg-0.10.13/configure-fix.patch index 81029ca..2bb124b 100644 --- a/meta/recipes-multimedia/gstreamer/gst-ffmpeg-0.10.13/configure-fix.patch +++ b/meta/recipes-multimedia/gstreamer/gst-ffmpeg-0.10.13/configure-fix.patch @@ -11,7 +11,7 @@ diff -r f2f8f74c6e30 configure.ac --enable-gpl" fi -+ if test "x$disable_yasm" != "xyes"; then ++ if test "x$disable_yasm" = "xyes"; then + embffmpeg_configure_args="$embffmpeg_configure_args --disable-yasm" + fi + -- 1.8.2 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: gst-ffmpeg configure-fix patch and yasm 2013-03-30 20:30 ` dv @ 2013-03-30 22:10 ` Otavio Salvador 2013-04-03 5:07 ` Martin Jansa 1 sibling, 0 replies; 6+ messages in thread From: Otavio Salvador @ 2013-03-30 22:10 UTC (permalink / raw) To: OpenEmbedded Devel List, Martin Jansa Hello, On Sat, Mar 30, 2013 at 5:30 PM, dv <dv@pseudoterminal.org> wrote: > On 03/30/13 17:40, Otavio Salvador wrote: >> >> On Sat, Mar 30, 2013 at 12:00 PM, dv <dv@pseudoterminal.org> wrote: >>> >>> Hello, >>> >>> I noticed this part of the configure-fix.patch file for gst-ffmpeg >>> 0.10.13: >>> >>> + if test "x$disable_yasm" != "xyes"; then >>> + embffmpeg_configure_args="$embffmpeg_configure_args --disable-yasm" >>> + fi >>> >>> Shouldn't the test be: if test "x$disable_yasm" = "xyes" ? >>> To me, it seems as if this code adds --disable-yasm if disable_yasm is >>> not >>> set to "yes", which is the complete opposite of the intended behavior. >>> >>> Or am I missing some detail about shell script code here? >> >> I think you are right here. Maybe you could provide a fix for it? ... > No problem. Patch for the patch attached :) Please Martin, Can you review the patch in this thread? Regards, -- Otavio Salvador O.S. Systems E-mail: otavio@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: gst-ffmpeg configure-fix patch and yasm 2013-03-30 20:30 ` dv 2013-03-30 22:10 ` Otavio Salvador @ 2013-04-03 5:07 ` Martin Jansa 2013-04-11 14:18 ` Martin Jansa 1 sibling, 1 reply; 6+ messages in thread From: Martin Jansa @ 2013-04-03 5:07 UTC (permalink / raw) To: openembedded-devel [-- Attachment #1: Type: text/plain, Size: 2756 bytes --] On Sat, Mar 30, 2013 at 09:30:51PM +0100, dv wrote: > On 03/30/13 17:40, Otavio Salvador wrote: > > On Sat, Mar 30, 2013 at 12:00 PM, dv <dv@pseudoterminal.org> wrote: > >> Hello, > >> > >> I noticed this part of the configure-fix.patch file for gst-ffmpeg 0.10.13: > >> > >> + if test "x$disable_yasm" != "xyes"; then > >> + embffmpeg_configure_args="$embffmpeg_configure_args --disable-yasm" > >> + fi > >> > >> Shouldn't the test be: if test "x$disable_yasm" = "xyes" ? > >> To me, it seems as if this code adds --disable-yasm if disable_yasm is not > >> set to "yes", which is the complete opposite of the intended behavior. > >> > >> Or am I missing some detail about shell script code here? > > I think you are right here. Maybe you could provide a fix for it? > > -- > > Otavio Salvador O.S. Systems > > E-mail: otavio@ossystems.com.br http://www.ossystems.com.br > > Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br > > > > _______________________________________________ > > Openembedded-devel mailing list > > Openembedded-devel@lists.openembedded.org > > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel > > No problem. Patch for the patch attached :) This patch is for oe-core, it needs to be resend to openembedded-core@lists.openembedded.org > From 4624e30adb13ad361f886eeda4272a7235bedd61 Mon Sep 17 00:00:00 2001 > From: Carlos Rafael Giani <dv@pseudoterminal.org> > Date: Sat, 30 Mar 2013 21:29:22 +0100 > Subject: [PATCH] gst-ffmpeg: configure-fix patch used wrong test > > Signed-off-by: Carlos Rafael Giani <dv@pseudoterminal.org> > --- > .../recipes-multimedia/gstreamer/gst-ffmpeg-0.10.13/configure-fix.patch | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/recipes-multimedia/gstreamer/gst-ffmpeg-0.10.13/configure-fix.patch b/meta/recipes-multimedia/gstreamer/gst-ffmpeg-0.10.13/configure-fix.patch > index 81029ca..2bb124b 100644 > --- a/meta/recipes-multimedia/gstreamer/gst-ffmpeg-0.10.13/configure-fix.patch > +++ b/meta/recipes-multimedia/gstreamer/gst-ffmpeg-0.10.13/configure-fix.patch > @@ -11,7 +11,7 @@ diff -r f2f8f74c6e30 configure.ac > --enable-gpl" > fi > > -+ if test "x$disable_yasm" != "xyes"; then > ++ if test "x$disable_yasm" = "xyes"; then > + embffmpeg_configure_args="$embffmpeg_configure_args --disable-yasm" > + fi > + > -- > 1.8.2 > > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel -- Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 205 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: gst-ffmpeg configure-fix patch and yasm 2013-04-03 5:07 ` Martin Jansa @ 2013-04-11 14:18 ` Martin Jansa 0 siblings, 0 replies; 6+ messages in thread From: Martin Jansa @ 2013-04-11 14:18 UTC (permalink / raw) To: openembedded-devel [-- Attachment #1: Type: text/plain, Size: 3159 bytes --] On Wed, Apr 03, 2013 at 07:07:03AM +0200, Martin Jansa wrote: > On Sat, Mar 30, 2013 at 09:30:51PM +0100, dv wrote: > > On 03/30/13 17:40, Otavio Salvador wrote: > > > On Sat, Mar 30, 2013 at 12:00 PM, dv <dv@pseudoterminal.org> wrote: > > >> Hello, > > >> > > >> I noticed this part of the configure-fix.patch file for gst-ffmpeg 0.10.13: > > >> > > >> + if test "x$disable_yasm" != "xyes"; then > > >> + embffmpeg_configure_args="$embffmpeg_configure_args --disable-yasm" > > >> + fi > > >> > > >> Shouldn't the test be: if test "x$disable_yasm" = "xyes" ? > > >> To me, it seems as if this code adds --disable-yasm if disable_yasm is not > > >> set to "yes", which is the complete opposite of the intended behavior. > > >> > > >> Or am I missing some detail about shell script code here? > > > I think you are right here. Maybe you could provide a fix for it? > > > -- > > > Otavio Salvador O.S. Systems > > > E-mail: otavio@ossystems.com.br http://www.ossystems.com.br > > > Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br > > > > > > _______________________________________________ > > > Openembedded-devel mailing list > > > Openembedded-devel@lists.openembedded.org > > > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel > > > > No problem. Patch for the patch attached :) > > This patch is for oe-core, it needs to be resend to > openembedded-core@lists.openembedded.org Tom's patch was applied in oe-core http://git.openembedded.org/openembedded-core/commit/?id=da9515621134c26e54f43b96cdad0c6e6c5876bf > > > From 4624e30adb13ad361f886eeda4272a7235bedd61 Mon Sep 17 00:00:00 2001 > > From: Carlos Rafael Giani <dv@pseudoterminal.org> > > Date: Sat, 30 Mar 2013 21:29:22 +0100 > > Subject: [PATCH] gst-ffmpeg: configure-fix patch used wrong test > > > > Signed-off-by: Carlos Rafael Giani <dv@pseudoterminal.org> > > --- > > .../recipes-multimedia/gstreamer/gst-ffmpeg-0.10.13/configure-fix.patch | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/meta/recipes-multimedia/gstreamer/gst-ffmpeg-0.10.13/configure-fix.patch b/meta/recipes-multimedia/gstreamer/gst-ffmpeg-0.10.13/configure-fix.patch > > index 81029ca..2bb124b 100644 > > --- a/meta/recipes-multimedia/gstreamer/gst-ffmpeg-0.10.13/configure-fix.patch > > +++ b/meta/recipes-multimedia/gstreamer/gst-ffmpeg-0.10.13/configure-fix.patch > > @@ -11,7 +11,7 @@ diff -r f2f8f74c6e30 configure.ac > > --enable-gpl" > > fi > > > > -+ if test "x$disable_yasm" != "xyes"; then > > ++ if test "x$disable_yasm" = "xyes"; then > > + embffmpeg_configure_args="$embffmpeg_configure_args --disable-yasm" > > + fi > > + > > -- > > 1.8.2 > > > > > _______________________________________________ > > Openembedded-devel mailing list > > Openembedded-devel@lists.openembedded.org > > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel > > > -- > Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com -- Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 205 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-04-11 14:36 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-03-30 15:00 gst-ffmpeg configure-fix patch and yasm dv 2013-03-30 16:40 ` Otavio Salvador 2013-03-30 20:30 ` dv 2013-03-30 22:10 ` Otavio Salvador 2013-04-03 5:07 ` Martin Jansa 2013-04-11 14:18 ` Martin Jansa
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.