* [PATCH] salsa-lib: Fix error on jack compilation with salsa
@ 2013-03-17 15:13 Mihail Zenkov
2013-03-20 16:37 ` Takashi Iwai
0 siblings, 1 reply; 6+ messages in thread
From: Mihail Zenkov @ 2013-03-17 15:13 UTC (permalink / raw)
To: alsa-devel
Fix error on jack compilation with salsa:
/usr/include/alsa/ctl_macros.h:251:48: error: invalid conversion from
'void*' to 'snd_ctl_elem_id_t* {aka snd_ctl_elem_id*}' [-fpermissive]
--- salsa-lib-a55ce0c348cd16e7853dae11e8e0e1b5a101d884/src/ctl_macros.h
+++ salsa-lib-a55ce0c348cd16e7853dae11e8e0e1b5a101d884-1/src/ctl_macros.h
@@ -248,7 +248,7 @@
unsigned int entries)
{
free(obj->pids);
- obj->pids = calloc(entries, sizeof(*obj->pids));
+ obj->pids = (snd_ctl_elem_id_t*)calloc(entries, sizeof(*obj->pids));
if (!obj->pids) {
obj->space = 0;
return -ENOMEM;
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] salsa-lib: Fix error on jack compilation with salsa
2013-03-17 15:13 [PATCH] salsa-lib: Fix error on jack compilation with salsa Mihail Zenkov
@ 2013-03-20 16:37 ` Takashi Iwai
2013-03-30 19:11 ` Gabriel M. Beddingfield
0 siblings, 1 reply; 6+ messages in thread
From: Takashi Iwai @ 2013-03-20 16:37 UTC (permalink / raw)
To: Mihail Zenkov; +Cc: alsa-devel
At Sun, 17 Mar 2013 15:13:00 +0000,
Mihail Zenkov wrote:
>
> Fix error on jack compilation with salsa:
> /usr/include/alsa/ctl_macros.h:251:48: error: invalid conversion from
> 'void*' to 'snd_ctl_elem_id_t* {aka snd_ctl_elem_id*}' [-fpermissive]
I don't get it. Is it C++? But I thought the code is in extern "C"
region?
Takashi
>
> --- salsa-lib-a55ce0c348cd16e7853dae11e8e0e1b5a101d884/src/ctl_macros.h
> +++ salsa-lib-a55ce0c348cd16e7853dae11e8e0e1b5a101d884-1/src/ctl_macros.h
> @@ -248,7 +248,7 @@
> unsigned int entries)
> {
> free(obj->pids);
> - obj->pids = calloc(entries, sizeof(*obj->pids));
> + obj->pids = (snd_ctl_elem_id_t*)calloc(entries, sizeof(*obj->pids));
> if (!obj->pids) {
> obj->space = 0;
> return -ENOMEM;
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] salsa-lib: Fix error on jack compilation with salsa
2013-03-20 16:37 ` Takashi Iwai
@ 2013-03-30 19:11 ` Gabriel M. Beddingfield
2013-04-02 9:46 ` Takashi Iwai
0 siblings, 1 reply; 6+ messages in thread
From: Gabriel M. Beddingfield @ 2013-03-30 19:11 UTC (permalink / raw)
To: Takashi Iwai; +Cc: alsa-devel, Mihail Zenkov
On 03/20/2013 09:37 AM, Takashi Iwai wrote:
> At Sun, 17 Mar 2013 15:13:00 +0000,
> Mihail Zenkov wrote:
>>
>> Fix error on jack compilation with salsa:
>> /usr/include/alsa/ctl_macros.h:251:48: error: invalid conversion from
>> 'void*' to 'snd_ctl_elem_id_t* {aka snd_ctl_elem_id*}' [-fpermissive]
>
> I don't get it. Is it C++? But I thought the code is in extern "C"
> region?
Yes, it's C++. 'extern "C"' only declares the linkage convention. It
does not affect casting rules/conventions.
-gabriel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] salsa-lib: Fix error on jack compilation with salsa
2013-03-30 19:11 ` Gabriel M. Beddingfield
@ 2013-04-02 9:46 ` Takashi Iwai
2013-04-02 11:59 ` Mihail Zenkov
0 siblings, 1 reply; 6+ messages in thread
From: Takashi Iwai @ 2013-04-02 9:46 UTC (permalink / raw)
To: Gabriel M. Beddingfield; +Cc: alsa-devel, Mihail Zenkov
At Sat, 30 Mar 2013 12:11:27 -0700,
Gabriel M. Beddingfield wrote:
>
> On 03/20/2013 09:37 AM, Takashi Iwai wrote:
> > At Sun, 17 Mar 2013 15:13:00 +0000,
> > Mihail Zenkov wrote:
> >>
> >> Fix error on jack compilation with salsa:
> >> /usr/include/alsa/ctl_macros.h:251:48: error: invalid conversion from
> >> 'void*' to 'snd_ctl_elem_id_t* {aka snd_ctl_elem_id*}' [-fpermissive]
> >
> > I don't get it. Is it C++? But I thought the code is in extern "C"
> > region?
>
> Yes, it's C++. 'extern "C"' only declares the linkage convention. It
> does not affect casting rules/conventions.
Ah, I see.
I seem to have lost the original patch... Mihail, could you resend
it?
thanks,
Takashi
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] salsa-lib: Fix error on jack compilation with salsa
2013-04-02 9:46 ` Takashi Iwai
@ 2013-04-02 11:59 ` Mihail Zenkov
2013-04-03 9:35 ` Takashi Iwai
0 siblings, 1 reply; 6+ messages in thread
From: Mihail Zenkov @ 2013-04-02 11:59 UTC (permalink / raw)
To: Takashi Iwai; +Cc: alsa-devel, Gabriel M. Beddingfield
Fix error on jack compilation with salsa:
/usr/include/alsa/ctl_macros.h:251:48: error: invalid conversion from
'void*' to 'snd_ctl_elem_id_t* {aka snd_ctl_elem_id*}' [-fpermissive]
--- salsa-lib-a55ce0c348cd16e7853dae11e8e0e1b5a101d884/src/ctl_macros.h
+++ salsa-lib-a55ce0c348cd16e7853dae11e8e0e1b5a101d884-1/src/ctl_macros.h
@@ -248,7 +248,7 @@
unsigned int entries)
{
free(obj->pids);
- obj->pids = calloc(entries, sizeof(*obj->pids));
+ obj->pids = (snd_ctl_elem_id_t*)calloc(entries, sizeof(*obj->pids));
if (!obj->pids) {
obj->space = 0;
return -ENOMEM;
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] salsa-lib: Fix error on jack compilation with salsa
2013-04-02 11:59 ` Mihail Zenkov
@ 2013-04-03 9:35 ` Takashi Iwai
0 siblings, 0 replies; 6+ messages in thread
From: Takashi Iwai @ 2013-04-03 9:35 UTC (permalink / raw)
To: Mihail Zenkov; +Cc: alsa-devel, Gabriel M. Beddingfield
At Tue, 2 Apr 2013 11:59:20 +0000,
Mihail Zenkov wrote:
>
> Fix error on jack compilation with salsa:
> /usr/include/alsa/ctl_macros.h:251:48: error: invalid conversion from
> 'void*' to 'snd_ctl_elem_id_t* {aka snd_ctl_elem_id*}' [-fpermissive]
Thanks, applied.
Takashi
>
> --- salsa-lib-a55ce0c348cd16e7853dae11e8e0e1b5a101d884/src/ctl_macros.h
> +++ salsa-lib-a55ce0c348cd16e7853dae11e8e0e1b5a101d884-1/src/ctl_macros.h
> @@ -248,7 +248,7 @@
> unsigned int entries)
> {
> free(obj->pids);
> - obj->pids = calloc(entries, sizeof(*obj->pids));
> + obj->pids = (snd_ctl_elem_id_t*)calloc(entries, sizeof(*obj->pids));
> if (!obj->pids) {
> obj->space = 0;
> return -ENOMEM;
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-04-03 9:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-17 15:13 [PATCH] salsa-lib: Fix error on jack compilation with salsa Mihail Zenkov
2013-03-20 16:37 ` Takashi Iwai
2013-03-30 19:11 ` Gabriel M. Beddingfield
2013-04-02 9:46 ` Takashi Iwai
2013-04-02 11:59 ` Mihail Zenkov
2013-04-03 9:35 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.