[PATCH] cgroup: remove unused parameter in cgroup_task_migrate().

[PATCH] cgroup: remove unused parameter in cgroup_task_migrate().

[Kevin Wilson]

This patch removes unused parameter from cgroup_task_migrate().

Signed-off-by: Kevin Wilson <wkevils-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 kernel/cgroup.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index a32f943..33fd0b4 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -1900,7 +1900,7 @@ EXPORT_SYMBOL_GPL(cgroup_taskset_size);
  *
  * Must be called with cgroup_mutex and threadgroup locked.
  */
-static void cgroup_task_migrate(struct cgroup *cgrp, struct cgroup *oldcgrp,
+static void cgroup_task_migrate(struct cgroup *oldcgrp,
 				struct task_struct *tsk, struct css_set *newcg)
 {
 	struct css_set *oldcg;
@@ -1983,7 +1983,7 @@ int cgroup_attach_task(struct cgroup *cgrp, struct task_struct *tsk)
 		goto out;
 	}
 
-	cgroup_task_migrate(cgrp, oldcgrp, tsk, newcg);
+	cgroup_task_migrate(oldcgrp, tsk, newcg);
 
 	for_each_subsys(root, ss) {
 		if (ss->attach)
@@ -2143,7 +2143,7 @@ static int cgroup_attach_proc(struct cgroup *cgrp, struct task_struct *leader)
 	 */
 	for (i = 0; i < group_size; i++) {
 		tc = flex_array_get(group, i);
-		cgroup_task_migrate(cgrp, tc->cgrp, tc->task, tc->cg);
+		cgroup_task_migrate(tc->cgrp, tc->task, tc->cg);
 	}
 	/* nothing is sensitive to fork() after this point. */
 
-- 
1.8.1.4

Re: [PATCH] cgroup: remove unused parameter in cgroup_task_migrate().

[Li Zefan]

On 2013/4/1 5:08, Kevin Wilson wrote:
> This patch removes unused parameter from cgroup_task_migrate().
> 
> Signed-off-by: Kevin Wilson <wkevils-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Acked-by: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>

But you have to rebase this patch against Tejun's cgroup tree, as this
patch conflicts with "cgroup: consolidate cgroup_attach_task() and cgroup_attach_proc()"

http://git.kernel.org/cgit/linux/kernel/git/tj/cgroup.git/commit/?h=for-next&id=081aa458c38ba576bdd4265fc807fa95b48b9e79