lspci -k is broken with depmod from kmod since it doesn't generate modules.pcimap anymore

lspci -k is broken with depmod from kmod since it doesn't generate modules.pcimap anymore

[Samuli Suominen]

The depmod from kmod no longer generates file modules.pcimap, and lspci 
-k relies on that as noted at:

https://bugs.gentoo.org/show_bug.cgi?id=462982

null pciutils-3.1.10 # grep -r modules.*map *
ls-kernel.c:      sprintf(name, "/lib/modules/%s/modules.pcimap", 
uts.release);
lspci.c:char *opt_pcimap;			/* Override path to Linux modules.pcimap */
lspci.c:"-p <file>\tLook up kernel modules in a given file instead of 
default modules.pcimap\n"
lspci.man:.RI /lib/modules/ kernel_version /modules.pcimap.

Since this is not fixed in git, I figured it's time to let people know 
of it here

Thanks for looking into it,
Samuli

Re: lspci -k is broken with depmod from kmod since it doesn't generate modules.pcimap anymore

[Bjorn Helgaas]

On Tue, Mar 26, 2013 at 3:31 PM, Samuli Suominen <ssuominen@gentoo.org> wrote:
> The depmod from kmod no longer generates file modules.pcimap, and lspci -k
> relies on that as noted at:
>
> https://bugs.gentoo.org/show_bug.cgi?id=462982
>
> null pciutils-3.1.10 # grep -r modules.*map *
> ls-kernel.c:      sprintf(name, "/lib/modules/%s/modules.pcimap",
> uts.release);
> lspci.c:char *opt_pcimap;                       /* Override path to Linux
> modules.pcimap */
> lspci.c:"-p <file>\tLook up kernel modules in a given file instead of
> default modules.pcimap\n"
> lspci.man:.RI /lib/modules/ kernel_version /modules.pcimap.

I don't think this is a kernel problem, and I don't know where to
point you.  Maybe Lucas or Kay will know?

Re: lspci -k is broken with depmod from kmod since it doesn't generate modules.pcimap anymore

[Samuli Suominen]

On 27/03/13 00:35, Bjorn Helgaas wrote:
> On Tue, Mar 26, 2013 at 3:31 PM, Samuli Suominen <ssuominen@gentoo.org> wrote:
>> The depmod from kmod no longer generates file modules.pcimap, and lspci -k
>> relies on that as noted at:
>>
>> https://bugs.gentoo.org/show_bug.cgi?id=462982
>>
>> null pciutils-3.1.10 # grep -r modules.*map *
>> ls-kernel.c:      sprintf(name, "/lib/modules/%s/modules.pcimap",
>> uts.release);
>> lspci.c:char *opt_pcimap;                       /* Override path to Linux
>> modules.pcimap */
>> lspci.c:"-p <file>\tLook up kernel modules in a given file instead of
>> default modules.pcimap\n"
>> lspci.man:.RI /lib/modules/ kernel_version /modules.pcimap.
>
> I don't think this is a kernel problem, and I don't know where to
> point you.  Maybe Lucas or Kay will know?

This is the mailing list referred at pciutils homepage:

http://mj.ucw.cz/sw/pciutils/

"Feedback:

You can ask questions and report bugs on the linux-pci mailing list 
running on Vger"

Some bug tracking system would be nice.

Re: lspci -k is broken with depmod from kmod since it doesn't generate modules.pcimap anymore

[Bjorn Helgaas]

[+cc Martin]

On Tue, Mar 26, 2013 at 4:37 PM, Samuli Suominen <ssuominen@gentoo.org> wrote:
> On 27/03/13 00:35, Bjorn Helgaas wrote:
>>
>> On Tue, Mar 26, 2013 at 3:31 PM, Samuli Suominen <ssuominen@gentoo.org>
>> wrote:
>>>
>>> The depmod from kmod no longer generates file modules.pcimap, and lspci
>>> -k
>>> relies on that as noted at:
>>>
>>> https://bugs.gentoo.org/show_bug.cgi?id=462982
>>>
>>> null pciutils-3.1.10 # grep -r modules.*map *
>>> ls-kernel.c:      sprintf(name, "/lib/modules/%s/modules.pcimap",
>>> uts.release);
>>> lspci.c:char *opt_pcimap;                       /* Override path to Linux
>>> modules.pcimap */
>>> lspci.c:"-p <file>\tLook up kernel modules in a given file instead of
>>> default modules.pcimap\n"
>>> lspci.man:.RI /lib/modules/ kernel_version /modules.pcimap.
>>
>>
>> I don't think this is a kernel problem, and I don't know where to
>> point you.  Maybe Lucas or Kay will know?
>
>
> This is the mailing list referred at pciutils homepage:
>
> http://mj.ucw.cz/sw/pciutils/
>
> "Feedback:
>
> You can ask questions and report bugs on the linux-pci mailing list running
> on Vger"
>
> Some bug tracking system would be nice.

Don't worry, we'll figure out where this should go.  It's just that I
don't know off the top of my head.  If it's a pciutils problem, Martin
will surely know.

Re: lspci -k is broken with depmod from kmod since it doesn't generate modules.pcimap anymore

[Lucas De Marchi]

On Tue, Mar 26, 2013 at 7:35 PM, Bjorn Helgaas <bhelgaas@google.com> wrote:
> On Tue, Mar 26, 2013 at 3:31 PM, Samuli Suominen <ssuominen@gentoo.org> wrote:
>> The depmod from kmod no longer generates file modules.pcimap, and lspci -k
>> relies on that as noted at:
>>
>> https://bugs.gentoo.org/show_bug.cgi?id=462982
>>
>> null pciutils-3.1.10 # grep -r modules.*map *
>> ls-kernel.c:      sprintf(name, "/lib/modules/%s/modules.pcimap",
>> uts.release);
>> lspci.c:char *opt_pcimap;                       /* Override path to Linux
>> modules.pcimap */
>> lspci.c:"-p <file>\tLook up kernel modules in a given file instead of
>> default modules.pcimap\n"
>> lspci.man:.RI /lib/modules/ kernel_version /modules.pcimap.
>
> I don't think this is a kernel problem, and I don't know where to
> point you.  Maybe Lucas or Kay will know?

I don't see why modules.{pci,usb}map are needed here. Could we change
lspci to do the equivalent to the following instead (either by calling
modprobe or using libkmod)?

for i in /sys/bus/pci/*/modalias;
do
    modprobe -R  `cat $i`
done

Kay, am I missing anything?

Lucas De Marchi

Re: lspci -k is broken with depmod from kmod since it doesn't generate modules.pcimap anymore

[Kay Sievers]

On Wed, Mar 27, 2013 at 4:11 PM, Lucas De Marchi
<lucas.demarchi@profusion.mobi> wrote:
> On Tue, Mar 26, 2013 at 7:35 PM, Bjorn Helgaas <bhelgaas@google.com> wrote:
>> On Tue, Mar 26, 2013 at 3:31 PM, Samuli Suominen <ssuominen@gentoo.org> wrote:
>>> The depmod from kmod no longer generates file modules.pcimap, and lspci -k
>>> relies on that as noted at:
>>>
>>> https://bugs.gentoo.org/show_bug.cgi?id=462982
>>>
>>> null pciutils-3.1.10 # grep -r modules.*map *
>>> ls-kernel.c:      sprintf(name, "/lib/modules/%s/modules.pcimap",
>>> uts.release);
>>> lspci.c:char *opt_pcimap;                       /* Override path to Linux
>>> modules.pcimap */
>>> lspci.c:"-p <file>\tLook up kernel modules in a given file instead of
>>> default modules.pcimap\n"
>>> lspci.man:.RI /lib/modules/ kernel_version /modules.pcimap.
>>
>> I don't think this is a kernel problem, and I don't know where to
>> point you.  Maybe Lucas or Kay will know?
>
> I don't see why modules.{pci,usb}map are needed here. Could we change
> lspci to do the equivalent to the following instead (either by calling
> modprobe or using libkmod)?
>
> for i in /sys/bus/pci/*/modalias;
> do
>     modprobe -R  `cat $i`
> done
>
> Kay, am I missing anything?

Yes, that needs to be converted to use modaliases, if that feature is
desired in lspci. The information is available in /sys and modprobe
can be used to resolve that to module names. The old hotplug maps
files are gone.

Kay

Re: lspci -k is broken with depmod from kmod since it doesn't generate modules.pcimap anymore

[Martin Mares]

Hello!

> Yes, that needs to be converted to use modaliases, if that feature is
> desired in lspci. The information is available in /sys and modprobe
> can be used to resolve that to module names. The old hotplug maps
> files are gone.

I'm looking into that. Expect a pciutils patch soon.

				Have a nice fortnight
-- 
Martin `MJ' Mares                          <mj@ucw.cz>   http://mj.ucw.cz/
Faculty of Math and Physics, Charles University, Prague, Czech Rep., Earth
The computer is mightier than the pen, the sword, and usually, the programmer.

Re: lspci -k is broken with depmod from kmod since it doesn't generate modules.pcimap anymore

[Martin Mares]

Hello!

> I'm looking into that. Expect a pciutils patch soon.

Please check the current version in git://git.kernel.org/pub/scm/utils/pciutils/pciutils.git

Looking up modules using libkmod should be fully supported.

				Have a nice fortnight
-- 
Martin `MJ' Mares                          <mj@ucw.cz>   http://mj.ucw.cz/
Faculty of Math and Physics, Charles University, Prague, Czech Rep., Earth
Who is General Failure and why is he reading my disk?

Re: lspci -k is broken with depmod from kmod since it doesn't generate modules.pcimap anymore

[Samuli Suominen]

On 01/04/13 16:46, Martin Mares wrote:
> Hello!
>
>> I'm looking into that. Expect a pciutils patch soon.
>
> Please check the current version in git://git.kernel.org/pub/scm/utils/pciutils/pciutils.git
>
> Looking up modules using libkmod should be fully supported.
>
> 				Have a nice fortnight
>

I spotted two possible problems with the commit

First, $PKG_CONFIG is not respected and call to pkg-config is hardcoded, 
this is likely to break cross-compiling

Since kmod is optional even in systemd source tree, and module loading 
is optional in the kernel, some embedded Linux users likely wants to 
enable/disable libkmod at will, for this there should be a ./configure 
flag of some sort

Thanks for your work!

- Samuli

Re: lspci -k is broken with depmod from kmod since it doesn't generate modules.pcimap anymore

[Martin Mares]

Hello!

> First, $PKG_CONFIG is not respected and call to pkg-config is
> hardcoded, this is likely to break cross-compiling

It's respected now.

> Since kmod is optional even in systemd source tree, and module
> loading is optional in the kernel, some embedded Linux users likely
> wants to enable/disable libkmod at will, for this there should be a
> ./configure flag of some sort

Just use "make LIBKMOD=no".

				Have a nice fortnight
-- 
Martin `MJ' Mares                          <mj@ucw.cz>   http://mj.ucw.cz/
Faculty of Math and Physics, Charles University, Prague, Czech Rep., Earth
A: No.   Q: Should I include quotations after my reply?