* [PATCH v2 1/2] ALSA: hda - bug fix on return value when getting HDMI ELD info
@ 2013-03-28 9:20 mengdong.lin
2013-04-02 6:30 ` David Henningsson
2013-04-02 9:57 ` Takashi Iwai
0 siblings, 2 replies; 3+ messages in thread
From: mengdong.lin @ 2013-03-28 9:20 UTC (permalink / raw)
To: alsa-devel, tiwai; +Cc: Mengdong Lin
From: Mengdong Lin <mengdong.lin@intel.com>
In function snd_hdmi_get_eld(), the variable 'ret' should be initialized to 0.
Otherwise it will be returned uninitialized as non-zero after ELD info is got
successfully. Thus hdmi_present_sense() will always assume ELD info is invalid
by mistake, and /proc file system cannot show the proper ELD info.
Signed-off-by: Mengdong Lin <mengdong.lin@intel.com>
diff --git a/sound/pci/hda/hda_eld.c b/sound/pci/hda/hda_eld.c
index 7dd8463..d0d7ac1 100644
--- a/sound/pci/hda/hda_eld.c
+++ b/sound/pci/hda/hda_eld.c
@@ -320,7 +320,7 @@ int snd_hdmi_get_eld(struct hda_codec *codec, hda_nid_t nid,
unsigned char *buf, int *eld_size)
{
int i;
- int ret;
+ int ret = 0;
int size;
/*
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/2] ALSA: hda - bug fix on return value when getting HDMI ELD info
2013-03-28 9:20 [PATCH v2 1/2] ALSA: hda - bug fix on return value when getting HDMI ELD info mengdong.lin
@ 2013-04-02 6:30 ` David Henningsson
2013-04-02 9:57 ` Takashi Iwai
1 sibling, 0 replies; 3+ messages in thread
From: David Henningsson @ 2013-04-02 6:30 UTC (permalink / raw)
To: mengdong.lin; +Cc: tiwai, alsa-devel
On 03/28/2013 10:20 AM, mengdong.lin@intel.com wrote:
> From: Mengdong Lin <mengdong.lin@intel.com>
>
> In function snd_hdmi_get_eld(), the variable 'ret' should be initialized to 0.
> Otherwise it will be returned uninitialized as non-zero after ELD info is got
> successfully. Thus hdmi_present_sense() will always assume ELD info is invalid
> by mistake, and /proc file system cannot show the proper ELD info.
>
> Signed-off-by: Mengdong Lin <mengdong.lin@intel.com>
Cc: stable@vger.kernel.org
Acked-by: David Henningsson <david.henningsson@canonical.com>
>
> diff --git a/sound/pci/hda/hda_eld.c b/sound/pci/hda/hda_eld.c
> index 7dd8463..d0d7ac1 100644
> --- a/sound/pci/hda/hda_eld.c
> +++ b/sound/pci/hda/hda_eld.c
> @@ -320,7 +320,7 @@ int snd_hdmi_get_eld(struct hda_codec *codec, hda_nid_t nid,
> unsigned char *buf, int *eld_size)
> {
> int i;
> - int ret;
> + int ret = 0;
> int size;
>
> /*
>
--
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/2] ALSA: hda - bug fix on return value when getting HDMI ELD info
2013-03-28 9:20 [PATCH v2 1/2] ALSA: hda - bug fix on return value when getting HDMI ELD info mengdong.lin
2013-04-02 6:30 ` David Henningsson
@ 2013-04-02 9:57 ` Takashi Iwai
1 sibling, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2013-04-02 9:57 UTC (permalink / raw)
To: mengdong.lin; +Cc: alsa-devel
At Thu, 28 Mar 2013 05:20:22 -0400,
mengdong.lin@intel.com wrote:
>
> From: Mengdong Lin <mengdong.lin@intel.com>
>
> In function snd_hdmi_get_eld(), the variable 'ret' should be initialized to 0.
> Otherwise it will be returned uninitialized as non-zero after ELD info is got
> successfully. Thus hdmi_present_sense() will always assume ELD info is invalid
> by mistake, and /proc file system cannot show the proper ELD info.
>
> Signed-off-by: Mengdong Lin <mengdong.lin@intel.com>
Thanks, applied.
Takashi
>
> diff --git a/sound/pci/hda/hda_eld.c b/sound/pci/hda/hda_eld.c
> index 7dd8463..d0d7ac1 100644
> --- a/sound/pci/hda/hda_eld.c
> +++ b/sound/pci/hda/hda_eld.c
> @@ -320,7 +320,7 @@ int snd_hdmi_get_eld(struct hda_codec *codec, hda_nid_t nid,
> unsigned char *buf, int *eld_size)
> {
> int i;
> - int ret;
> + int ret = 0;
> int size;
>
> /*
> --
> 1.7.10.4
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-04-02 9:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-28 9:20 [PATCH v2 1/2] ALSA: hda - bug fix on return value when getting HDMI ELD info mengdong.lin
2013-04-02 6:30 ` David Henningsson
2013-04-02 9:57 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.