From: Glauber Costa <glommer@parallels.com>
To: Li Zefan <lizefan@huawei.com>
Cc: Michal Hocko <mhocko@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
LKML <linux-kernel@vger.kernel.org>,
Cgroups <cgroups@vger.kernel.org>,
linux-mm@kvack.org
Subject: Re: [PATCH] memcg: don't do cleanup manually if mem_cgroup_css_online() fails
Date: Tue, 2 Apr 2013 12:43:46 +0400 [thread overview]
Message-ID: <515A9A42.3050908@parallels.com> (raw)
In-Reply-To: <515A8A40.6020406@huawei.com>
On 04/02/2013 11:35 AM, Li Zefan wrote:
> If memcg_init_kmem() returns -errno when a memcg is being created,
> mem_cgroup_css_online() will decrement memcg and its parent's refcnt,
> (but strangely there's no mem_cgroup_put() for mem_cgroup_get() called
> in memcg_propagate_kmem()).
>
> But then cgroup core will call mem_cgroup_css_free() to do cleanup...
>
Not a kmemcg bug, but a real bug. Tested by forcing an ENOMEM condition
to happen manually, and Li patch fixes it.
> Signed-off-by: Li Zefan <lizefan@huawei.com>
Acked-by: Glauber Costa <glommer@parallels.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Glauber Costa <glommer@parallels.com>
To: Li Zefan <lizefan@huawei.com>
Cc: Michal Hocko <mhocko@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
LKML <linux-kernel@vger.kernel.org>,
Cgroups <cgroups@vger.kernel.org>, <linux-mm@kvack.org>
Subject: Re: [PATCH] memcg: don't do cleanup manually if mem_cgroup_css_online() fails
Date: Tue, 2 Apr 2013 12:43:46 +0400 [thread overview]
Message-ID: <515A9A42.3050908@parallels.com> (raw)
In-Reply-To: <515A8A40.6020406@huawei.com>
On 04/02/2013 11:35 AM, Li Zefan wrote:
> If memcg_init_kmem() returns -errno when a memcg is being created,
> mem_cgroup_css_online() will decrement memcg and its parent's refcnt,
> (but strangely there's no mem_cgroup_put() for mem_cgroup_get() called
> in memcg_propagate_kmem()).
>
> But then cgroup core will call mem_cgroup_css_free() to do cleanup...
>
Not a kmemcg bug, but a real bug. Tested by forcing an ENOMEM condition
to happen manually, and Li patch fixes it.
> Signed-off-by: Li Zefan <lizefan@huawei.com>
Acked-by: Glauber Costa <glommer@parallels.com>
next prev parent reply other threads:[~2013-04-02 8:43 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-02 7:35 [PATCH] memcg: don't do cleanup manually if mem_cgroup_css_online() fails Li Zefan
2013-04-02 7:35 ` Li Zefan
2013-04-02 8:03 ` Li Zefan
2013-04-02 8:03 ` Li Zefan
2013-04-02 8:03 ` Li Zefan
2013-04-02 8:07 ` Glauber Costa
2013-04-02 8:07 ` Glauber Costa
2013-04-02 8:34 ` Li Zefan
2013-04-02 8:34 ` Li Zefan
2013-04-02 8:42 ` Glauber Costa
2013-04-02 8:42 ` Glauber Costa
2013-04-02 8:43 ` Glauber Costa [this message]
2013-04-02 8:43 ` Glauber Costa
[not found] ` <515A8A40.6020406-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-04-02 12:16 ` Michal Hocko
2013-04-02 12:16 ` Michal Hocko
2013-04-02 12:16 ` Michal Hocko
2013-04-02 12:22 ` Glauber Costa
2013-04-02 12:22 ` Glauber Costa
[not found] ` <515ACD7F.3070009-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2013-04-02 13:32 ` Michal Hocko
2013-04-02 13:32 ` Michal Hocko
2013-04-02 13:32 ` Michal Hocko
2013-04-02 13:36 ` Glauber Costa
2013-04-02 13:36 ` Glauber Costa
[not found] ` <20130402133227.GM24345-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2013-04-03 3:43 ` Li Zefan
2013-04-03 3:43 ` Li Zefan
2013-04-03 3:43 ` Li Zefan
2013-04-02 14:16 ` Michal Hocko
2013-04-02 14:16 ` Michal Hocko
[not found] ` <20130402141646.GQ24345-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2013-04-02 14:20 ` Glauber Costa
2013-04-02 14:20 ` Glauber Costa
2013-04-02 14:20 ` Glauber Costa
2013-04-02 14:28 ` Michal Hocko
2013-04-02 14:28 ` Michal Hocko
[not found] ` <20130402142825.GA32520-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2013-04-02 14:33 ` Glauber Costa
2013-04-02 14:33 ` Glauber Costa
2013-04-02 14:33 ` Glauber Costa
[not found] ` <515AEC3A.2030401-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2013-04-02 15:04 ` [PATCH -v2] " Michal Hocko
2013-04-02 15:04 ` Michal Hocko
2013-04-02 15:04 ` Michal Hocko
[not found] ` <20130402150422.GB32520-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2013-04-03 3:49 ` Li Zefan
2013-04-03 3:49 ` Li Zefan
2013-04-03 3:49 ` Li Zefan
[not found] ` <515BA6C9.2000704-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-04-03 7:43 ` Michal Hocko
2013-04-03 7:43 ` Michal Hocko
2013-04-03 7:43 ` Michal Hocko
2013-04-03 7:49 ` Li Zefan
2013-04-03 7:49 ` Li Zefan
2013-04-03 8:18 ` Michal Hocko
2013-04-03 8:18 ` Michal Hocko
2013-04-03 8:30 ` Glauber Costa
2013-04-03 8:30 ` Glauber Costa
2013-04-03 8:30 ` Glauber Costa
[not found] ` <20130403081843.GC14384-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2013-04-03 8:37 ` Li Zefan
2013-04-03 8:37 ` Li Zefan
2013-04-03 8:37 ` Li Zefan
2013-04-03 8:50 ` Michal Hocko
2013-04-03 8:50 ` Michal Hocko
2013-04-03 8:53 ` [PATCH 1/2] Revert "memcg: avoid dangling reference count in creation failure." Michal Hocko
2013-04-03 8:53 ` Michal Hocko
2013-04-03 8:53 ` [PATCH 2/2] memcg, kmem: clean up reference count handling on the error path Michal Hocko
2013-04-03 8:53 ` Michal Hocko
[not found] ` <1364979234-16427-2-git-send-email-mhocko-AlSwsSmVLrQ@public.gmane.org>
2013-04-03 9:48 ` Michal Hocko
2013-04-03 9:48 ` Michal Hocko
2013-04-03 9:48 ` Michal Hocko
2013-04-03 8:08 ` [PATCH -v2] memcg: don't do cleanup manually if mem_cgroup_css_online() fails Glauber Costa
2013-04-03 8:08 ` Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515A9A42.3050908@parallels.com \
--to=glommer@parallels.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan@huawei.com \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.