All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Andrei Epure <epure.andrei@gmail.com>
Cc: FlorianSchandinat@gmx.de, archit@ti.com,
	linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] video: omap2: dss: use PTR_RET function
Date: Tue, 02 Apr 2013 10:13:36 +0000	[thread overview]
Message-ID: <515AAF50.9010504@ti.com> (raw)
In-Reply-To: <1364416537-25367-1-git-send-email-epure.andrei@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 975 bytes --]

Hi,

On 2013-03-27 22:35, Andrei Epure wrote:
> Use PTR_RET function instead of IS_ERR + PTR_ERR.
> Patch found using coccinelle.
> 
> Signed-off-by: Andrei Epure <epure.andrei@gmail.com>
> ---
>  drivers/video/omap2/dss/core.c |    5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/video/omap2/dss/core.c b/drivers/video/omap2/dss/core.c
> index f8779d4..60cc6fe 100644
> --- a/drivers/video/omap2/dss/core.c
> +++ b/drivers/video/omap2/dss/core.c
> @@ -181,10 +181,7 @@ int dss_debugfs_create_file(const char *name, void (*write)(struct seq_file *))
>  	d = debugfs_create_file(name, S_IRUGO, dss_debugfs_dir,
>  			write, &dss_debug_fops);
>  
> -	if (IS_ERR(d))
> -		return PTR_ERR(d);
> -
> -	return 0;
> +	return PTR_RET(d);
>  }
>  #else /* CONFIG_OMAP2_DSS_DEBUGFS */
>  static inline int dss_initialize_debugfs(void)
> 

There's an identical patch from Alexandru Gheorghiu already queued.

 Tomi



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 899 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Andrei Epure <epure.andrei@gmail.com>
Cc: FlorianSchandinat@gmx.de, archit@ti.com,
	linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] video: omap2: dss: use PTR_RET function
Date: Tue, 2 Apr 2013 13:13:36 +0300	[thread overview]
Message-ID: <515AAF50.9010504@ti.com> (raw)
In-Reply-To: <1364416537-25367-1-git-send-email-epure.andrei@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 975 bytes --]

Hi,

On 2013-03-27 22:35, Andrei Epure wrote:
> Use PTR_RET function instead of IS_ERR + PTR_ERR.
> Patch found using coccinelle.
> 
> Signed-off-by: Andrei Epure <epure.andrei@gmail.com>
> ---
>  drivers/video/omap2/dss/core.c |    5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/video/omap2/dss/core.c b/drivers/video/omap2/dss/core.c
> index f8779d4..60cc6fe 100644
> --- a/drivers/video/omap2/dss/core.c
> +++ b/drivers/video/omap2/dss/core.c
> @@ -181,10 +181,7 @@ int dss_debugfs_create_file(const char *name, void (*write)(struct seq_file *))
>  	d = debugfs_create_file(name, S_IRUGO, dss_debugfs_dir,
>  			write, &dss_debug_fops);
>  
> -	if (IS_ERR(d))
> -		return PTR_ERR(d);
> -
> -	return 0;
> +	return PTR_RET(d);
>  }
>  #else /* CONFIG_OMAP2_DSS_DEBUGFS */
>  static inline int dss_initialize_debugfs(void)
> 

There's an identical patch from Alexandru Gheorghiu already queued.

 Tomi



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 899 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Andrei Epure <epure.andrei@gmail.com>
Cc: <FlorianSchandinat@gmx.de>, <archit@ti.com>,
	<linux-omap@vger.kernel.org>, <linux-fbdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] video: omap2: dss: use PTR_RET function
Date: Tue, 2 Apr 2013 13:13:36 +0300	[thread overview]
Message-ID: <515AAF50.9010504@ti.com> (raw)
In-Reply-To: <1364416537-25367-1-git-send-email-epure.andrei@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 975 bytes --]

Hi,

On 2013-03-27 22:35, Andrei Epure wrote:
> Use PTR_RET function instead of IS_ERR + PTR_ERR.
> Patch found using coccinelle.
> 
> Signed-off-by: Andrei Epure <epure.andrei@gmail.com>
> ---
>  drivers/video/omap2/dss/core.c |    5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/video/omap2/dss/core.c b/drivers/video/omap2/dss/core.c
> index f8779d4..60cc6fe 100644
> --- a/drivers/video/omap2/dss/core.c
> +++ b/drivers/video/omap2/dss/core.c
> @@ -181,10 +181,7 @@ int dss_debugfs_create_file(const char *name, void (*write)(struct seq_file *))
>  	d = debugfs_create_file(name, S_IRUGO, dss_debugfs_dir,
>  			write, &dss_debug_fops);
>  
> -	if (IS_ERR(d))
> -		return PTR_ERR(d);
> -
> -	return 0;
> +	return PTR_RET(d);
>  }
>  #else /* CONFIG_OMAP2_DSS_DEBUGFS */
>  static inline int dss_initialize_debugfs(void)
> 

There's an identical patch from Alexandru Gheorghiu already queued.

 Tomi



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 899 bytes --]

  reply	other threads:[~2013-04-02 10:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-27 20:35 [PATCH] video: omap2: dss: use PTR_RET function Andrei Epure
2013-03-27 20:35 ` Andrei Epure
2013-04-02 10:13 ` Tomi Valkeinen [this message]
2013-04-02 10:13   ` Tomi Valkeinen
2013-04-02 10:13   ` Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=515AAF50.9010504@ti.com \
    --to=tomi.valkeinen@ti.com \
    --cc=FlorianSchandinat@gmx.de \
    --cc=archit@ti.com \
    --cc=epure.andrei@gmail.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.