[PATCH] V4L: Remove incorrect EXPORT_SYMBOL() usage at v4l2-of.c

[PATCH] V4L: Remove incorrect EXPORT_SYMBOL() usage at v4l2-of.c

[Sylwester Nawrocki]

v4l2_of_parse_parallel_bus() function is now static and
EXPORT_SYMBOL() doesn't apply to it any more. Drop this
meaningless statement, which was supposed to be done in
the original merged patch.

While at it, edit the copyright notice so it is sorted in
both the v4l2-of.c and v4l2-of.h file in newest entries
on top order, and state clearly I'm just the author of
parts of the code, not the copyright owner.

Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
 drivers/media/v4l2-core/v4l2-of.c |    3 +--
 include/media/v4l2-of.h           |    6 +++---
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/media/v4l2-core/v4l2-of.c b/drivers/media/v4l2-core/v4l2-of.c
index e38e210..aa59639 100644
--- a/drivers/media/v4l2-core/v4l2-of.c
+++ b/drivers/media/v4l2-core/v4l2-of.c
@@ -2,7 +2,7 @@
  * V4L2 OF binding parsing library
  *
  * Copyright (C) 2012 - 2013 Samsung Electronics Co., Ltd.
- * Sylwester Nawrocki <s.nawrocki@samsung.com>
+ * Author: Sylwester Nawrocki <s.nawrocki@samsung.com>
  *
  * Copyright (C) 2012 Renesas Electronics Corp.
  * Author: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
@@ -103,7 +103,6 @@ static void v4l2_of_parse_parallel_bus(const struct device_node *node,
 	bus->flags = flags;
 
 }
-EXPORT_SYMBOL(v4l2_of_parse_parallel_bus);
 
 /**
  * v4l2_of_parse_endpoint() - parse all endpoint node properties
diff --git a/include/media/v4l2-of.h b/include/media/v4l2-of.h
index 00f9147..3a8a841 100644
--- a/include/media/v4l2-of.h
+++ b/include/media/v4l2-of.h
@@ -1,12 +1,12 @@
 /*
  * V4L2 OF binding parsing library
  *
+ * Copyright (C) 2012 - 2013 Samsung Electronics Co., Ltd.
+ * Author: Sylwester Nawrocki <s.nawrocki@samsung.com>
+ *
  * Copyright (C) 2012 Renesas Electronics Corp.
  * Author: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
  *
- * Copyright (C) 2012 - 2013 Samsung Electronics Co., Ltd.
- * Sylwester Nawrocki <s.nawrocki@samsung.com>
- *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of version 2 of the GNU General Public License as
  * published by the Free Software Foundation.
-- 
1.7.9.5

Re: [PATCH] V4L: Remove incorrect EXPORT_SYMBOL() usage at v4l2-of.c

[Guennadi Liakhovetski]

Hi Sylwester

On Tue, 2 Apr 2013, Sylwester Nawrocki wrote:

> v4l2_of_parse_parallel_bus() function is now static and
> EXPORT_SYMBOL() doesn't apply to it any more. Drop this
> meaningless statement, which was supposed to be done in
> the original merged patch.
> 
> While at it, edit the copyright notice so it is sorted in
> both the v4l2-of.c and v4l2-of.h file in newest entries
> on top order, and state clearly I'm just the author of
> parts of the code, not the copyright owner.
> 
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>

This is not concerning the contents of this patch, but rather the form 
confuses me a bit - the two above Sob's: you are the author, and you're 
sending the patch to the list, but Kyungmin Park's Sob is the last in the 
list, which to me means that your patch went via his tree, but it's you 
who's sending it?... I think I saw this pattern in some other your patches 
too. What exactly does this mean?

Thanks
Guennadi

> ---
>  drivers/media/v4l2-core/v4l2-of.c |    3 +--
>  include/media/v4l2-of.h           |    6 +++---
>  2 files changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/media/v4l2-core/v4l2-of.c b/drivers/media/v4l2-core/v4l2-of.c
> index e38e210..aa59639 100644
> --- a/drivers/media/v4l2-core/v4l2-of.c
> +++ b/drivers/media/v4l2-core/v4l2-of.c
> @@ -2,7 +2,7 @@
>   * V4L2 OF binding parsing library
>   *
>   * Copyright (C) 2012 - 2013 Samsung Electronics Co., Ltd.
> - * Sylwester Nawrocki <s.nawrocki@samsung.com>
> + * Author: Sylwester Nawrocki <s.nawrocki@samsung.com>
>   *
>   * Copyright (C) 2012 Renesas Electronics Corp.
>   * Author: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> @@ -103,7 +103,6 @@ static void v4l2_of_parse_parallel_bus(const struct device_node *node,
>  	bus->flags = flags;
>  
>  }
> -EXPORT_SYMBOL(v4l2_of_parse_parallel_bus);
>  
>  /**
>   * v4l2_of_parse_endpoint() - parse all endpoint node properties
> diff --git a/include/media/v4l2-of.h b/include/media/v4l2-of.h
> index 00f9147..3a8a841 100644
> --- a/include/media/v4l2-of.h
> +++ b/include/media/v4l2-of.h
> @@ -1,12 +1,12 @@
>  /*
>   * V4L2 OF binding parsing library
>   *
> + * Copyright (C) 2012 - 2013 Samsung Electronics Co., Ltd.
> + * Author: Sylwester Nawrocki <s.nawrocki@samsung.com>
> + *
>   * Copyright (C) 2012 Renesas Electronics Corp.
>   * Author: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
>   *
> - * Copyright (C) 2012 - 2013 Samsung Electronics Co., Ltd.
> - * Sylwester Nawrocki <s.nawrocki@samsung.com>
> - *
>   * This program is free software; you can redistribute it and/or modify
>   * it under the terms of version 2 of the GNU General Public License as
>   * published by the Free Software Foundation.
> -- 
> 1.7.9.5
> 

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/

Re: [PATCH] V4L: Remove incorrect EXPORT_SYMBOL() usage at v4l2-of.c

[Sylwester Nawrocki]

Hi Guennadi,

On 04/02/2013 04:54 PM, Guennadi Liakhovetski wrote:
> On Tue, 2 Apr 2013, Sylwester Nawrocki wrote:
> 
>> > v4l2_of_parse_parallel_bus() function is now static and
>> > EXPORT_SYMBOL() doesn't apply to it any more. Drop this
>> > meaningless statement, which was supposed to be done in
>> > the original merged patch.
>> > 
>> > While at it, edit the copyright notice so it is sorted in
>> > both the v4l2-of.c and v4l2-of.h file in newest entries
>> > on top order, and state clearly I'm just the author of
>> > parts of the code, not the copyright owner.
>> > 
>> > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
>> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>
> This is not concerning the contents of this patch, but rather the form 
> confuses me a bit - the two above Sob's: you are the author, and you're 
> sending the patch to the list, but Kyungmin Park's Sob is the last in the 
> list, which to me means that your patch went via his tree, but it's you 
> who's sending it?... I think I saw this pattern in some other your patches 
> too. What exactly does this mean?

This means just that Kyungmin approves the patch submission as our manager
and the internal tree maintainer. He is not necessarily directly involved
in the development of a patch. As you probably noticed his Signed-off is
on patches from all our team members. I agree it is not immediately obvious
what's going on here. This has been discussed in the past few times. For
instance please refer to this thread:

http://www.spinics.net/lists/linux-usb/msg74981.html

--

Regards,
Sylwester

Re: [PATCH] V4L: Remove incorrect EXPORT_SYMBOL() usage at v4l2-of.c

[Guennadi Liakhovetski]

On Tue, 2 Apr 2013, Sylwester Nawrocki wrote:

> Hi Guennadi,
> 
> On 04/02/2013 04:54 PM, Guennadi Liakhovetski wrote:
> > On Tue, 2 Apr 2013, Sylwester Nawrocki wrote:
> > 
> >> > v4l2_of_parse_parallel_bus() function is now static and
> >> > EXPORT_SYMBOL() doesn't apply to it any more. Drop this
> >> > meaningless statement, which was supposed to be done in
> >> > the original merged patch.
> >> > 
> >> > While at it, edit the copyright notice so it is sorted in
> >> > both the v4l2-of.c and v4l2-of.h file in newest entries
> >> > on top order, and state clearly I'm just the author of
> >> > parts of the code, not the copyright owner.
> >> > 
> >> > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> >> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> >
> > This is not concerning the contents of this patch, but rather the form 
> > confuses me a bit - the two above Sob's: you are the author, and you're 
> > sending the patch to the list, but Kyungmin Park's Sob is the last in the 
> > list, which to me means that your patch went via his tree, but it's you 
> > who's sending it?... I think I saw this pattern in some other your patches 
> > too. What exactly does this mean?
> 
> This means just that Kyungmin approves the patch submission as our manager
> and the internal tree maintainer. He is not necessarily directly involved
> in the development of a patch. As you probably noticed his Signed-off is
> on patches from all our team members. I agree it is not immediately obvious
> what's going on here. This has been discussed in the past few times. For
> instance please refer to this thread:
> 
> http://www.spinics.net/lists/linux-usb/msg74981.html

Ok, thanks, I wasn't aware of this use of Sob.

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/