All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: Ilya Zykov <linux@izyk.ru>
Cc: lkml <linux-kernel@vger.kernel.org>,
	linux-serial@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Jiri Slaby <jslaby@suse.cz>,
	Peter Hurley <peter@hurleysoftware.com>
Subject: Re: n_tty_write() going into schedule but NOT coming out
Date: Wed, 3 Apr 2013 13:12:28 +0530	[thread overview]
Message-ID: <515BDD64.3010405@synopsys.com> (raw)
In-Reply-To: <515BC1AF.1070103@izyk.ru>

Hi Ilya

On 04/03/2013 11:14 AM, Ilya Zykov wrote:
> Please, try this patch maybe it can help localize your problem.
>
>  drivers/tty/n_tty.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c
> index 05e72be..28f15d0 100644
> --- a/drivers/tty/n_tty.c
> +++ b/drivers/tty/n_tty.c
> @@ -230,6 +230,7 @@ static void reset_buffer_flags(struct tty_struct *tty)
>  	ldata->canon_head = ldata->canon_data = ldata->erasing = 0;
>  	bitmap_zero(ldata->read_flags, N_TTY_BUF_SIZE);
>  	n_tty_set_room(tty);
> +	check_unthrottle(tty);
>  }
>  
>  /**

Thanks for the patch - but it didn't help at all - I see the same lockup.
I'm no tty expert so don't understand how this patch would help - care to elaborate ?

Thx,
-Vineet

WARNING: multiple messages have this Message-ID (diff)
From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: Ilya Zykov <linux@izyk.ru>
Cc: lkml <linux-kernel@vger.kernel.org>,
	<linux-serial@vger.kernel.org>, "Ingo Molnar" <mingo@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Jiri Slaby <jslaby@suse.cz>,
	Peter Hurley <peter@hurleysoftware.com>
Subject: Re: n_tty_write() going into schedule but NOT coming out
Date: Wed, 3 Apr 2013 13:12:28 +0530	[thread overview]
Message-ID: <515BDD64.3010405@synopsys.com> (raw)
In-Reply-To: <515BC1AF.1070103@izyk.ru>

Hi Ilya

On 04/03/2013 11:14 AM, Ilya Zykov wrote:
> Please, try this patch maybe it can help localize your problem.
>
>  drivers/tty/n_tty.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c
> index 05e72be..28f15d0 100644
> --- a/drivers/tty/n_tty.c
> +++ b/drivers/tty/n_tty.c
> @@ -230,6 +230,7 @@ static void reset_buffer_flags(struct tty_struct *tty)
>  	ldata->canon_head = ldata->canon_data = ldata->erasing = 0;
>  	bitmap_zero(ldata->read_flags, N_TTY_BUF_SIZE);
>  	n_tty_set_room(tty);
> +	check_unthrottle(tty);
>  }
>  
>  /**

Thanks for the patch - but it didn't help at all - I see the same lockup.
I'm no tty expert so don't understand how this patch would help - care to elaborate ?

Thx,
-Vineet

  reply	other threads:[~2013-04-03  7:43 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-30 12:35 n_tty_write() going into schedule but NOT coming out Vineet Gupta
2013-03-30 12:35 ` Vineet Gupta
2013-04-01 13:57 ` Vineet Gupta
2013-04-01 13:57   ` Vineet Gupta
2013-04-01 15:10   ` Peter Hurley
2013-04-02 11:09     ` Vineet Gupta
2013-04-02 11:09       ` Vineet Gupta
2013-04-02 13:26     ` Vineet Gupta
2013-04-02 13:26       ` Vineet Gupta
2013-04-02 13:38       ` Peter Hurley
2013-04-05 19:52       ` Peter Hurley
2013-04-06  9:32         ` Vineet Gupta
2013-04-06  9:32           ` Vineet Gupta
2013-04-03  5:44 ` Ilya Zykov
2013-04-03  7:42   ` Vineet Gupta [this message]
2013-04-03  7:42     ` Vineet Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=515BDD64.3010405@synopsys.com \
    --to=vineet.gupta1@synopsys.com \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux@izyk.ru \
    --cc=mingo@kernel.org \
    --cc=peter@hurleysoftware.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.