From: Phillip Susi <psusi@ubuntu.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: LKML <linux-kernel@vger.kernel.org>,
CAI Qian <caiqian@redhat.com>,
xfs@oss.sgi.com
Subject: Re: Loopback device hung [was Re: xfs deadlock on 3.9-rc5 running xfstests case #78]
Date: Wed, 03 Apr 2013 11:41:17 -0400 [thread overview]
Message-ID: <515C4D9D.10103@ubuntu.com> (raw)
In-Reply-To: <20130403114142.GP4667@kernel.dk>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 4/3/2013 7:41 AM, Jens Axboe wrote:
>> Thanks for testing! I don't particularly like this stuff in
>> loop, though. It's quite nasty and depends on other behaviour. It
>> would be prettier if we just had rescan_partitions() do the right
>> thing, and only drop partitions and not rescan if NO_PART_SCAN is
>> set.
>>
>> Ala the below, dropping the loop change and implementing that
>> change in the core code. Phillip, can you check whether this does
>> the right thing for your bug too?
>
> Phillip? I'm going to revert the loop change asap, so if you want
> this fixed for 3.10, it's about that time to test it out.
I have not tested it yet, but I am pretty sure it won't work. It
looks like the patch changes the BLKRRPART path to go ahead and remove
existing partitions when GENHD_FL_NO_PARTSCAN is set. loop doesn't
issue the BLKRRPART ioctl when !LO_FLAGS_PARTSCAN so this won't help.
I think loop needs to set GENHD_FL_NO_PARTSCAN and then issue the
ioctl regardless of the LO_FLAGS_PARTSCAN flag to get the partitions
to be removed. I will try to test tonight.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (MingW32)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQEcBAEBAgAGBQJRXE2dAAoJEJrBOlT6nu75PM0IAIxVmuHdxLPtdtUNPqkU2a1r
QanHb6F43qSbd7l37XlwYgzUlybVlntf1yvKGzh29g3QM0603sFqV1o+mbXd5LI3
b+I5QrQJh90Vou9oVSAxz1Ps/AlZvxVIDv8bRwNhpXcMmaj0EN5R+6pU5L7KU2BU
GFsvajssedFh3XnNskgkR3XlqevI7U7A8VqLRsswl7FJVu7R1s45xP/sQgBWgiUS
P5viykwhje4OTKmu0D7bFKrOVx6O3gK7IHzdOwwT9aWRxuxL+Y9yfBF9nx/xZXkc
I2G09w852KgYDVYUHgW3IfuRo4F+4Y7Mw0Klu4XX5OmEXhselIqhwwTmEKMvEns=
=OLri
-----END PGP SIGNATURE-----
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: Phillip Susi <psusi@ubuntu.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: CAI Qian <caiqian@redhat.com>, Dave Chinner <david@fromorbit.com>,
xfs@oss.sgi.com, LKML <linux-kernel@vger.kernel.org>
Subject: Re: Loopback device hung [was Re: xfs deadlock on 3.9-rc5 running xfstests case #78]
Date: Wed, 03 Apr 2013 11:41:17 -0400 [thread overview]
Message-ID: <515C4D9D.10103@ubuntu.com> (raw)
In-Reply-To: <20130403114142.GP4667@kernel.dk>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 4/3/2013 7:41 AM, Jens Axboe wrote:
>> Thanks for testing! I don't particularly like this stuff in
>> loop, though. It's quite nasty and depends on other behaviour. It
>> would be prettier if we just had rescan_partitions() do the right
>> thing, and only drop partitions and not rescan if NO_PART_SCAN is
>> set.
>>
>> Ala the below, dropping the loop change and implementing that
>> change in the core code. Phillip, can you check whether this does
>> the right thing for your bug too?
>
> Phillip? I'm going to revert the loop change asap, so if you want
> this fixed for 3.10, it's about that time to test it out.
I have not tested it yet, but I am pretty sure it won't work. It
looks like the patch changes the BLKRRPART path to go ahead and remove
existing partitions when GENHD_FL_NO_PARTSCAN is set. loop doesn't
issue the BLKRRPART ioctl when !LO_FLAGS_PARTSCAN so this won't help.
I think loop needs to set GENHD_FL_NO_PARTSCAN and then issue the
ioctl regardless of the LO_FLAGS_PARTSCAN flag to get the partitions
to be removed. I will try to test tonight.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (MingW32)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQEcBAEBAgAGBQJRXE2dAAoJEJrBOlT6nu75PM0IAIxVmuHdxLPtdtUNPqkU2a1r
QanHb6F43qSbd7l37XlwYgzUlybVlntf1yvKGzh29g3QM0603sFqV1o+mbXd5LI3
b+I5QrQJh90Vou9oVSAxz1Ps/AlZvxVIDv8bRwNhpXcMmaj0EN5R+6pU5L7KU2BU
GFsvajssedFh3XnNskgkR3XlqevI7U7A8VqLRsswl7FJVu7R1s45xP/sQgBWgiUS
P5viykwhje4OTKmu0D7bFKrOVx6O3gK7IHzdOwwT9aWRxuxL+Y9yfBF9nx/xZXkc
I2G09w852KgYDVYUHgW3IfuRo4F+4Y7Mw0Klu4XX5OmEXhselIqhwwTmEKMvEns=
=OLri
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2013-04-03 15:41 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1462091996.435156.1364882416199.JavaMail.root@redhat.com>
2013-04-02 6:08 ` xfs deadlock on 3.9-rc5 running xfstests case #78 CAI Qian
2013-04-02 6:08 ` CAI Qian
2013-04-02 7:05 ` Loopback device hung [was Re: xfs deadlock on 3.9-rc5 running xfstests case #78] Dave Chinner
2013-04-02 7:05 ` Dave Chinner
2013-04-02 7:19 ` Jens Axboe
2013-04-02 7:19 ` Jens Axboe
2013-04-02 7:30 ` Jens Axboe
2013-04-02 7:30 ` Jens Axboe
2013-04-02 8:39 ` CAI Qian
2013-04-02 8:39 ` CAI Qian
2013-04-02 9:00 ` Jens Axboe
2013-04-02 9:00 ` Jens Axboe
2013-04-02 9:31 ` CAI Qian
2013-04-02 9:31 ` CAI Qian
2013-04-02 9:48 ` Jens Axboe
2013-04-02 9:48 ` Jens Axboe
2013-04-03 11:41 ` Jens Axboe
2013-04-03 11:41 ` Jens Axboe
2013-04-03 15:41 ` Phillip Susi [this message]
2013-04-03 15:41 ` Phillip Susi
2013-04-04 20:30 ` Phillip Susi
2013-04-04 20:30 ` Phillip Susi
2013-04-09 6:55 ` Dave Chinner
2013-04-09 6:55 ` Dave Chinner
2013-04-09 7:01 ` Jens Axboe
2013-04-09 7:01 ` Jens Axboe
2013-04-09 7:08 ` Dave Chinner
2013-04-09 7:08 ` Dave Chinner
2013-04-10 7:24 ` Jens Axboe
2013-04-10 7:24 ` Jens Axboe
2013-05-28 14:51 ` Phillip Susi
2013-05-28 14:51 ` Phillip Susi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515C4D9D.10103@ubuntu.com \
--to=psusi@ubuntu.com \
--cc=axboe@kernel.dk \
--cc=caiqian@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.