From: Kenneth Graunke <kenneth@whitecape.org>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Don't override PPGTT cacheability on HSW
Date: Wed, 03 Apr 2013 12:17:28 -0700 [thread overview]
Message-ID: <515C8048.1080503@whitecape.org> (raw)
In-Reply-To: <1365012390-6465-1-git-send-email-ben@bwidawsk.net>
On 04/03/2013 11:06 AM, Ben Widawsky wrote:
> Apparently these ECOCHK bits changed on HSW and the behavior is not what
> we want. I've not been able to find VLV definition specifically so I'll
> assume it's the same as IVB.
>
> (Only compile tested)
>
> Reported-by: Kenneth Graunke <kenneth@whitecape.org>
> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
The behavior isn't particularly bad, but the PTEs already take care of
this for us, so it doesn't do anything. That said, having random
override bits set for no purpose is bad...we should just let the PTEs do
their job.
Reviewed-and-tested-by: Kenneth Graunke <kenneth@whitecape.org>
Thanks Ben!
next prev parent reply other threads:[~2013-04-03 19:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 18:06 [PATCH] drm/i915: Don't override PPGTT cacheability on HSW Ben Widawsky
2013-04-03 19:17 ` Kenneth Graunke [this message]
2013-04-03 19:33 ` Daniel Vetter
2013-04-03 20:08 ` Daniel Vetter
2013-04-03 20:41 ` Ben Widawsky
2013-04-03 23:30 ` Ben Widawsky
2013-04-04 11:31 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515C8048.1080503@whitecape.org \
--to=kenneth@whitecape.org \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.