All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] dropbear: add vfork fix
@ 2013-04-02 22:29 Gustavo Zacarias
  2013-04-03 20:47 ` Peter Korsgaard
  0 siblings, 1 reply; 4+ messages in thread
From: Gustavo Zacarias @ 2013-04-02 22:29 UTC (permalink / raw)
  To: buildroot

Causes scp to fail badly.

Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
 package/dropbear/dropbear-fix-vfork-logic.patch | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 package/dropbear/dropbear-fix-vfork-logic.patch

diff --git a/package/dropbear/dropbear-fix-vfork-logic.patch b/package/dropbear/dropbear-fix-vfork-logic.patch
new file mode 100644
index 0000000..2706bc8
--- /dev/null
+++ b/package/dropbear/dropbear-fix-vfork-logic.patch
@@ -0,0 +1,21 @@
+
+# HG changeset patch
+# User Matt Johnston <matt@ucc.asn.au>
+# Date 1364743743 -28800
+# Node ID fedfb8ede1fdebad5d19df7bd4d452c3264d9545
+# Parent  f27058078d61a8c3a057530d3ddcd19bd5062569
+Fix incorrect logic for USE_VFORK and calling arg_setup()
+
+diff -r f27058078d61 -r fedfb8ede1fd scp.c
+--- a/scp.c	Sun Mar 31 23:15:35 2013 +0800
++++ b/scp.c	Sun Mar 31 23:29:03 2013 +0800
+@@ -230,7 +230,7 @@
+ 		close(pin[0]);
+ 		close(pout[1]);
+ 
+-#ifdef USE_VFORK
++#ifndef USE_VFORK
+ 		arg_setup(host, remuser, cmd);
+ #endif
+ 
+
-- 
1.8.1.5

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] dropbear: add vfork fix
  2013-04-02 22:29 [Buildroot] [PATCH] dropbear: add vfork fix Gustavo Zacarias
@ 2013-04-03 20:47 ` Peter Korsgaard
  2013-04-03 20:48   ` Gustavo Zacarias
  0 siblings, 1 reply; 4+ messages in thread
From: Peter Korsgaard @ 2013-04-03 20:47 UTC (permalink / raw)
  To: buildroot

>>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes:

 Gustavo> Causes scp to fail badly.

Committed, thanks.

Do we need the /dev/urandom write fix as well?

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] dropbear: add vfork fix
  2013-04-03 20:47 ` Peter Korsgaard
@ 2013-04-03 20:48   ` Gustavo Zacarias
  2013-04-03 21:00     ` Peter Korsgaard
  0 siblings, 1 reply; 4+ messages in thread
From: Gustavo Zacarias @ 2013-04-03 20:48 UTC (permalink / raw)
  To: buildroot

On 04/03/2013 05:47 PM, Peter Korsgaard wrote:

> Do we need the /dev/urandom write fix as well?

I don't think so, we default to 0666 for it in the device table...
Regards.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] dropbear: add vfork fix
  2013-04-03 20:48   ` Gustavo Zacarias
@ 2013-04-03 21:00     ` Peter Korsgaard
  0 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2013-04-03 21:00 UTC (permalink / raw)
  To: buildroot

>>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes:

 Gustavo> On 04/03/2013 05:47 PM, Peter Korsgaard wrote:
 >> Do we need the /dev/urandom write fix as well?

 Gustavo> I don't think so, we default to 0666 for it in the device table...
 Gustavo> Regards.

Ok, great.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2013-04-03 21:00 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-02 22:29 [Buildroot] [PATCH] dropbear: add vfork fix Gustavo Zacarias
2013-04-03 20:47 ` Peter Korsgaard
2013-04-03 20:48   ` Gustavo Zacarias
2013-04-03 21:00     ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.