All of lore.kernel.org
 help / color / mirror / Atom feed
From: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: "Nicholas A. Bellinger" <nab-IzHhD5pYlfBP7FQvKIMDCQ@public.gmane.org>
Cc: target-devel
	<target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-rdma <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-scsi <linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-kernel
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Alexander Nezhinsky
	<alexandern-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [RFC-v3 9/9] iser-target: Add iSCSI Extensions for RDMA (iSER) target driver
Date: Thu, 4 Apr 2013 12:20:54 +0300	[thread overview]
Message-ID: <515D45F6.9040903@mellanox.com> (raw)
In-Reply-To: <1365060256-21506-10-git-send-email-nab-IzHhD5pYlfBP7FQvKIMDCQ@public.gmane.org>

On 04/04/2013 10:24, Nicholas A. Bellinger wrote:
> +
> +void isert_cq_tx_callback(struct ib_cq *, void *);
> +void isert_cq_rx_callback(struct ib_cq *, void *);
> +void isert_free_rx_descriptors(struct isert_conn *);
any reason not to have these as static functions (same for isert_cq_rx_work)
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Or Gerlitz <ogerlitz@mellanox.com>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: target-devel <target-devel@vger.kernel.org>,
	linux-rdma <linux-rdma@vger.kernel.org>,
	linux-scsi <linux-scsi@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Roland Dreier <roland@kernel.org>,
	Alexander Nezhinsky <alexandern@mellanox.com>
Subject: Re: [RFC-v3 9/9] iser-target: Add iSCSI Extensions for RDMA (iSER) target driver
Date: Thu, 4 Apr 2013 12:20:54 +0300	[thread overview]
Message-ID: <515D45F6.9040903@mellanox.com> (raw)
In-Reply-To: <1365060256-21506-10-git-send-email-nab@linux-iscsi.org>

On 04/04/2013 10:24, Nicholas A. Bellinger wrote:
> +
> +void isert_cq_tx_callback(struct ib_cq *, void *);
> +void isert_cq_rx_callback(struct ib_cq *, void *);
> +void isert_free_rx_descriptors(struct isert_conn *);
any reason not to have these as static functions (same for isert_cq_rx_work)

  parent reply	other threads:[~2013-04-04  9:20 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-04  7:24 [RFC-v3 0/9] Add support for iSCSI Extensions for RDMA (ISER) target mode Nicholas A. Bellinger
2013-04-04  7:24 ` [RFC-v3 1/9] target: Add export of target_get_sess_cmd symbol Nicholas A. Bellinger
2013-04-04  7:24 ` [RFC-v3 2/9] iscsi-target: Add iscsit_transport API template Nicholas A. Bellinger
2013-04-04  7:24 ` [RFC-v3 3/9] iscsi-target: Initial traditional TCP conversion to iscsit_transport Nicholas A. Bellinger
2013-04-04  7:24 ` [RFC-v3 4/9] iscsi-target: Add iser-target parameter keys + setup during login Nicholas A. Bellinger
2013-04-04  7:24 ` [RFC-v3 5/9] iscsi-target: Add per transport iscsi_cmd alloc/free Nicholas A. Bellinger
2013-04-04  7:24 ` [RFC-v3 6/9] iscsi-target: Refactor RX PDU logic + export request PDU handling Nicholas A. Bellinger
     [not found] ` <1365060256-21506-1-git-send-email-nab-IzHhD5pYlfBP7FQvKIMDCQ@public.gmane.org>
2013-04-04  7:24   ` [RFC-v3 7/9] iscsi-target: Refactor TX queue logic + export response PDU creation Nicholas A. Bellinger
2013-04-04  7:24     ` Nicholas A. Bellinger
2013-04-04  7:24 ` [RFC-v3 8/9] iscsi-target: Add iser network portal attribute Nicholas A. Bellinger
2013-04-04  7:24 ` [RFC-v3 9/9] iser-target: Add iSCSI Extensions for RDMA (iSER) target driver Nicholas A. Bellinger
2013-04-04  9:45   ` Or Gerlitz
2013-04-04 22:17     ` Nicholas A. Bellinger
     [not found]   ` <1365060256-21506-10-git-send-email-nab-IzHhD5pYlfBP7FQvKIMDCQ@public.gmane.org>
2013-04-04  9:20     ` Or Gerlitz [this message]
2013-04-04  9:20       ` Or Gerlitz
2013-04-04 21:59       ` Nicholas A. Bellinger
2013-04-04  9:51     ` Or Gerlitz
2013-04-04  9:51       ` Or Gerlitz
2013-04-04 22:23       ` Nicholas A. Bellinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=515D45F6.9040903@mellanox.com \
    --to=ogerlitz-vpraknaxozvwk0htik3j/w@public.gmane.org \
    --cc=alexandern-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=nab-IzHhD5pYlfBP7FQvKIMDCQ@public.gmane.org \
    --cc=roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.