Re: [GIT PULL] ARM: OMAP5: hwmod, prm/cm data files and updates for 3.10

[Santosh Shilimkar <santosh.shilimkar@ti.com>]

Paul,

On Thursday 04 April 2013 01:39 AM, Paul Walmsley wrote:
> cc Kevin
> 
> Hi
> 
> On Wed, 20 Mar 2013, Santosh Shilimkar wrote:
> 
>> Benoit Cousson (7):
>>       ARM: OMAP5: PRM: Add OMAP54XX register and bitfield files
> 
> So it looks like this patch never made it to the mailing list.  Was it too 
> big?  If so, please try splitting it into two or more pieces.  Looking at 
> the git branch that you posted for pulling, the patch adds two files, so 
> maybe you can just create one patch for each file?
> 
Size was not an issue mostly. Looks like that entire series got affected
because of the TI mailer issue which was reported by ARM list maintainer.
I lost many emails during that.

> Also, looking at the bottom of the arch/arm/mach-omap2/prm54xx.h from this 
> commit 600e78bb51c0ee081f0da14f879c3e4a1dee9896, there are a bunch of 
> function prototypes that reference OMAP44xx.  Shouldn't these reference 
> OMAP54xx, or be removed from this file?  If you're reusing the OMAP4 PRM 
> functions for OMAP5, then shouldn't they be moved out from the OMAP4 
> header files into a separate header file?
> 
Yes. I some how ignored this considering the files were auto-generated.
Have fixed this one now in v2 [1] which is posted on list

>>       ARM: OMAP5: CM: Add OMAP54XX register and bitfield files
> 
> There are similar problems with this patch.  It doesn't look like it ever 
> made it to the linux-omap list, in my inbox, anyway.  And again the 
> function prototypes make several references to OMAP4, when they should 
> refer to OMAP5 or be removed from this file.
> 
Fixed in v2

>>       ARM: OMAP5: PRCM: Add OMAP54XX local MPU PRCM registers
> 
> More duplicated OMAP4 function prototypes here.
> 
Fixed in v2

>>       ARM: OMAP5: SCRM: Add OMAP54XX header file.
> 
> Looks fine to me.
> 
>>       ARM: OMAP2+: clockdomain data: Add OMAP54XX data and update the header
>>       ARM: OMAP5: powerdomain data: Add OMAP54XX data and update the header
> 
> These two look okay to me based on a superficial inspection.  Is there a 
> public TRM posted for OMAP5?  It's not in the obvious place, so there's no 
> way to review these against the TRM:
> 
> http://www.ti.com/lsds/ti/omap-applications-processors/technical-documents.page?familyId=601&docCategoryId=6
> 
Public TRM got delayed becasue of recent changes at TI. As per the latest
I heard, April end the TRM should be public. But as you know auto-generated
data is often more accurate than TRM :)

>>       ARM: OMAP5: hwmod data: Create initial OMAP5 SOC hwmod data
> 
> Looks like this one hasn't been reposted after the changes that were made 
> to it after Tony's comments?  If I've just missed the list post, please 
> send a link.  Otherwise, the updated patch should be reposted.
> 
As mentioned earlier, the series was lost mostly because of mailer issue.
Posted v2 has this patch now.

>> Santosh Shilimkar (4):
>>       ARM: OMAP5: hwmod_data: Fix UART sysc settings
>>       ARM: OMAP5: hwmod-data: Add timer clock activity flags
> 
> These two should be rolled into the "ARM: OMAP5: hwmod data: Create 
> initial OMAP5 SOC hwmod data" patch.
> 
Folded in v2. 

>>       ARM: OMAP5: voltagedomain data: Add OMAP5 voltage domain data
> 
> This one needs to be acked by Kevin.
>
Kevin has been cc'ed on this one.
 
>>       ARM: OMAP5: Enable build and frameowrk initialisations
> 
> Looks fine to me.
> 
Thanks a lot for quick response. Please let me know if I missed any
of your comments in v2.

Regards,
Santosh

[1] http://www.spinics.net/lists/arm-kernel/msg235575.html