From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: peter.maydell@linaro.org, mst@redhat.com, qemu-devel@nongnu.org,
blauwirbel@gmail.com, kraxel@redhat.com,
edgar.iglesias@gmail.com
Subject: Re: [Qemu-devel] [PATCH v2 3/5] register: Add Memory API glue
Date: Fri, 05 Apr 2013 12:07:47 +0200 [thread overview]
Message-ID: <515EA273.8010703@redhat.com> (raw)
In-Reply-To: <7ac19859ba3aed6c19c5f0645ae8f588c9e6a47c.1365151096.git.peter.crosthwaite@xilinx.com>
Il 05/04/2013 10:43, Peter Crosthwaite ha scritto:
> Add memory io handlers that glue the register API to the memory API.
> Just translation functions at this stage. Although it does allow for
> devices to be created without all-in-one mmio r/w handlers.
>
> Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> ---
>
> include/exec/register.h | 13 +++++++++++++
Please put it in include/hw/.
Putting these five in exec/ was a mistake:
#include "exec/address-spaces.h"
#include "exec/hwaddr.h"
#include "exec/ioport.h"
#include "exec/iorange.h"
#include "exec/memory.h"
Most files in hw/ should not need include/exec/.
> register.c | 43 +++++++++++++++++++++++++++++++++++++++++++
If my reorganization goes in before, please make it hw/core/register.c.
The next step in the reorganization would be to move memory.c to hw/core
too.
Paolo
next prev parent reply other threads:[~2013-04-05 10:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-05 8:43 [Qemu-devel] [PATCH v2 0/5] Data Driven device registers & Zynq DEVCFG Peter Crosthwaite
2013-04-05 8:43 ` [Qemu-devel] [PATCH v2 1/5] bitops: Add ONES macro Peter Crosthwaite
2013-04-05 8:53 ` Peter Maydell
2013-04-05 9:11 ` Peter Crosthwaite
2013-04-05 9:24 ` Peter Maydell
2013-04-05 8:43 ` [Qemu-devel] [PATCH v2 2/5] register: Add Register API Peter Crosthwaite
2013-04-05 9:26 ` Peter Maydell
2013-04-05 9:49 ` Peter Crosthwaite
2013-04-07 22:40 ` Peter Crosthwaite
2013-04-15 7:11 ` Gerd Hoffmann
2013-04-05 8:43 ` [Qemu-devel] [PATCH v2 3/5] register: Add Memory API glue Peter Crosthwaite
2013-04-05 10:07 ` Paolo Bonzini [this message]
2013-04-05 8:43 ` [Qemu-devel] [PATCH v2 4/5] xilinx_devcfg: Zynq devcfg device model Peter Crosthwaite
2013-04-05 8:43 ` [Qemu-devel] [PATCH v2 5/5] xilinx_zynq: added devcfg to machine model Peter Crosthwaite
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515EA273.8010703@redhat.com \
--to=pbonzini@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=edgar.iglesias@gmail.com \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.