Re: [Qemu-devel] [PATCH v2 2/5] register: Add Register API

[Gerd Hoffmann <kraxel@redhat.com>]

  Hi,

> - Add a "lite" flag that is (automatically) computed once that takes a
> fast path through the read/write handlers. A reg is lite if it
> requires no read-modify-write (no ro, nw, ge, ui, wtc). Only the
> actual write and post_write handlers are executed.

Sounds good to me.

> - Remove the byte loops. Just switch on register size and cast to
> uint_XXt. Remove support for non power-of-two size registers and
> non-host endianess (needed for potential PCI conversion) but should
> make the code faster.

This too.

Also: you might want to pass both old and new value to the post-write
hook so the handler can easily figure what has actually changed.

cheers,
  Gerd