From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Alexandre Pereira da Silva <aletes.xgr@gmail.com>
Cc: linux-mmc@vger.kernel.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: mmc: mxs-mmc: add non-removeable property
Date: Fri, 05 Apr 2013 14:14:06 +0200 [thread overview]
Message-ID: <515EC00E.5060009@pengutronix.de> (raw)
In-Reply-To: <CAAAP30HvkQNTS1+7QddAV4CZVo=g3vaJGjJNNFu3CCbGDHTqsQ@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1300 bytes --]
On 04/05/2013 02:01 PM, Alexandre Pereira da Silva wrote:
> I just sent a patch to fix the same thing to the list, without seeing
> yours first.
>
> But in the discussion, I learned that I should be checking for
> broken-cd instead of non-removable.
I'm not subscribed to linux-mmc and on
http://news.gmane.org/gmane.linux.kernel.mmc I just see Marek's
Reviewed-by. Can you point me to the discussion?
In fact my board has an eMMC, which is soldered to the board and the
card detect is not connected...the documentation says:
> - broken-cd: There is no card detection available; polling must be used.
> - non-removable: non-removable slot (like eMMC); assume always present.
I see no point in using polling if the card is in deed always present.
> Would you like for me to send a separate patch for broken-cd or do you
> prefer to check on yours when you resubmit?
If your card detect is not connected and the card is removable, you
should use broken-cd and base you patch on mine.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: mkl@pengutronix.de (Marc Kleine-Budde)
To: linux-arm-kernel@lists.infradead.org
Subject: mmc: mxs-mmc: add non-removeable property
Date: Fri, 05 Apr 2013 14:14:06 +0200 [thread overview]
Message-ID: <515EC00E.5060009@pengutronix.de> (raw)
In-Reply-To: <CAAAP30HvkQNTS1+7QddAV4CZVo=g3vaJGjJNNFu3CCbGDHTqsQ@mail.gmail.com>
On 04/05/2013 02:01 PM, Alexandre Pereira da Silva wrote:
> I just sent a patch to fix the same thing to the list, without seeing
> yours first.
>
> But in the discussion, I learned that I should be checking for
> broken-cd instead of non-removable.
I'm not subscribed to linux-mmc and on
http://news.gmane.org/gmane.linux.kernel.mmc I just see Marek's
Reviewed-by. Can you point me to the discussion?
In fact my board has an eMMC, which is soldered to the board and the
card detect is not connected...the documentation says:
> - broken-cd: There is no card detection available; polling must be used.
> - non-removable: non-removable slot (like eMMC); assume always present.
I see no point in using polling if the card is in deed always present.
> Would you like for me to send a separate patch for broken-cd or do you
> prefer to check on yours when you resubmit?
If your card detect is not connected and the card is removable, you
should use broken-cd and base you patch on mine.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130405/c8e8ab65/attachment.sig>
next parent reply other threads:[~2013-04-05 12:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAAAP30HvkQNTS1+7QddAV4CZVo=g3vaJGjJNNFu3CCbGDHTqsQ@mail.gmail.com>
2013-04-05 12:14 ` Marc Kleine-Budde [this message]
2013-04-05 12:14 ` mmc: mxs-mmc: add non-removeable property Marc Kleine-Budde
[not found] ` <CAAAP30GCRsS4JhAy0yP5su3mVm-NNTxtVS0cddxWGVwS3C6gNw@mail.gmail.com>
2013-04-05 12:49 ` Marc Kleine-Budde
2013-04-05 12:49 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515EC00E.5060009@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=aletes.xgr@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.