* [PATCH 1/1] [libata] SCSI: really use SATL version in VPD [not found] <satl-driver-version-v2> @ 2013-04-05 14:50 ` Baruch Even 2013-04-05 15:24 ` Sergei Shtylyov 0 siblings, 1 reply; 5+ messages in thread From: Baruch Even @ 2013-04-05 14:50 UTC (permalink / raw) To: Jeff Garzik, linux-ide; +Cc: Baruch Even As per c78968bb by Jeff Garzik ([libata] SCSI: simulator version, not device version, belongs in VPD) We need to provide the SATL driver version and not the disk firmware version but the code overwrites the driver version with the disk version. Signed-off-by: Baruch Even <baruch@ev-en.org> --- drivers/ata/libata-scsi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index 318b413..e61a054 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c @@ -2126,7 +2126,6 @@ static unsigned int ata_scsiop_inq_89(struct ata_scsi_args *args, u8 *rbuf) memcpy(&rbuf[8], "linux ", 8); memcpy(&rbuf[16], "libata ", 16); memcpy(&rbuf[32], DRV_VERSION, 4); - ata_id_string(args->id, &rbuf[32], ATA_ID_FW_REV, 4); /* we don't store the ATA device signature, so we fake it */ -- 1.7.10.4 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] [libata] SCSI: really use SATL version in VPD 2013-04-05 14:50 ` [PATCH 1/1] [libata] SCSI: really use SATL version in VPD Baruch Even @ 2013-04-05 15:24 ` Sergei Shtylyov 0 siblings, 0 replies; 5+ messages in thread From: Sergei Shtylyov @ 2013-04-05 15:24 UTC (permalink / raw) To: Baruch Even; +Cc: Jeff Garzik, linux-ide Hello. On 05-04-2013 18:50, Baruch Even wrote: When you post a new revision of the patch, this should be marked in the subject, like this: {PATCH v2]. > As per c78968bb by Jeff Garzik ([libata] SCSI: simulator version, not device version, belongs in VPD) Please wrap your lines at 80 characters max. > We need to provide the SATL driver version and not the disk firmware version > but the code overwrites the driver version with the disk version. > Signed-off-by: Baruch Even <baruch@ev-en.org> WBR, Sergei ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <satl-driver-version>]
* [PATCH 1/1] [libata] SCSI: really use SATL version in VPD [not found] <satl-driver-version> @ 2013-04-05 11:48 ` Baruch Even 2013-04-05 14:44 ` Sergei Shtylyov 0 siblings, 1 reply; 5+ messages in thread From: Baruch Even @ 2013-04-05 11:48 UTC (permalink / raw) To: Jeff Garzik, linux-ide; +Cc: Baruch Even Commit message of c78968bb by Jeff Garzik says we need to provide the SATL driver version and not the disk firmware version but the code overwrites the driver version with the disk version. Signed-off-by: Baruch Even <baruch@ev-en.org> --- drivers/ata/libata-scsi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index 318b413..e61a054 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c @@ -2126,7 +2126,6 @@ static unsigned int ata_scsiop_inq_89(struct ata_scsi_args *args, u8 *rbuf) memcpy(&rbuf[8], "linux ", 8); memcpy(&rbuf[16], "libata ", 16); memcpy(&rbuf[32], DRV_VERSION, 4); - ata_id_string(args->id, &rbuf[32], ATA_ID_FW_REV, 4); /* we don't store the ATA device signature, so we fake it */ -- 1.7.10.4 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] [libata] SCSI: really use SATL version in VPD 2013-04-05 11:48 ` Baruch Even @ 2013-04-05 14:44 ` Sergei Shtylyov 2013-04-05 14:51 ` Baruch Even 0 siblings, 1 reply; 5+ messages in thread From: Sergei Shtylyov @ 2013-04-05 14:44 UTC (permalink / raw) To: Baruch Even; +Cc: Jeff Garzik, linux-ide Hello. On 05-04-2013 15:48, Baruch Even wrote: > Commit message of c78968bb Please also specify the summary line of that commit in parens (or however you like). > by Jeff Garzik says we need to provide the SATL > driver version and not the disk firmware version but the code overwrites the > driver version with the disk version. > Signed-off-by: Baruch Even <baruch@ev-en.org> WBR, Sergei ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] [libata] SCSI: really use SATL version in VPD 2013-04-05 14:44 ` Sergei Shtylyov @ 2013-04-05 14:51 ` Baruch Even 0 siblings, 0 replies; 5+ messages in thread From: Baruch Even @ 2013-04-05 14:51 UTC (permalink / raw) To: Sergei Shtylyov; +Cc: Jeff Garzik, linux-ide OK. Resending. On Fri, Apr 5, 2013 at 5:44 PM, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: > Hello. > > On 05-04-2013 15:48, Baruch Even wrote: > >> Commit message of c78968bb > > > Please also specify the summary line of that commit in parens (or however > you like). > > >> by Jeff Garzik says we need to provide the SATL >> driver version and not the disk firmware version but the code overwrites >> the >> driver version with the disk version. > > >> Signed-off-by: Baruch Even <baruch@ev-en.org> > > > WBR, Sergei > ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-04-05 15:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <satl-driver-version-v2>
2013-04-05 14:50 ` [PATCH 1/1] [libata] SCSI: really use SATL version in VPD Baruch Even
2013-04-05 15:24 ` Sergei Shtylyov
[not found] <satl-driver-version>
2013-04-05 11:48 ` Baruch Even
2013-04-05 14:44 ` Sergei Shtylyov
2013-04-05 14:51 ` Baruch Even
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.