From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/8] ARM: shmobile:Marzen: move USB EHCI, OHCI, and PHY devices to R8A7779 code
Date: Fri, 05 Apr 2013 15:47:35 +0000 [thread overview]
Message-ID: <515EF217.2010109@cogentembedded.com> (raw)
In-Reply-To: <20130405004147.GN29203@verge.net.au>
Hello.
On 05-04-2013 4:41, Simon Horman wrote:
>> USB EHCI, OHCI, and common PHY are the SoC devices but are wrongly defined and
>> registered in the Marzen board file. Move the data and code to their proper
>> place in setup-r8a7779.c; while at it, we have to rename 8a7779_late_devices[]
>> to 8a7779_standard_devices[] -- this seems legitimate since they are registered
>> from r8a7779_add_standard_devices() anyway.
>> Note that I'm deliberately changing the USB PHY platform device's 'id' field
>> from (previously just omitted) 0 to -1 as the device is a single of its kind.
> Would it be possible to re-arange this patch so that
> there is an SoC patch followed by a board patch?
I seriously doubt it, thought I'll try to think about it more. The patch
adding the SoC devices to the board file should't have been accepted in the
first place, so we wouldn't have to fix it eventually.
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/8] ARM: shmobile:Marzen: move USB EHCI, OHCI, and PHY devices to R8A7779 code
Date: Fri, 05 Apr 2013 19:47:35 +0400 [thread overview]
Message-ID: <515EF217.2010109@cogentembedded.com> (raw)
In-Reply-To: <20130405004147.GN29203@verge.net.au>
Hello.
On 05-04-2013 4:41, Simon Horman wrote:
>> USB EHCI, OHCI, and common PHY are the SoC devices but are wrongly defined and
>> registered in the Marzen board file. Move the data and code to their proper
>> place in setup-r8a7779.c; while at it, we have to rename 8a7779_late_devices[]
>> to 8a7779_standard_devices[] -- this seems legitimate since they are registered
>> from r8a7779_add_standard_devices() anyway.
>> Note that I'm deliberately changing the USB PHY platform device's 'id' field
>> from (previously just omitted) 0 to -1 as the device is a single of its kind.
> Would it be possible to re-arange this patch so that
> there is an SoC patch followed by a board patch?
I seriously doubt it, thought I'll try to think about it more. The patch
adding the SoC devices to the board file should't have been accepted in the
first place, so we wouldn't have to fix it eventually.
WBR, Sergei
next prev parent reply other threads:[~2013-04-05 15:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-04 22:57 [PATCH 1/8] ARM: shmobile:Marzen: move USB EHCI, OHCI, and PHY devices to R8A7779 code Sergei Shtylyov
2013-04-04 22:57 ` Sergei Shtylyov
2013-04-05 0:41 ` Simon Horman
2013-04-05 0:41 ` Simon Horman
2013-04-05 15:47 ` Sergei Shtylyov [this message]
2013-04-05 15:47 ` Sergei Shtylyov
2013-04-05 18:46 ` Sergei Shtylyov
2013-04-05 18:46 ` Sergei Shtylyov
2013-04-18 15:44 ` Russell King - ARM Linux
2013-04-18 15:44 ` Russell King - ARM Linux
2013-04-18 17:40 ` Sergei Shtylyov
2013-04-18 17:40 ` Sergei Shtylyov
2013-04-19 2:17 ` Simon Horman
2013-04-19 2:17 ` Simon Horman
2013-04-19 11:44 ` Sergei Shtylyov
2013-04-19 11:44 ` Sergei Shtylyov
2013-04-22 3:45 ` Simon Horman
2013-04-22 3:45 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515EF217.2010109@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.