From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 5/8] rcar-phy: correct base address
Date: Fri, 05 Apr 2013 16:30:00 +0000 [thread overview]
Message-ID: <515EFC08.8000308@cogentembedded.com> (raw)
In-Reply-To: <20130405004356.GP29203@verge.net.au>
Hello.
On 05-04-2013 4:43, Simon Horman wrote:
>> The memory region that is used by the driver overlaps EHCI and OHCI register
>> regions for absolutely no reason now -- fix it by adding offset of 0x800 to
>> the base address, changing the register #define's accordingly. This has extra
>> positive effect that we now can use devm_ioremap_resource().
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> As per my comment regarding patch 4, I wonder if this
> could be split into a driver patch and an SoC patch.
Absolutely not. That'll break bisection.
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/8] rcar-phy: correct base address
Date: Fri, 05 Apr 2013 20:30:00 +0400 [thread overview]
Message-ID: <515EFC08.8000308@cogentembedded.com> (raw)
In-Reply-To: <20130405004356.GP29203@verge.net.au>
Hello.
On 05-04-2013 4:43, Simon Horman wrote:
>> The memory region that is used by the driver overlaps EHCI and OHCI register
>> regions for absolutely no reason now -- fix it by adding offset of 0x800 to
>> the base address, changing the register #define's accordingly. This has extra
>> positive effect that we now can use devm_ioremap_resource().
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> As per my comment regarding patch 4, I wonder if this
> could be split into a driver patch and an SoC patch.
Absolutely not. That'll break bisection.
WBR, Sergei
next prev parent reply other threads:[~2013-04-05 16:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-04 23:05 [PATCH 5/8] rcar-phy: correct base address Sergei Shtylyov
2013-04-04 23:05 ` Sergei Shtylyov
2013-04-05 0:43 ` Simon Horman
2013-04-05 0:43 ` Simon Horman
2013-04-05 16:30 ` Sergei Shtylyov [this message]
2013-04-05 16:30 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515EFC08.8000308@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.