From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 7/8] ARM: shmobile: Marzen: pass platform data to USB PHY device
Date: Fri, 05 Apr 2013 16:33:39 +0000 [thread overview]
Message-ID: <515EFCE3.4060805@cogentembedded.com> (raw)
In-Reply-To: <20130405004445.GQ29203@verge.net.au>
Hello.
On 05-04-2013 4:44, Simon Horman wrote:
>> Since we're now going to setup the USBPCTRL0 register using the USB PHY device's
>> platform data, we now need a way to pass those platform data from the board file
>> to the device which is situated in setup-r8a7779.c -- and what I'm suggesting is
>> r8a7779_add_usb_phy_device() that will register USB PHY platform device with the
>> passed platform data using platform_device_register_resndata() call; creating
>> this function involves deletion of 'usb_phy_device' from r8a7779_devices_dt[],
>> so that it will no longer be registered for the generic R8A7779 machine (where
>> we can't provide the platform data anyway), hence EHCI/OHCI drivers will fail
>> to load as well.
>> For the Marzen board, this new function will be called from marzen_init() to
>> register the USB PHY device early enough.
> As per my comment regarding patch 1, I wonder if this could
> be split into an SoC patch and a board patch.
No, that'll break bisection as it will cause the PHY driver to not be
registered after the SoC patch, and hence EHCI/OHCI drivers won't load too.
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 7/8] ARM: shmobile: Marzen: pass platform data to USB PHY device
Date: Fri, 05 Apr 2013 20:33:39 +0400 [thread overview]
Message-ID: <515EFCE3.4060805@cogentembedded.com> (raw)
In-Reply-To: <20130405004445.GQ29203@verge.net.au>
Hello.
On 05-04-2013 4:44, Simon Horman wrote:
>> Since we're now going to setup the USBPCTRL0 register using the USB PHY device's
>> platform data, we now need a way to pass those platform data from the board file
>> to the device which is situated in setup-r8a7779.c -- and what I'm suggesting is
>> r8a7779_add_usb_phy_device() that will register USB PHY platform device with the
>> passed platform data using platform_device_register_resndata() call; creating
>> this function involves deletion of 'usb_phy_device' from r8a7779_devices_dt[],
>> so that it will no longer be registered for the generic R8A7779 machine (where
>> we can't provide the platform data anyway), hence EHCI/OHCI drivers will fail
>> to load as well.
>> For the Marzen board, this new function will be called from marzen_init() to
>> register the USB PHY device early enough.
> As per my comment regarding patch 1, I wonder if this could
> be split into an SoC patch and a board patch.
No, that'll break bisection as it will cause the PHY driver to not be
registered after the SoC patch, and hence EHCI/OHCI drivers won't load too.
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
WBR, Sergei
next prev parent reply other threads:[~2013-04-05 16:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-04 23:10 [PATCH 7/8] ARM: shmobile: Marzen: pass platform data to USB PHY device Sergei Shtylyov
2013-04-04 23:10 ` Sergei Shtylyov
2013-04-05 0:44 ` Simon Horman
2013-04-05 0:44 ` Simon Horman
2013-04-05 16:33 ` Sergei Shtylyov [this message]
2013-04-05 16:33 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515EFCE3.4060805@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.