From: Stephen Boyd <sboyd@codeaurora.org>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: Mark Rutland <Mark.Rutland@arm.com>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
John Stultz <john.stultz@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: arch_timer: Silence debug preempt warnings
Date: Fri, 05 Apr 2013 13:12:05 -0700 [thread overview]
Message-ID: <515F3015.6010107@codeaurora.org> (raw)
In-Reply-To: <515EA195.4010307@arm.com>
On 04/05/13 03:04, Marc Zyngier wrote:
>
>>> drivers/clocksource/arm_arch_timer.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
>>> index d7ad425..5928c29 100644
>>> --- a/drivers/clocksource/arm_arch_timer.c
>>> +++ b/drivers/clocksource/arm_arch_timer.c
>>> @@ -248,7 +248,7 @@ static void __cpuinit arch_timer_stop(struct clock_event_device *clk)
>>> static int __cpuinit arch_timer_cpu_notify(struct notifier_block *self,
>>> unsigned long action, void *hcpu)
>>> {
>>> - struct clock_event_device *evt = this_cpu_ptr(arch_timer_evt);
>>> + struct clock_event_device *evt = __this_cpu_ptr(arch_timer_evt);
>>>
>>> switch (action & ~CPU_TASKS_FROZEN) {
>>> case CPU_STARTING:
> I'm afraid this would hide bugs if we start using the notifier for other
> purposes than exclusivity non-preemptible contexts.
>
> How about moving the this_cpu_ptr() down to the cases themselves, maybe
> with a nice comment?
Ok. v2 coming up.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: arch_timer: Silence debug preempt warnings
Date: Fri, 05 Apr 2013 13:12:05 -0700 [thread overview]
Message-ID: <515F3015.6010107@codeaurora.org> (raw)
In-Reply-To: <515EA195.4010307@arm.com>
On 04/05/13 03:04, Marc Zyngier wrote:
>
>>> drivers/clocksource/arm_arch_timer.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
>>> index d7ad425..5928c29 100644
>>> --- a/drivers/clocksource/arm_arch_timer.c
>>> +++ b/drivers/clocksource/arm_arch_timer.c
>>> @@ -248,7 +248,7 @@ static void __cpuinit arch_timer_stop(struct clock_event_device *clk)
>>> static int __cpuinit arch_timer_cpu_notify(struct notifier_block *self,
>>> unsigned long action, void *hcpu)
>>> {
>>> - struct clock_event_device *evt = this_cpu_ptr(arch_timer_evt);
>>> + struct clock_event_device *evt = __this_cpu_ptr(arch_timer_evt);
>>>
>>> switch (action & ~CPU_TASKS_FROZEN) {
>>> case CPU_STARTING:
> I'm afraid this would hide bugs if we start using the notifier for other
> purposes than exclusivity non-preemptible contexts.
>
> How about moving the this_cpu_ptr() down to the cases themselves, maybe
> with a nice comment?
Ok. v2 coming up.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@codeaurora.org>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: John Stultz <john.stultz@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Mark Rutland <Mark.Rutland@arm.com>
Subject: Re: [PATCH] ARM: arch_timer: Silence debug preempt warnings
Date: Fri, 05 Apr 2013 13:12:05 -0700 [thread overview]
Message-ID: <515F3015.6010107@codeaurora.org> (raw)
In-Reply-To: <515EA195.4010307@arm.com>
On 04/05/13 03:04, Marc Zyngier wrote:
>
>>> drivers/clocksource/arm_arch_timer.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
>>> index d7ad425..5928c29 100644
>>> --- a/drivers/clocksource/arm_arch_timer.c
>>> +++ b/drivers/clocksource/arm_arch_timer.c
>>> @@ -248,7 +248,7 @@ static void __cpuinit arch_timer_stop(struct clock_event_device *clk)
>>> static int __cpuinit arch_timer_cpu_notify(struct notifier_block *self,
>>> unsigned long action, void *hcpu)
>>> {
>>> - struct clock_event_device *evt = this_cpu_ptr(arch_timer_evt);
>>> + struct clock_event_device *evt = __this_cpu_ptr(arch_timer_evt);
>>>
>>> switch (action & ~CPU_TASKS_FROZEN) {
>>> case CPU_STARTING:
> I'm afraid this would hide bugs if we start using the notifier for other
> purposes than exclusivity non-preemptible contexts.
>
> How about moving the this_cpu_ptr() down to the cases themselves, maybe
> with a nice comment?
Ok. v2 coming up.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2013-04-05 20:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-02 20:31 [PATCH] ARM: arch_timer: Silence debug preempt warnings Stephen Boyd
2013-04-02 20:31 ` Stephen Boyd
2013-04-05 5:11 ` Stephen Boyd
2013-04-05 5:11 ` Stephen Boyd
2013-04-05 10:04 ` Marc Zyngier
2013-04-05 10:04 ` Marc Zyngier
2013-04-05 20:12 ` Stephen Boyd [this message]
2013-04-05 20:12 ` Stephen Boyd
2013-04-05 20:12 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515F3015.6010107@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=Mark.Rutland@arm.com \
--cc=john.stultz@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.