All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael R. Hines" <mrhines-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
To: Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: "Michael S. Tsirkin"
	<mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Jason Gunthorpe
	<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>,
	Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Hal Rosenstock
	<hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Yishai Hadas <yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	Christoph Lameter <cl-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org>,
	"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org
Subject: Re: [PATCHv2] rdma: add a new IB_ACCESS_GIFT flag
Date: Fri, 05 Apr 2013 16:51:20 -0400	[thread overview]
Message-ID: <515F3948.40205@linux.vnet.ibm.com> (raw)
In-Reply-To: <CAL1RGDU2jtrRrxi6srsH_ADiYGvJbCpCT3UvoLGTX3cvQ=s0kQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

Sorry, I was wrong. ignore the comments about cgroups. That's still 
broken. (i.e. trying to register RDMA memory while using a cgroup swap 
limit cause the process get killed).

But the GIFT flag patch works (my understanding is that GIFT flag allows 
the adapter to transmit stale memory information, it does not have 
anything to do with cgroups specifically).

Am I missing something? I was only testing the GIFT flag patch.

Note: I only turned it on - I did not verify the (non) consitency of the 
memory that was transmitted.

- Michael


On 04/05/2013 04:43 PM, Roland Dreier wrote:
> On Fri, Apr 5, 2013 at 1:17 PM, Michael R. Hines
> <mrhines-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org> wrote:
>> I also removed the IBV_*_WRITE flags on the sender-side and activated
>> cgroups with the "memory.memsw.limit_in_bytes" activated and the migration
>> with RDMA also succeeded without any problems (both with *and* without GIFT
>> also worked).
> Not sure I'm interpreting this correctly.  Are you saying that things
> worked without actually setting the GIFT flag?   In which case why are
> we adding this flag?
>
>   - R.
>

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: "Michael R. Hines" <mrhines@linux.vnet.ibm.com>
To: Roland Dreier <roland@kernel.org>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
	Sean Hefty <sean.hefty@intel.com>,
	Hal Rosenstock <hal.rosenstock@gmail.com>,
	Yishai Hadas <yishaih@mellanox.com>,
	Christoph Lameter <cl@linux.com>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	qemu-devel@nongnu.org
Subject: Re: [PATCHv2] rdma: add a new IB_ACCESS_GIFT flag
Date: Fri, 05 Apr 2013 16:51:20 -0400	[thread overview]
Message-ID: <515F3948.40205@linux.vnet.ibm.com> (raw)
In-Reply-To: <CAL1RGDU2jtrRrxi6srsH_ADiYGvJbCpCT3UvoLGTX3cvQ=s0kQ@mail.gmail.com>

Sorry, I was wrong. ignore the comments about cgroups. That's still 
broken. (i.e. trying to register RDMA memory while using a cgroup swap 
limit cause the process get killed).

But the GIFT flag patch works (my understanding is that GIFT flag allows 
the adapter to transmit stale memory information, it does not have 
anything to do with cgroups specifically).

Am I missing something? I was only testing the GIFT flag patch.

Note: I only turned it on - I did not verify the (non) consitency of the 
memory that was transmitted.

- Michael


On 04/05/2013 04:43 PM, Roland Dreier wrote:
> On Fri, Apr 5, 2013 at 1:17 PM, Michael R. Hines
> <mrhines@linux.vnet.ibm.com> wrote:
>> I also removed the IBV_*_WRITE flags on the sender-side and activated
>> cgroups with the "memory.memsw.limit_in_bytes" activated and the migration
>> with RDMA also succeeded without any problems (both with *and* without GIFT
>> also worked).
> Not sure I'm interpreting this correctly.  Are you saying that things
> worked without actually setting the GIFT flag?   In which case why are
> we adding this flag?
>
>   - R.
>


WARNING: multiple messages have this Message-ID (diff)
From: "Michael R. Hines" <mrhines@linux.vnet.ibm.com>
To: Roland Dreier <roland@kernel.org>
Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	Yishai Hadas <yishaih@mellanox.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Hal Rosenstock <hal.rosenstock@gmail.com>,
	Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
	Sean Hefty <sean.hefty@intel.com>,
	Christoph Lameter <cl@linux.com>
Subject: Re: [Qemu-devel] [PATCHv2] rdma: add a new IB_ACCESS_GIFT flag
Date: Fri, 05 Apr 2013 16:51:20 -0400	[thread overview]
Message-ID: <515F3948.40205@linux.vnet.ibm.com> (raw)
In-Reply-To: <CAL1RGDU2jtrRrxi6srsH_ADiYGvJbCpCT3UvoLGTX3cvQ=s0kQ@mail.gmail.com>

Sorry, I was wrong. ignore the comments about cgroups. That's still 
broken. (i.e. trying to register RDMA memory while using a cgroup swap 
limit cause the process get killed).

But the GIFT flag patch works (my understanding is that GIFT flag allows 
the adapter to transmit stale memory information, it does not have 
anything to do with cgroups specifically).

Am I missing something? I was only testing the GIFT flag patch.

Note: I only turned it on - I did not verify the (non) consitency of the 
memory that was transmitted.

- Michael


On 04/05/2013 04:43 PM, Roland Dreier wrote:
> On Fri, Apr 5, 2013 at 1:17 PM, Michael R. Hines
> <mrhines@linux.vnet.ibm.com> wrote:
>> I also removed the IBV_*_WRITE flags on the sender-side and activated
>> cgroups with the "memory.memsw.limit_in_bytes" activated and the migration
>> with RDMA also succeeded without any problems (both with *and* without GIFT
>> also worked).
> Not sure I'm interpreting this correctly.  Are you saying that things
> worked without actually setting the GIFT flag?   In which case why are
> we adding this flag?
>
>   - R.
>

  parent reply	other threads:[~2013-04-05 20:51 UTC|newest]

Thread overview: 76+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-24 15:51 [PATCHv2] rdma: add a new IB_ACCESS_GIFT flag Michael S. Tsirkin
2013-03-24 15:51 ` [Qemu-devel] " Michael S. Tsirkin
2013-04-02 15:51 ` Michael S. Tsirkin
2013-04-02 15:51   ` [Qemu-devel] " Michael S. Tsirkin
     [not found]   ` <20130402155104.GA27382-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-04-02 16:57     ` Roland Dreier
2013-04-02 16:57       ` [Qemu-devel] " Roland Dreier
2013-04-02 16:57       ` Roland Dreier
     [not found]       ` <CAL1RGDUe1=Xd1mpNajiLY08fJ+gBKAMDGeX3SVkS+egOQyiCxQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-04-02 17:05         ` Michael S. Tsirkin
2013-04-02 17:05           ` [Qemu-devel] " Michael S. Tsirkin
2013-04-02 17:05           ` Michael S. Tsirkin
2013-04-02 22:17           ` Michael R. Hines
2013-04-02 22:17             ` [Qemu-devel] " Michael R. Hines
2013-04-02 22:17             ` Michael R. Hines
     [not found]           ` <20130402170521.GA30295-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-04-03 16:07             ` Michael S. Tsirkin
2013-04-03 16:07               ` [Qemu-devel] " Michael S. Tsirkin
2013-04-03 16:07               ` Michael S. Tsirkin
     [not found] ` <20130324155153.GA8597-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-04-05 20:17   ` Michael R. Hines
2013-04-05 20:17     ` [Qemu-devel] " Michael R. Hines
2013-04-05 20:17     ` Michael R. Hines
2013-04-05 20:43     ` Roland Dreier
2013-04-05 20:43       ` [Qemu-devel] " Roland Dreier
2013-04-05 20:54       ` Michael R. Hines
2013-04-05 20:54         ` [Qemu-devel] " Michael R. Hines
     [not found]         ` <515F3A0F.5030507-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2013-04-09 16:39           ` Michael S. Tsirkin
2013-04-09 16:39             ` [Qemu-devel] " Michael S. Tsirkin
2013-04-09 16:39             ` Michael S. Tsirkin
     [not found]             ` <20130409163929.GA7661-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-04-09 17:56               ` Michael R. Hines
2013-04-09 17:56                 ` [Qemu-devel] " Michael R. Hines
2013-04-09 17:56                 ` Michael R. Hines
     [not found]                 ` <51645630.3030608-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2013-04-09 19:00                   ` Michael S. Tsirkin
2013-04-09 19:00                     ` [Qemu-devel] " Michael S. Tsirkin
2013-04-09 19:00                     ` Michael S. Tsirkin
     [not found]       ` <CAL1RGDU2jtrRrxi6srsH_ADiYGvJbCpCT3UvoLGTX3cvQ=s0kQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-04-05 20:51         ` Michael R. Hines [this message]
2013-04-05 20:51           ` [Qemu-devel] " Michael R. Hines
2013-04-05 20:51           ` Michael R. Hines
     [not found]           ` <515F3948.40205-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2013-04-05 21:03             ` Roland Dreier
2013-04-05 21:03               ` [Qemu-devel] " Roland Dreier
2013-04-05 21:03               ` Roland Dreier
     [not found]               ` <CAG4TOxPNHZadLjq6-HuOExf1XXLO6AYyvRQ1L09i6qVeA5dbLQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-04-05 21:32                 ` Michael R. Hines
2013-04-05 21:32                   ` [Qemu-devel] " Michael R. Hines
2013-04-05 21:32                   ` Michael R. Hines
     [not found]                   ` <515F42EE.8060203-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2013-04-09 19:03                     ` Michael S. Tsirkin
2013-04-09 19:03                       ` [Qemu-devel] " Michael S. Tsirkin
2013-04-09 19:03                       ` Michael S. Tsirkin
     [not found]                       ` <20130409190350.GB8212-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-04-10  1:26                         ` Michael R. Hines
2013-04-10  1:26                           ` [Qemu-devel] " Michael R. Hines
2013-04-10  1:26                           ` Michael R. Hines
2013-04-10  3:24                           ` Michael S. Tsirkin
2013-04-10  3:24                             ` [Qemu-devel] " Michael S. Tsirkin
2013-04-10  3:24                             ` Michael S. Tsirkin
     [not found]                             ` <20130410032449.GA12777-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-04-10  4:32                               ` Michael R. Hines
2013-04-10  4:32                                 ` [Qemu-devel] " Michael R. Hines
2013-04-10  4:32                                 ` Michael R. Hines
     [not found]                                 ` <5164EB5F.80403-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2013-04-10  5:32                                   ` Michael S. Tsirkin
2013-04-10  5:32                                     ` [Qemu-devel] " Michael S. Tsirkin
2013-04-10  5:32                                     ` Michael S. Tsirkin
2013-04-10 15:48                                     ` Michael R. Hines
2013-04-10 15:48                                       ` [Qemu-devel] " Michael R. Hines
     [not found]                                       ` <516589C8.1040606-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2013-04-10 15:05                                         ` Michael S. Tsirkin
2013-04-10 15:05                                           ` [Qemu-devel] " Michael S. Tsirkin
2013-04-10 15:05                                           ` Michael S. Tsirkin
     [not found]                                           ` <20130410150539.GA24381-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-04-10 16:28                                             ` Michael R. Hines
2013-04-10 16:28                                               ` [Qemu-devel] " Michael R. Hines
2013-04-10 16:28                                               ` Michael R. Hines
2013-04-09 19:09                 ` Michael S. Tsirkin
2013-04-09 19:09                   ` [Qemu-devel] " Michael S. Tsirkin
2013-04-09 19:09                   ` Michael S. Tsirkin
2013-04-09 19:12         ` Michael S. Tsirkin
2013-04-09 19:12           ` [Qemu-devel] " Michael S. Tsirkin
2013-04-09 19:12           ` Michael S. Tsirkin
     [not found]     ` <515F3160.4020007-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2013-04-09 20:34       ` Michael S. Tsirkin
2013-04-09 20:34         ` [Qemu-devel] " Michael S. Tsirkin
2013-04-09 20:34         ` Michael S. Tsirkin
     [not found]         ` <20130409203409.GA9246-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-04-09 20:37           ` Michael S. Tsirkin
2013-04-09 20:37             ` [Qemu-devel] " Michael S. Tsirkin
2013-04-09 20:37             ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=515F3948.40205@linux.vnet.ibm.com \
    --to=mrhines-23vcf4htsmix0ybbhkvfkdbpr1lh4cv8@public.gmane.org \
    --cc=cl-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org \
    --cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org \
    --cc=roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.