From: Marco Stornelli <marco.stornelli@gmail.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 3/4] fsfreeze: manage kill signal when sb_start_pagefault is called
Date: Sat, 06 Apr 2013 17:00:07 +0200 [thread overview]
Message-ID: <51603877.7070904@gmail.com> (raw)
In-Reply-To: <20130406132028.GD28744@parisc-linux.org>
Il 06/04/2013 15:20, Matthew Wilcox ha scritto:
> On Sat, Apr 06, 2013 at 12:05:52PM +0200, Marco Stornelli wrote:
>> In every place where sb_start_pagefault was called now we must manage
>> the error code and return VM_FAULT_RETRY.
>
> Erm ... in patch 1/4:
>
> static inline void sb_start_pagefault(struct super_block *sb)
> {
> - __sb_start_write(sb, SB_FREEZE_PAGEFAULT, true);
> + __sb_start_write_wait(sb, SB_FREEZE_PAGEFAULT, false);
> }
>
>>
>> - sb_start_pagefault(inode->i_sb);
>> + ret = sb_start_pagefault(inode->i_sb);
>> + if (ret)
>> + return VM_FAULT_RETRY;
>> ret = btrfs_delalloc_reserve_space(inode, PAGE_CACHE_SIZE);
>
> Does the compiler not warn that you're assigning void to 'ret'? Or was
> there some other SNAFU sending these patches?
>
I'm sorry, my fault :) As I said in 00 these patches are completely
*not* tested, it was only a "quick coding & review" to understand if
someone can see any problem to this kind of implementation, since I
touched several points in the kernel. So there is still on-going work
and I need to do several tests. Maybe I had to add the RFC tag, sorry again.
Marco
WARNING: multiple messages have this Message-ID (diff)
From: Marco Stornelli <marco.stornelli@gmail.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: linux-fsdevel@vger.kernel.org,
Chris Mason <chris.mason@fusionio.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
"Theodore Ts'o" <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Jaegeuk Kim <jaegeuk.kim@samsung.com>,
Steven Whitehouse <swhiteho@redhat.com>,
KONISHI Ryusuke <konishi.ryusuke@lab.ntt.co.jp>,
Mark Fasheh <mfasheh@suse.com>, Joel Becker <jlbec@evilplan.org>,
Mike Snitzer <snitzer@redhat.com>,
Alasdair G Kergon <agk@redhat.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com,
linux-nilfs@vger.kernel.org, ocfs2-devel@oss.oracle.com,
linux-mm@kvack.org, Jan Kara <jack@suse.cz>
Subject: Re: [PATCH 3/4] fsfreeze: manage kill signal when sb_start_pagefault is called
Date: Sat, 06 Apr 2013 17:00:07 +0200 [thread overview]
Message-ID: <51603877.7070904@gmail.com> (raw)
In-Reply-To: <20130406132028.GD28744@parisc-linux.org>
Il 06/04/2013 15:20, Matthew Wilcox ha scritto:
> On Sat, Apr 06, 2013 at 12:05:52PM +0200, Marco Stornelli wrote:
>> In every place where sb_start_pagefault was called now we must manage
>> the error code and return VM_FAULT_RETRY.
>
> Erm ... in patch 1/4:
>
> static inline void sb_start_pagefault(struct super_block *sb)
> {
> - __sb_start_write(sb, SB_FREEZE_PAGEFAULT, true);
> + __sb_start_write_wait(sb, SB_FREEZE_PAGEFAULT, false);
> }
>
>>
>> - sb_start_pagefault(inode->i_sb);
>> + ret = sb_start_pagefault(inode->i_sb);
>> + if (ret)
>> + return VM_FAULT_RETRY;
>> ret = btrfs_delalloc_reserve_space(inode, PAGE_CACHE_SIZE);
>
> Does the compiler not warn that you're assigning void to 'ret'? Or was
> there some other SNAFU sending these patches?
>
I'm sorry, my fault :) As I said in 00 these patches are completely
*not* tested, it was only a "quick coding & review" to understand if
someone can see any problem to this kind of implementation, since I
touched several points in the kernel. So there is still on-going work
and I need to do several tests. Maybe I had to add the RFC tag, sorry again.
Marco
WARNING: multiple messages have this Message-ID (diff)
From: Marco Stornelli <marco.stornelli@gmail.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: linux-fsdevel@vger.kernel.org,
Chris Mason <chris.mason@fusionio.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Jaegeuk Kim <jaegeuk.kim@samsung.com>,
Steven Whitehouse <swhiteho@redhat.com>,
KONISHI Ryusuke <konishi.ryusuke@lab.ntt.co.jp>,
Mark Fasheh <mfasheh@suse.com>, Joel Becker <jlbec@evilplan.org>,
Mike Snitzer <snitzer@redhat.com>,
Alasdair G Kergon <agk@redhat.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com,
linux-nilfs@vger.kernel.org, ocfs2-devel@oss.oracle.com,
linux-mm@kvack.org, Jan Kara <jack@suse.cz>
Subject: [Ocfs2-devel] [PATCH 3/4] fsfreeze: manage kill signal when sb_start_pagefault is called
Date: Sat, 06 Apr 2013 15:07:21 -0000 [thread overview]
Message-ID: <51603877.7070904@gmail.com> (raw)
In-Reply-To: <20130406132028.GD28744@parisc-linux.org>
Il 06/04/2013 15:20, Matthew Wilcox ha scritto:
> On Sat, Apr 06, 2013 at 12:05:52PM +0200, Marco Stornelli wrote:
>> In every place where sb_start_pagefault was called now we must manage
>> the error code and return VM_FAULT_RETRY.
>
> Erm ... in patch 1/4:
>
> static inline void sb_start_pagefault(struct super_block *sb)
> {
> - __sb_start_write(sb, SB_FREEZE_PAGEFAULT, true);
> + __sb_start_write_wait(sb, SB_FREEZE_PAGEFAULT, false);
> }
>
>>
>> - sb_start_pagefault(inode->i_sb);
>> + ret = sb_start_pagefault(inode->i_sb);
>> + if (ret)
>> + return VM_FAULT_RETRY;
>> ret = btrfs_delalloc_reserve_space(inode, PAGE_CACHE_SIZE);
>
> Does the compiler not warn that you're assigning void to 'ret'? Or was
> there some other SNAFU sending these patches?
>
I'm sorry, my fault :) As I said in 00 these patches are completely
*not* tested, it was only a "quick coding & review" to understand if
someone can see any problem to this kind of implementation, since I
touched several points in the kernel. So there is still on-going work
and I need to do several tests. Maybe I had to add the RFC tag, sorry again.
Marco
WARNING: multiple messages have this Message-ID (diff)
From: Marco Stornelli <marco.stornelli@gmail.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: linux-fsdevel@vger.kernel.org,
Chris Mason <chris.mason@fusionio.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Jaegeuk Kim <jaegeuk.kim@samsung.com>,
Steven Whitehouse <swhiteho@redhat.com>,
KONISHI Ryusuke <konishi.ryusuke@lab.ntt.co.jp>,
Mark Fasheh <mfasheh@suse.com>, Joel Becker <jlbec@evilplan.org>,
Mike Snitzer <snitzer@redhat.com>,
Alasdair G Kergon <agk@redhat.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com,
linux-nilfs@vger.kernel.org, ocfs2-devel@oss.oracle.com,
linux-mm@kvack.org, Jan Kara <jack@suse.cz>
Subject: Re: [PATCH 3/4] fsfreeze: manage kill signal when sb_start_pagefault is called
Date: Sat, 06 Apr 2013 17:00:07 +0200 [thread overview]
Message-ID: <51603877.7070904@gmail.com> (raw)
In-Reply-To: <20130406132028.GD28744@parisc-linux.org>
Il 06/04/2013 15:20, Matthew Wilcox ha scritto:
> On Sat, Apr 06, 2013 at 12:05:52PM +0200, Marco Stornelli wrote:
>> In every place where sb_start_pagefault was called now we must manage
>> the error code and return VM_FAULT_RETRY.
>
> Erm ... in patch 1/4:
>
> static inline void sb_start_pagefault(struct super_block *sb)
> {
> - __sb_start_write(sb, SB_FREEZE_PAGEFAULT, true);
> + __sb_start_write_wait(sb, SB_FREEZE_PAGEFAULT, false);
> }
>
>>
>> - sb_start_pagefault(inode->i_sb);
>> + ret = sb_start_pagefault(inode->i_sb);
>> + if (ret)
>> + return VM_FAULT_RETRY;
>> ret = btrfs_delalloc_reserve_space(inode, PAGE_CACHE_SIZE);
>
> Does the compiler not warn that you're assigning void to 'ret'? Or was
> there some other SNAFU sending these patches?
>
I'm sorry, my fault :) As I said in 00 these patches are completely
*not* tested, it was only a "quick coding & review" to understand if
someone can see any problem to this kind of implementation, since I
touched several points in the kernel. So there is still on-going work
and I need to do several tests. Maybe I had to add the RFC tag, sorry again.
Marco
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-04-06 15:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-06 10:05 [Cluster-devel] [PATCH 3/4] fsfreeze: manage kill signal when sb_start_pagefault is called Marco Stornelli
2013-04-06 10:13 ` [Ocfs2-devel] " Marco Stornelli
2013-04-06 10:05 ` Marco Stornelli
2013-04-06 10:05 ` Marco Stornelli
2013-04-06 13:20 ` [Cluster-devel] " Matthew Wilcox
2013-04-06 13:20 ` [Ocfs2-devel] " Matthew Wilcox
2013-04-06 13:20 ` Matthew Wilcox
2013-04-06 13:20 ` Matthew Wilcox
2013-04-06 15:00 ` Marco Stornelli [this message]
2013-04-06 15:07 ` [Ocfs2-devel] " Marco Stornelli
2013-04-06 15:00 ` Marco Stornelli
2013-04-06 15:00 ` Marco Stornelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51603877.7070904@gmail.com \
--to=marco.stornelli@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.