All of lore.kernel.org
 help / color / mirror / Atom feed
From: Li Zefan <lizefan@huawei.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Tejun Heo <tj@kernel.org>, Glauber Costa <glommer@parallels.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Cgroups <cgroups@vger.kernel.org>,
	linux-mm@kvack.org
Subject: [PATCH 11/12] memcg: kill memcg refcnt
Date: Mon, 8 Apr 2013 14:36:04 +0800	[thread overview]
Message-ID: <51626554.7090706@huawei.com> (raw)
In-Reply-To: <5162648B.9070802@huawei.com>

Now memcg has the same life cycle as its corresponding cgroup.
Kill the useless refcnt.

Signed-off-by: Li Zefan <lizefan@huawei.com>
Acked-by: Michal Hocko <mhocko@suse.cz>
Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
---
 mm/memcontrol.c | 18 +-----------------
 1 file changed, 1 insertion(+), 17 deletions(-)

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 9ca5a99..a6d44bc 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -297,8 +297,6 @@ struct mem_cgroup {
 	bool		oom_lock;
 	atomic_t	under_oom;
 
-	atomic_t	refcnt;
-
 	int	swappiness;
 	/* OOM-Killer disable */
 	int		oom_kill_disable;
@@ -501,8 +499,6 @@ enum res_type {
  */
 static DEFINE_MUTEX(memcg_create_mutex);
 
-static void mem_cgroup_put(struct mem_cgroup *memcg);
-
 static inline
 struct mem_cgroup *mem_cgroup_from_css(struct cgroup_subsys_state *s)
 {
@@ -6124,17 +6120,6 @@ static void free_rcu(struct rcu_head *rcu_head)
 	schedule_work(&memcg->work_freeing);
 }
 
-static void __mem_cgroup_put(struct mem_cgroup *memcg, int count)
-{
-	if (atomic_sub_and_test(count, &memcg->refcnt))
-		call_rcu(&memcg->rcu_freeing, free_rcu);
-}
-
-static void mem_cgroup_put(struct mem_cgroup *memcg)
-{
-	__mem_cgroup_put(memcg, 1);
-}
-
 /*
  * Returns the parent mem_cgroup in memcgroup hierarchy with hierarchy enabled.
  */
@@ -6194,7 +6179,6 @@ mem_cgroup_css_alloc(struct cgroup *cont)
 
 	memcg->last_scanned_node = MAX_NUMNODES;
 	INIT_LIST_HEAD(&memcg->oom_notify);
-	atomic_set(&memcg->refcnt, 1);
 	memcg->move_charge_at_immigrate = 0;
 	mutex_init(&memcg->thresholds_lock);
 	spin_lock_init(&memcg->move_lock);
@@ -6285,7 +6269,7 @@ static void mem_cgroup_css_free(struct cgroup *cont)
 
 	mem_cgroup_sockets_destroy(memcg);
 
-	mem_cgroup_put(memcg);
+	call_rcu(&memcg->rcu_freeing, free_rcu);
 }
 
 #ifdef CONFIG_MMU
-- 
1.8.0.2

WARNING: multiple messages have this Message-ID (diff)
From: Li Zefan <lizefan@huawei.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Tejun Heo <tj@kernel.org>, Glauber Costa <glommer@parallels.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Cgroups <cgroups@vger.kernel.org>,
	linux-mm@kvack.org
Subject: [PATCH 11/12] memcg: kill memcg refcnt
Date: Mon, 8 Apr 2013 14:36:04 +0800	[thread overview]
Message-ID: <51626554.7090706@huawei.com> (raw)
In-Reply-To: <5162648B.9070802@huawei.com>

Now memcg has the same life cycle as its corresponding cgroup.
Kill the useless refcnt.

Signed-off-by: Li Zefan <lizefan@huawei.com>
Acked-by: Michal Hocko <mhocko@suse.cz>
Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
---
 mm/memcontrol.c | 18 +-----------------
 1 file changed, 1 insertion(+), 17 deletions(-)

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 9ca5a99..a6d44bc 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -297,8 +297,6 @@ struct mem_cgroup {
 	bool		oom_lock;
 	atomic_t	under_oom;
 
-	atomic_t	refcnt;
-
 	int	swappiness;
 	/* OOM-Killer disable */
 	int		oom_kill_disable;
@@ -501,8 +499,6 @@ enum res_type {
  */
 static DEFINE_MUTEX(memcg_create_mutex);
 
-static void mem_cgroup_put(struct mem_cgroup *memcg);
-
 static inline
 struct mem_cgroup *mem_cgroup_from_css(struct cgroup_subsys_state *s)
 {
@@ -6124,17 +6120,6 @@ static void free_rcu(struct rcu_head *rcu_head)
 	schedule_work(&memcg->work_freeing);
 }
 
-static void __mem_cgroup_put(struct mem_cgroup *memcg, int count)
-{
-	if (atomic_sub_and_test(count, &memcg->refcnt))
-		call_rcu(&memcg->rcu_freeing, free_rcu);
-}
-
-static void mem_cgroup_put(struct mem_cgroup *memcg)
-{
-	__mem_cgroup_put(memcg, 1);
-}
-
 /*
  * Returns the parent mem_cgroup in memcgroup hierarchy with hierarchy enabled.
  */
@@ -6194,7 +6179,6 @@ mem_cgroup_css_alloc(struct cgroup *cont)
 
 	memcg->last_scanned_node = MAX_NUMNODES;
 	INIT_LIST_HEAD(&memcg->oom_notify);
-	atomic_set(&memcg->refcnt, 1);
 	memcg->move_charge_at_immigrate = 0;
 	mutex_init(&memcg->thresholds_lock);
 	spin_lock_init(&memcg->move_lock);
@@ -6285,7 +6269,7 @@ static void mem_cgroup_css_free(struct cgroup *cont)
 
 	mem_cgroup_sockets_destroy(memcg);
 
-	mem_cgroup_put(memcg);
+	call_rcu(&memcg->rcu_freeing, free_rcu);
 }
 
 #ifdef CONFIG_MMU
-- 
1.8.0.2

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Li Zefan <lizefan@huawei.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Tejun Heo <tj@kernel.org>, Glauber Costa <glommer@parallels.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Cgroups <cgroups@vger.kernel.org>, <linux-mm@kvack.org>
Subject: [PATCH 11/12] memcg: kill memcg refcnt
Date: Mon, 8 Apr 2013 14:36:04 +0800	[thread overview]
Message-ID: <51626554.7090706@huawei.com> (raw)
In-Reply-To: <5162648B.9070802@huawei.com>

Now memcg has the same life cycle as its corresponding cgroup.
Kill the useless refcnt.

Signed-off-by: Li Zefan <lizefan@huawei.com>
Acked-by: Michal Hocko <mhocko@suse.cz>
Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
---
 mm/memcontrol.c | 18 +-----------------
 1 file changed, 1 insertion(+), 17 deletions(-)

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 9ca5a99..a6d44bc 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -297,8 +297,6 @@ struct mem_cgroup {
 	bool		oom_lock;
 	atomic_t	under_oom;
 
-	atomic_t	refcnt;
-
 	int	swappiness;
 	/* OOM-Killer disable */
 	int		oom_kill_disable;
@@ -501,8 +499,6 @@ enum res_type {
  */
 static DEFINE_MUTEX(memcg_create_mutex);
 
-static void mem_cgroup_put(struct mem_cgroup *memcg);
-
 static inline
 struct mem_cgroup *mem_cgroup_from_css(struct cgroup_subsys_state *s)
 {
@@ -6124,17 +6120,6 @@ static void free_rcu(struct rcu_head *rcu_head)
 	schedule_work(&memcg->work_freeing);
 }
 
-static void __mem_cgroup_put(struct mem_cgroup *memcg, int count)
-{
-	if (atomic_sub_and_test(count, &memcg->refcnt))
-		call_rcu(&memcg->rcu_freeing, free_rcu);
-}
-
-static void mem_cgroup_put(struct mem_cgroup *memcg)
-{
-	__mem_cgroup_put(memcg, 1);
-}
-
 /*
  * Returns the parent mem_cgroup in memcgroup hierarchy with hierarchy enabled.
  */
@@ -6194,7 +6179,6 @@ mem_cgroup_css_alloc(struct cgroup *cont)
 
 	memcg->last_scanned_node = MAX_NUMNODES;
 	INIT_LIST_HEAD(&memcg->oom_notify);
-	atomic_set(&memcg->refcnt, 1);
 	memcg->move_charge_at_immigrate = 0;
 	mutex_init(&memcg->thresholds_lock);
 	spin_lock_init(&memcg->move_lock);
@@ -6285,7 +6269,7 @@ static void mem_cgroup_css_free(struct cgroup *cont)
 
 	mem_cgroup_sockets_destroy(memcg);
 
-	mem_cgroup_put(memcg);
+	call_rcu(&memcg->rcu_freeing, free_rcu);
 }
 
 #ifdef CONFIG_MMU
-- 
1.8.0.2

  parent reply	other threads:[~2013-04-08  6:36 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-08  6:32 [PATCH 0/12][V2] memcg: make memcg's life cycle the same as cgroup Li Zefan
2013-04-08  6:32 ` Li Zefan
2013-04-08  6:32 ` Li Zefan
     [not found] ` <5162648B.9070802-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-04-08  6:33   ` [PATCH 01/12] memcg: take reference before releasing rcu_read_lock Li Zefan
2013-04-08  6:33     ` Li Zefan
2013-04-08  6:33     ` Li Zefan
2013-04-08  6:33   ` [PATCH 02/12] memcg: avoid accessing memcg after releasing reference Li Zefan
2013-04-08  6:33     ` Li Zefan
2013-04-08  6:33     ` Li Zefan
2013-04-08  6:33   ` [PATCH 03/12] Revert "memcg: avoid dangling reference count in creation failure." Li Zefan
2013-04-08  6:33     ` Li Zefan
2013-04-08  6:33     ` Li Zefan
2013-04-09  2:50     ` Kamezawa Hiroyuki
2013-04-09  2:50       ` Kamezawa Hiroyuki
2013-04-08  6:33   ` [PATCH 04/12] memcg, kmem: fix reference count handling on the error path Li Zefan
2013-04-08  6:33     ` Li Zefan
2013-04-08  6:33     ` Li Zefan
     [not found]     ` <516264D6.3090100-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-04-09  2:51       ` Kamezawa Hiroyuki
2013-04-09  2:51         ` Kamezawa Hiroyuki
2013-04-09  2:51         ` Kamezawa Hiroyuki
2013-04-08  6:35   ` [PATCH 09/12] cgroup: make sure parent won't be destroyed before its children Li Zefan
2013-04-08  6:35     ` Li Zefan
2013-04-08  6:35     ` Li Zefan
     [not found]     ` <51626516.3000603-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-04-08 15:36       ` Tejun Heo
2013-04-08 15:36         ` Tejun Heo
2013-04-08 15:36         ` Tejun Heo
2013-04-08  6:35   ` [PATCH 10/12] memcg: don't need to get a reference to the parent Li Zefan
2013-04-08  6:35     ` Li Zefan
2013-04-08  6:35     ` Li Zefan
2013-04-08  6:36   ` [PATCH 12/12] memcg: don't need to free memcg via RCU or workqueue Li Zefan
2013-04-08  6:36     ` Li Zefan
2013-04-08  6:36     ` Li Zefan
2013-04-08 14:15     ` Michal Hocko
2013-04-08 14:15       ` Michal Hocko
     [not found]     ` <51626570.8000400-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-04-09  2:57       ` Kamezawa Hiroyuki
2013-04-09  2:57         ` Kamezawa Hiroyuki
2013-04-09  2:57         ` Kamezawa Hiroyuki
2013-04-08  6:34 ` [PATCH 05/12] memcg: use css_get() in sock_update_memcg() Li Zefan
2013-04-08  6:34   ` Li Zefan
2013-04-08  6:34   ` Li Zefan
2013-04-08  6:34 ` [PATCH 06/12] memcg: don't use mem_cgroup_get() when creating a kmemcg cache Li Zefan
2013-04-08  6:34   ` Li Zefan
2013-04-08  6:34   ` Li Zefan
2013-04-09  2:53   ` Kamezawa Hiroyuki
2013-04-09  2:53     ` Kamezawa Hiroyuki
2013-04-08  6:34 ` [PATCH 07/12] memcg: use css_get/put when charging/uncharging kmem Li Zefan
2013-04-08  6:34   ` Li Zefan
2013-04-08  6:34   ` Li Zefan
2013-04-08 14:14   ` Michal Hocko
2013-04-08 14:14     ` Michal Hocko
2013-04-09  2:55   ` Kamezawa Hiroyuki
2013-04-09  2:55     ` Kamezawa Hiroyuki
2013-04-08  6:34 ` [PATCH 08/12] memcg: use css_get/put for swap memcg Li Zefan
2013-04-08  6:34   ` Li Zefan
2013-04-08  6:34   ` Li Zefan
2013-04-08  6:36 ` Li Zefan [this message]
2013-04-08  6:36   ` [PATCH 11/12] memcg: kill memcg refcnt Li Zefan
2013-04-08  6:36   ` Li Zefan
2013-04-08  6:36 ` [PATCH 13/12] memcg: don't need memcg->memcg_name Li Zefan
2013-04-08  6:36   ` Li Zefan
2013-04-08  6:36   ` Li Zefan
2013-04-08 14:25   ` Michal Hocko
2013-04-08 14:25     ` Michal Hocko
     [not found]     ` <20130408142503.GH17178-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2013-04-09  1:28       ` Li Zefan
2013-04-09  1:28         ` Li Zefan
2013-04-09  1:28         ` Li Zefan
2013-04-09  3:10   ` Kamezawa Hiroyuki
2013-04-09  3:10     ` Kamezawa Hiroyuki
     [not found]     ` <5163868B.3020905-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2013-04-09  3:18       ` Li Zefan
2013-04-09  3:18         ` Li Zefan
2013-04-09  3:18         ` Li Zefan
2013-04-09  3:46         ` Kamezawa Hiroyuki
2013-04-09  3:46           ` Kamezawa Hiroyuki
     [not found]           ` <51638F2B.3000800-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2013-04-09  7:55             ` Glauber Costa
2013-04-09  7:55               ` Glauber Costa
2013-04-09  7:55               ` Glauber Costa
     [not found]         ` <5163887D.1040809-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-04-09  3:59           ` Tejun Heo
2013-04-09  3:59             ` Tejun Heo
2013-04-09  3:59             ` Tejun Heo
2013-04-09  7:53         ` Glauber Costa
2013-04-09  7:53           ` Glauber Costa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51626554.7090706@huawei.com \
    --to=lizefan@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=cgroups@vger.kernel.org \
    --cc=glommer@parallels.com \
    --cc=hannes@cmpxchg.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.