All of lore.kernel.org
 help / color / mirror / Atom feed
From: Li Zefan <lizefan@huawei.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Tejun Heo <tj@kernel.org>, Glauber Costa <glommer@parallels.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Michal Hocko <mhocko@suse.cz>,
	Johannes Weiner <hannes@cmpxchg.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Cgroups <cgroups@vger.kernel.org>,
	linux-mm@kvack.org
Subject: [PATCH 1/8] cgroup: implement cgroup_is_ancestor()
Date: Mon, 8 Apr 2013 16:20:11 +0800	[thread overview]
Message-ID: <51627DBB.5050005@huawei.com> (raw)
In-Reply-To: <51627DA9.7020507@huawei.com>

This will be used as a replacement for css_is_ancestor().

Signed-off-by: Li Zefan <lizefan@huawei.com>
---
 include/linux/cgroup.h |  3 +++
 kernel/cgroup.c        | 21 +++++++++++++++++++++
 2 files changed, 24 insertions(+)

diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h
index 2eaedc1..96072e4 100644
--- a/include/linux/cgroup.h
+++ b/include/linux/cgroup.h
@@ -177,6 +177,7 @@ struct cgroup {
 	atomic_t count;
 
 	int id;				/* ida allocated in-hierarchy ID */
+	int depth;			/* the depth of the cgroup */
 
 	/*
 	 * We link our 'sibling' struct into our parent's 'children'.
@@ -730,6 +731,8 @@ unsigned short css_id(struct cgroup_subsys_state *css);
 unsigned short css_depth(struct cgroup_subsys_state *css);
 struct cgroup_subsys_state *cgroup_css_from_dir(struct file *f, int id);
 
+bool cgroup_is_ancestor(struct cgroup *child, struct cgroup *root);
+
 #else /* !CONFIG_CGROUPS */
 
 static inline int cgroup_init_early(void) { return 0; }
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 7ee3bdf..e87872c 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -4133,6 +4133,7 @@ static long cgroup_create(struct cgroup *parent, struct dentry *dentry,
 	cgrp->dentry = dentry;
 
 	cgrp->parent = parent;
+	cgrp->depth = parent->depth + 1;
 	cgrp->root = parent->root;
 	cgrp->top_cgroup = parent->top_cgroup;
 
@@ -5299,6 +5300,26 @@ struct cgroup_subsys_state *cgroup_css_from_dir(struct file *f, int id)
 	return css ? css : ERR_PTR(-ENOENT);
 }
 
+/**
+ * cgroup_is_ancestor - test "root" cgroup is an ancestor of "child"
+ * @child: the cgroup to be tested.
+ * @root: the cgroup supposed to be an ancestor of the child.
+ *
+ * Returns true if "root" is an ancestor of "child" in its hierarchy.
+ */
+bool cgroup_is_ancestor(struct cgroup *child, struct cgroup *root)
+{
+	int depth = child->depth;
+
+	if (depth < root->depth)
+		return false;
+
+	while (depth-- != root->depth)
+		child = child->parent;
+
+	return (child == root);
+}
+
 #ifdef CONFIG_CGROUP_DEBUG
 static struct cgroup_subsys_state *debug_css_alloc(struct cgroup *cont)
 {
-- 
1.8.0.2

WARNING: multiple messages have this Message-ID (diff)
From: Li Zefan <lizefan@huawei.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Tejun Heo <tj@kernel.org>, Glauber Costa <glommer@parallels.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Michal Hocko <mhocko@suse.cz>,
	Johannes Weiner <hannes@cmpxchg.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Cgroups <cgroups@vger.kernel.org>,
	linux-mm@kvack.org
Subject: [PATCH 1/8] cgroup: implement cgroup_is_ancestor()
Date: Mon, 8 Apr 2013 16:20:11 +0800	[thread overview]
Message-ID: <51627DBB.5050005@huawei.com> (raw)
In-Reply-To: <51627DA9.7020507@huawei.com>

This will be used as a replacement for css_is_ancestor().

Signed-off-by: Li Zefan <lizefan@huawei.com>
---
 include/linux/cgroup.h |  3 +++
 kernel/cgroup.c        | 21 +++++++++++++++++++++
 2 files changed, 24 insertions(+)

diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h
index 2eaedc1..96072e4 100644
--- a/include/linux/cgroup.h
+++ b/include/linux/cgroup.h
@@ -177,6 +177,7 @@ struct cgroup {
 	atomic_t count;
 
 	int id;				/* ida allocated in-hierarchy ID */
+	int depth;			/* the depth of the cgroup */
 
 	/*
 	 * We link our 'sibling' struct into our parent's 'children'.
@@ -730,6 +731,8 @@ unsigned short css_id(struct cgroup_subsys_state *css);
 unsigned short css_depth(struct cgroup_subsys_state *css);
 struct cgroup_subsys_state *cgroup_css_from_dir(struct file *f, int id);
 
+bool cgroup_is_ancestor(struct cgroup *child, struct cgroup *root);
+
 #else /* !CONFIG_CGROUPS */
 
 static inline int cgroup_init_early(void) { return 0; }
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 7ee3bdf..e87872c 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -4133,6 +4133,7 @@ static long cgroup_create(struct cgroup *parent, struct dentry *dentry,
 	cgrp->dentry = dentry;
 
 	cgrp->parent = parent;
+	cgrp->depth = parent->depth + 1;
 	cgrp->root = parent->root;
 	cgrp->top_cgroup = parent->top_cgroup;
 
@@ -5299,6 +5300,26 @@ struct cgroup_subsys_state *cgroup_css_from_dir(struct file *f, int id)
 	return css ? css : ERR_PTR(-ENOENT);
 }
 
+/**
+ * cgroup_is_ancestor - test "root" cgroup is an ancestor of "child"
+ * @child: the cgroup to be tested.
+ * @root: the cgroup supposed to be an ancestor of the child.
+ *
+ * Returns true if "root" is an ancestor of "child" in its hierarchy.
+ */
+bool cgroup_is_ancestor(struct cgroup *child, struct cgroup *root)
+{
+	int depth = child->depth;
+
+	if (depth < root->depth)
+		return false;
+
+	while (depth-- != root->depth)
+		child = child->parent;
+
+	return (child == root);
+}
+
 #ifdef CONFIG_CGROUP_DEBUG
 static struct cgroup_subsys_state *debug_css_alloc(struct cgroup *cont)
 {
-- 
1.8.0.2

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Li Zefan <lizefan@huawei.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Tejun Heo <tj@kernel.org>, Glauber Costa <glommer@parallels.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Michal Hocko <mhocko@suse.cz>,
	Johannes Weiner <hannes@cmpxchg.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Cgroups <cgroups@vger.kernel.org>, <linux-mm@kvack.org>
Subject: [PATCH 1/8] cgroup: implement cgroup_is_ancestor()
Date: Mon, 8 Apr 2013 16:20:11 +0800	[thread overview]
Message-ID: <51627DBB.5050005@huawei.com> (raw)
In-Reply-To: <51627DA9.7020507@huawei.com>

This will be used as a replacement for css_is_ancestor().

Signed-off-by: Li Zefan <lizefan@huawei.com>
---
 include/linux/cgroup.h |  3 +++
 kernel/cgroup.c        | 21 +++++++++++++++++++++
 2 files changed, 24 insertions(+)

diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h
index 2eaedc1..96072e4 100644
--- a/include/linux/cgroup.h
+++ b/include/linux/cgroup.h
@@ -177,6 +177,7 @@ struct cgroup {
 	atomic_t count;
 
 	int id;				/* ida allocated in-hierarchy ID */
+	int depth;			/* the depth of the cgroup */
 
 	/*
 	 * We link our 'sibling' struct into our parent's 'children'.
@@ -730,6 +731,8 @@ unsigned short css_id(struct cgroup_subsys_state *css);
 unsigned short css_depth(struct cgroup_subsys_state *css);
 struct cgroup_subsys_state *cgroup_css_from_dir(struct file *f, int id);
 
+bool cgroup_is_ancestor(struct cgroup *child, struct cgroup *root);
+
 #else /* !CONFIG_CGROUPS */
 
 static inline int cgroup_init_early(void) { return 0; }
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 7ee3bdf..e87872c 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -4133,6 +4133,7 @@ static long cgroup_create(struct cgroup *parent, struct dentry *dentry,
 	cgrp->dentry = dentry;
 
 	cgrp->parent = parent;
+	cgrp->depth = parent->depth + 1;
 	cgrp->root = parent->root;
 	cgrp->top_cgroup = parent->top_cgroup;
 
@@ -5299,6 +5300,26 @@ struct cgroup_subsys_state *cgroup_css_from_dir(struct file *f, int id)
 	return css ? css : ERR_PTR(-ENOENT);
 }
 
+/**
+ * cgroup_is_ancestor - test "root" cgroup is an ancestor of "child"
+ * @child: the cgroup to be tested.
+ * @root: the cgroup supposed to be an ancestor of the child.
+ *
+ * Returns true if "root" is an ancestor of "child" in its hierarchy.
+ */
+bool cgroup_is_ancestor(struct cgroup *child, struct cgroup *root)
+{
+	int depth = child->depth;
+
+	if (depth < root->depth)
+		return false;
+
+	while (depth-- != root->depth)
+		child = child->parent;
+
+	return (child == root);
+}
+
 #ifdef CONFIG_CGROUP_DEBUG
 static struct cgroup_subsys_state *debug_css_alloc(struct cgroup *cont)
 {
-- 
1.8.0.2

  reply	other threads:[~2013-04-08  8:20 UTC|newest]

Thread overview: 98+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-08  8:19 [PATCH 0/8] memcg, cgroup: kill css_id Li Zefan
2013-04-08  8:19 ` Li Zefan
2013-04-08  8:19 ` Li Zefan
2013-04-08  8:20 ` Li Zefan [this message]
2013-04-08  8:20   ` [PATCH 1/8] cgroup: implement cgroup_is_ancestor() Li Zefan
2013-04-08  8:20   ` Li Zefan
2013-04-08 14:47   ` Michal Hocko
2013-04-08 14:47     ` Michal Hocko
2013-04-08 15:57     ` Tejun Heo
2013-04-08 15:57       ` Tejun Heo
2013-04-08 16:33       ` Michal Hocko
2013-04-08 16:33         ` Michal Hocko
2013-04-08 18:03     ` Michal Hocko
2013-04-08 18:03       ` Michal Hocko
2013-04-08 18:03       ` Michal Hocko
2013-04-08 21:36       ` Tejun Heo
2013-04-08 21:36         ` Tejun Heo
     [not found]         ` <20130408213646.GB17159-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2013-04-09  6:42           ` Michal Hocko
2013-04-09  6:42             ` Michal Hocko
2013-04-09  6:42             ` Michal Hocko
     [not found]   ` <51627DBB.5050005-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-04-08 15:39     ` Tejun Heo
2013-04-08 15:39       ` Tejun Heo
2013-04-08 15:39       ` Tejun Heo
2013-04-09  3:21   ` Kamezawa Hiroyuki
2013-04-09  3:21     ` Kamezawa Hiroyuki
     [not found]     ` <51638947.9060303-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2013-04-09  3:29       ` Li Zefan
2013-04-09  3:29         ` Li Zefan
2013-04-09  3:29         ` Li Zefan
2013-04-08  8:21 ` [PATCH 3/8] memcg: convert to use cgroup_is_ancestor() Li Zefan
2013-04-08  8:21   ` Li Zefan
2013-04-08  8:21   ` Li Zefan
     [not found]   ` <51627DFA.9050007-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-04-09  3:58     ` Kamezawa Hiroyuki
2013-04-09  3:58       ` Kamezawa Hiroyuki
2013-04-09  3:58       ` Kamezawa Hiroyuki
2013-04-09  6:49     ` Michal Hocko
2013-04-09  6:49       ` Michal Hocko
2013-04-09  6:49       ` Michal Hocko
2013-04-08  8:23 ` [PATCH 7/8] memcg: don't use css_id any more Li Zefan
2013-04-08  8:23   ` Li Zefan
2013-04-08  8:23   ` Li Zefan
     [not found]   ` <51627E74.5020300-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-04-08 15:01     ` Michal Hocko
2013-04-08 15:01       ` Michal Hocko
2013-04-08 15:01       ` Michal Hocko
2013-04-09  4:11     ` Kamezawa Hiroyuki
2013-04-09  4:11       ` Kamezawa Hiroyuki
2013-04-09  4:11       ` Kamezawa Hiroyuki
     [not found] ` <51627DA9.7020507-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-04-08  8:20   ` [PATCH 2/8] cgroup: implement cgroup_from_id() Li Zefan
2013-04-08  8:20     ` Li Zefan
2013-04-08  8:20     ` Li Zefan
2013-04-08 15:43     ` Tejun Heo
2013-04-08 15:43       ` Tejun Heo
     [not found]       ` <20130408154319.GD3021-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2013-04-09  3:12         ` Li Zefan
2013-04-09  3:12           ` Li Zefan
2013-04-09  3:12           ` Li Zefan
2013-04-08 15:48     ` Tejun Heo
2013-04-08 15:48       ` Tejun Heo
2013-04-09  3:56     ` Kamezawa Hiroyuki
2013-04-09  3:56       ` Kamezawa Hiroyuki
     [not found]     ` <51627DEB.4090104-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-04-09  4:08       ` Kamezawa Hiroyuki
2013-04-09  4:08         ` Kamezawa Hiroyuki
2013-04-09  4:08         ` Kamezawa Hiroyuki
2013-04-08  8:21   ` [PATCH 4/8] memcg: convert to use cgroup_from_id() Li Zefan
2013-04-08  8:21     ` Li Zefan
2013-04-08  8:21     ` Li Zefan
2013-04-08 14:53     ` Michal Hocko
2013-04-08 14:53       ` Michal Hocko
     [not found]       ` <20130408145333.GL17178-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2013-04-09  3:00         ` Li Zefan
2013-04-09  3:00           ` Li Zefan
2013-04-09  3:00           ` Li Zefan
     [not found]     ` <51627E09.5010605-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-04-09  3:59       ` Kamezawa Hiroyuki
2013-04-09  3:59         ` Kamezawa Hiroyuki
2013-04-09  3:59         ` Kamezawa Hiroyuki
2013-04-08  8:22   ` [PATCH 5/8] memcg: convert to use cgroup->id Li Zefan
2013-04-08  8:22     ` Li Zefan
2013-04-08  8:22     ` Li Zefan
2013-04-08 14:57     ` Michal Hocko
2013-04-08 14:57       ` Michal Hocko
     [not found]       ` <20130408145702.GM17178-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2013-04-09  3:02         ` Li Zefan
2013-04-09  3:02           ` Li Zefan
2013-04-09  3:02           ` Li Zefan
2013-04-09  6:49           ` Michal Hocko
2013-04-09  6:49             ` Michal Hocko
     [not found]     ` <51627E33.4090107-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-04-09  4:02       ` Kamezawa Hiroyuki
2013-04-09  4:02         ` Kamezawa Hiroyuki
2013-04-09  4:02         ` Kamezawa Hiroyuki
2013-04-08  8:22   ` [PATCH 6/8] memcg: fail to create cgroup if the cgroup id is too big Li Zefan
2013-04-08  8:22     ` Li Zefan
2013-04-08  8:22     ` Li Zefan
2013-04-08 15:01     ` Michal Hocko
2013-04-08 15:01       ` Michal Hocko
2013-04-08  8:23   ` [PATCH 8/8] cgroup: kill css_id Li Zefan
2013-04-08  8:23     ` Li Zefan
2013-04-08  8:23     ` Li Zefan
2013-04-08 15:51     ` Tejun Heo
2013-04-08 15:51       ` Tejun Heo
2013-04-08 14:37   ` [PATCH 0/8] memcg, " Michal Hocko
2013-04-08 14:37     ` Michal Hocko
2013-04-08 14:37     ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51627DBB.5050005@huawei.com \
    --to=lizefan@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=cgroups@vger.kernel.org \
    --cc=glommer@parallels.com \
    --cc=hannes@cmpxchg.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.cz \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.