From: nsekhar@ti.com (Sekhar Nori)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/3] media: davinci: vpss: enable vpss clocks
Date: Mon, 8 Apr 2013 15:56:05 +0530 [thread overview]
Message-ID: <51629B3D.4080905@ti.com> (raw)
In-Reply-To: <1364903044-13752-2-git-send-email-prabhakar.csengg@gmail.com>
On 4/2/2013 5:14 PM, Prabhakar lad wrote:
> From: Lad, Prabhakar <prabhakar.csengg@gmail.com>
>
> By default the VPSS clocks were enabled in capture driver
> for davinci family which creates duplicates for dm355/dm365/dm644x.
> This patch adds support to enable the VPSS clocks in VPSS driver,
> which avoids duplication of code and also adding clock aliases.
>
> This patch uses PM runtime API to enable/disable instead common clock
> framework. con_ids for master and slave clocks of vpss is added in pm_domain
Common clock framework in not (yet) used on DaVinci, so this is misleading.
> diff --git a/arch/arm/mach-davinci/pm_domain.c b/arch/arm/mach-davinci/pm_domain.c
> index c90250e..445b10b 100644
> --- a/arch/arm/mach-davinci/pm_domain.c
> +++ b/arch/arm/mach-davinci/pm_domain.c
> @@ -53,7 +53,7 @@ static struct dev_pm_domain davinci_pm_domain = {
>
> static struct pm_clk_notifier_block platform_bus_notifier = {
> .pm_domain = &davinci_pm_domain,
> - .con_ids = { "fck", NULL, },
> + .con_ids = { "fck", "master", "slave", NULL, },
NULL is sentinel so you can drop the ',' after that. Apart from that,
for the mach-davinci parts:
Acked-by: Sekhar Nori <nsekhar@ti.com>
Thanks,
Sekhar
WARNING: multiple messages have this Message-ID (diff)
From: Sekhar Nori <nsekhar@ti.com>
To: Prabhakar lad <prabhakar.csengg@gmail.com>
Cc: DLOS <davinci-linux-open-source@linux.davincidsp.com>,
LAK <linux-arm-kernel@lists.infradead.org>,
Mauro Carvalho Chehab <mchehab@redhat.com>,
LMML <linux-media@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] media: davinci: vpss: enable vpss clocks
Date: Mon, 8 Apr 2013 15:56:05 +0530 [thread overview]
Message-ID: <51629B3D.4080905@ti.com> (raw)
In-Reply-To: <1364903044-13752-2-git-send-email-prabhakar.csengg@gmail.com>
On 4/2/2013 5:14 PM, Prabhakar lad wrote:
> From: Lad, Prabhakar <prabhakar.csengg@gmail.com>
>
> By default the VPSS clocks were enabled in capture driver
> for davinci family which creates duplicates for dm355/dm365/dm644x.
> This patch adds support to enable the VPSS clocks in VPSS driver,
> which avoids duplication of code and also adding clock aliases.
>
> This patch uses PM runtime API to enable/disable instead common clock
> framework. con_ids for master and slave clocks of vpss is added in pm_domain
Common clock framework in not (yet) used on DaVinci, so this is misleading.
> diff --git a/arch/arm/mach-davinci/pm_domain.c b/arch/arm/mach-davinci/pm_domain.c
> index c90250e..445b10b 100644
> --- a/arch/arm/mach-davinci/pm_domain.c
> +++ b/arch/arm/mach-davinci/pm_domain.c
> @@ -53,7 +53,7 @@ static struct dev_pm_domain davinci_pm_domain = {
>
> static struct pm_clk_notifier_block platform_bus_notifier = {
> .pm_domain = &davinci_pm_domain,
> - .con_ids = { "fck", NULL, },
> + .con_ids = { "fck", "master", "slave", NULL, },
NULL is sentinel so you can drop the ',' after that. Apart from that,
for the mach-davinci parts:
Acked-by: Sekhar Nori <nsekhar@ti.com>
Thanks,
Sekhar
next prev parent reply other threads:[~2013-04-08 10:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-02 11:44 [PATCH v2 0/3] davinci: vpss: clock cleanup Prabhakar lad
2013-04-02 11:44 ` Prabhakar lad
2013-04-02 11:44 ` [PATCH v2 1/3] media: davinci: vpss: enable vpss clocks Prabhakar lad
2013-04-02 11:44 ` Prabhakar lad
2013-04-08 10:26 ` Sekhar Nori [this message]
2013-04-08 10:26 ` Sekhar Nori
2013-04-08 11:38 ` Prabhakar Lad
2013-04-08 11:38 ` Prabhakar Lad
2013-04-08 11:48 ` Sekhar Nori
2013-04-08 11:48 ` Sekhar Nori
2013-04-02 11:44 ` [PATCH v2 2/3] media: davinci: vpbe: venc: move the enabling of vpss clocks to driver Prabhakar lad
2013-04-02 11:44 ` Prabhakar lad
2013-04-02 11:44 ` [PATCH v2 3/3] davinic: vpss: trivial cleanup Prabhakar lad
2013-04-02 11:44 ` Prabhakar lad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51629B3D.4080905@ti.com \
--to=nsekhar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.